indexer: take in a merge it never took in, and read takeins (A-463, A-463a, A-464a) #238

Merged
mesh-tools merged 4 commits from fix/47-G-untaken-merge into main 2026-11-17 01:13:06 +00:00
Member

Design 47 G, the lead's answers A-463, A-463a, A-464 (comment) and A-464a (hq 03-DESIGN/01-to-be/47-milestones/G-22-lead-answers-2.md).

  • A-463: at its start and on every source revision the indexer compares each repository's taken merge with the source's head and takes a behind one in through the catch-up, with the finding merge-untaken while behind.
  • A-463a: a head the pending holds is not behind; a revision heard during a catch-up is compared when it ends.
  • A-464a: the tool indexer_read_takeins.

Group with mesh-catalog fix/47-G-untaken-merge (the gate, A-464..A-464d); neither names the other's version.

Tests: go vet, go vet -tags integration, go test ./... pass; each new test fails without its fix (developer and reviewer). TestIndexerWritesModulesAtAMerge fails at base 44bdbbcb too, not this change. Validator: the indexer's manifest accepted, change and trunk (in process, 169/169, 65 seat definitions).

Quick vs thorough: thorough (every repository, every merge, at start and live); the quick one would be a hand catch-up per repository, which met the same stale source.

Reviewed-by: mesh-code-reviewer for lead-47@shanks at 223b096295 (round 2)

Design 47 G, the lead's answers A-463, A-463a, A-464 (comment) and A-464a (hq 03-DESIGN/01-to-be/47-milestones/G-22-lead-answers-2.md). - A-463: at its start and on every source revision the indexer compares each repository's taken merge with the source's head and takes a behind one in through the catch-up, with the finding merge-untaken while behind. - A-463a: a head the pending holds is not behind; a revision heard during a catch-up is compared when it ends. - A-464a: the tool indexer_read_takeins. Group with mesh-catalog fix/47-G-untaken-merge (the gate, A-464..A-464d); neither names the other's version. Tests: go vet, go vet -tags integration, go test ./... pass; each new test fails without its fix (developer and reviewer). TestIndexerWritesModulesAtAMerge fails at base 44bdbbcb too, not this change. Validator: the indexer's manifest accepted, change and trunk (in process, 169/169, 65 seat definitions). Quick vs thorough: thorough (every repository, every merge, at start and live); the quick one would be a hand catch-up per repository, which met the same stale source. Reviewed-by: mesh-code-reviewer for lead-47@shanks at 223b09629531345bd94ce8d78ad8f455c808771f (round 2)
mesh-tools added 4 commits 2026-11-17 01:12:57 +00:00
Builds: design 47 G-22 A-464a
At its start and on every source revision the indexer compares each repository's taken merge with the head the gate's source names; a repository behind is taken in as its merged message would have been, with the finding merge-untaken raised until it is.

Builds: design 47 G-22 A-463
Builds: design 47 G-22 A-464
Builds: design 47 G-22 A-463a, A-463
mesh-tools merged commit eed0833a29 into main 2026-11-17 01:13:06 +00:00
mesh-tools deleted branch fix/47-G-untaken-merge 2026-11-17 01:13:06 +00:00
Author
Member

{
"records": [
{
"instance": "record/main_992_5ae6ed5f/10f7fc04dd689cbf",
"sequence": 9627,
"bytes": 1829,
"of-bytes": 262144,
"waits": "its difference is not known yet",
"record": {
"milestone": "main.992",
"heads": {
"novox/mesh-delivery@238": "eed0833a29f81c39d515dbd0f4cee51c858d2f95"
},
"opened": "2026-11-17T07:56:07.380818211Z",
"form": 1,
"group": {
"group": "",
"members": [
"novox/mesh-catalog@697",
"novox/mesh-delivery@238",
"novox/mesh-host@233"
],
"pulls": [
{
"repository": "novox/mesh-delivery",
"number": 238,
"head": "eed0833a29f81c39d515dbd0f4cee51c858d2f95",
"state": "merged",
"commit": "eed0833a29f81c39d515dbd0f4cee51c858d2f95"
}
]
},
"entries": {
"mesh-delivery-assigner|src2:c723d3d756e23a1d76ff0e1ea6c2a64632217d0e488933db4769df392f369dfd|": {
"key": "mesh-delivery-assigner|src2:c723d3d756e23a1d76ff0e1ea6c2a64632217d0e488933db4769df392f369dfd|",
"module": "mesh-delivery-assigner",
"fingerprint": "src2:c723d3d756e23a1d76ff0e1ea6c2a64632217d0e488933db4769df392f369dfd"
},
"mesh-delivery-gate|src2:8dec18c3c71e1766b5c8700b79e18281b36d3589a393e22002b8ee57b0f42c79|": {
"key": "mesh-delivery-gate|src2:8dec18c3c71e1766b5c8700b79e18281b36d3589a393e22002b8ee57b0f42c79|",
"module": "mesh-delivery-gate",
"fingerprint": "src2:8dec18c3c71e1766b5c8700b79e18281b36d3589a393e22002b8ee57b0f42c79"
},
"mesh-host|src2:57054aefce091d97cb871a00140b27c0ba02b4dbf0a7682b39db6daab0b6b6e9|": {
"key": "mesh-host|src2:57054aefce091d97cb871a00140b27c0ba02b4dbf0a7682b39db6daab0b6b6e9|",
"module": "mesh-host",
"fingerprint": "src2:57054aefce091d97cb871a00140b27c0ba02b4dbf0a7682b39db6daab0b6b6e9"
}
},
"outcomes": {
"|||take-in": {
"key": "|||take-in",
"module": "",
"step": "take-in",
"outcome": "taken-in",
"why": "the wait names indexer build src2:e907f553, which cannot run before this take-in (its own delivery needs it); the indexer program running on novox since 08:51 is pack41, built from mesh-delivery main eed0833a, mesh-catalog 9ade421e and mesh-contracts ba11b5e9. The operator approved moving these merges (02:14). lead-47@shanks",
"at": "2026-11-17T07:56:07.38004265Z"
}
}
}
}
]
}

<!-- mesh-delivery:view --> { "records": [ { "instance": "record/main_992_5ae6ed5f/10f7fc04dd689cbf", "sequence": 9627, "bytes": 1829, "of-bytes": 262144, "waits": "its difference is not known yet", "record": { "milestone": "main.992", "heads": { "novox/mesh-delivery@238": "eed0833a29f81c39d515dbd0f4cee51c858d2f95" }, "opened": "2026-11-17T07:56:07.380818211Z", "form": 1, "group": { "group": "", "members": [ "novox/mesh-catalog@697", "novox/mesh-delivery@238", "novox/mesh-host@233" ], "pulls": [ { "repository": "novox/mesh-delivery", "number": 238, "head": "eed0833a29f81c39d515dbd0f4cee51c858d2f95", "state": "merged", "commit": "eed0833a29f81c39d515dbd0f4cee51c858d2f95" } ] }, "entries": { "mesh-delivery-assigner|src2:c723d3d756e23a1d76ff0e1ea6c2a64632217d0e488933db4769df392f369dfd|": { "key": "mesh-delivery-assigner|src2:c723d3d756e23a1d76ff0e1ea6c2a64632217d0e488933db4769df392f369dfd|", "module": "mesh-delivery-assigner", "fingerprint": "src2:c723d3d756e23a1d76ff0e1ea6c2a64632217d0e488933db4769df392f369dfd" }, "mesh-delivery-gate|src2:8dec18c3c71e1766b5c8700b79e18281b36d3589a393e22002b8ee57b0f42c79|": { "key": "mesh-delivery-gate|src2:8dec18c3c71e1766b5c8700b79e18281b36d3589a393e22002b8ee57b0f42c79|", "module": "mesh-delivery-gate", "fingerprint": "src2:8dec18c3c71e1766b5c8700b79e18281b36d3589a393e22002b8ee57b0f42c79" }, "mesh-host|src2:57054aefce091d97cb871a00140b27c0ba02b4dbf0a7682b39db6daab0b6b6e9|": { "key": "mesh-host|src2:57054aefce091d97cb871a00140b27c0ba02b4dbf0a7682b39db6daab0b6b6e9|", "module": "mesh-host", "fingerprint": "src2:57054aefce091d97cb871a00140b27c0ba02b4dbf0a7682b39db6daab0b6b6e9" } }, "outcomes": { "|||take-in": { "key": "|||take-in", "module": "", "step": "take-in", "outcome": "taken-in", "why": "the wait names indexer build src2:e907f553, which cannot run before this take-in (its own delivery needs it); the indexer program running on novox since 08:51 is pack41, built from mesh-delivery main eed0833a, mesh-catalog 9ade421e and mesh-contracts ba11b5e9. The operator approved moving these merges (02:14). lead-47@shanks", "at": "2026-11-17T07:56:07.38004265Z" } } } } ] } <!-- mesh-act:view.record/main_992_5ae6ed5f/10f7fc04dd689cbf.novox/mesh-delivery#238@1794902171007590833.43d6f8 -->
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-delivery#238