takein: the test's pending revision names a lost merge (TestTakeInEvents fails on main since A-476 b) #253

Merged
mesh-tools merged 1 commits from fix/takein-test-sample into main 2026-11-19 11:51:18 +00:00
Member

TestTakeInEvents fails on main e952ab72 (seen in pipeline main.1025.mesh-delivery-indexer, unit and integration): A-476 (b) stopped counting WaitsFor as a reason a pending revision holds, but the test's first sample and one refusal case named only that. Test-only: the sample names a lost merge, and the refusal case removes Lost. go test and go vet (both tags) pass in takein.

Quick vs thorough: one place; no other test names WaitsFor as the hold's only reason. Merged directly in recovery mode, no review round (a two-line test change).

https://claude.ai/code/session_01JG73KHUnBze48rdua8u2sy

TestTakeInEvents fails on main e952ab72 (seen in pipeline main.1025.mesh-delivery-indexer, unit and integration): A-476 (b) stopped counting `WaitsFor` as a reason a pending revision holds, but the test's first sample and one refusal case named only that. Test-only: the sample names a lost merge, and the refusal case removes `Lost`. `go test` and `go vet` (both tags) pass in `takein`. Quick vs thorough: one place; no other test names WaitsFor as the hold's only reason. Merged directly in recovery mode, no review round (a two-line test change). https://claude.ai/code/session_01JG73KHUnBze48rdua8u2sy
mesh-tools added 1 commit 2026-11-19 11:51:01 +00:00
TestTakeInEvents failed on main since A-476 (b) dropped WaitsFor as a reason a pending revision holds; its sample and one
refusal case still named only that. Seen in main.1025.mesh-delivery-indexer, unit and integration.

Claude-Session: https://claude.ai/code/session_01JG73KHUnBze48rdua8u2sy
mesh-tools merged commit 233824eeeb into main 2026-11-19 11:51:18 +00:00
mesh-tools deleted branch fix/takein-test-sample 2026-11-19 11:51:18 +00:00
Author
Member

{
"records": [
{
"instance": "record/main_1026_8b4d6c85/468e87645146aebd",
"sequence": 10189,
"bytes": 871,
"of-bytes": 262144,
"waits": "its difference is not known yet",
"record": {
"milestone": "main.1026",
"heads": {
"novox/mesh-delivery@253": "233824eeebaf4b47fd82882cd2380eb8ae7d0606"
},
"opened": "2026-11-19T11:51:56.318824045Z",
"form": 1,
"group": {
"group": "",
"members": [
"novox/mesh-delivery@253"
],
"pulls": [
{
"repository": "novox/mesh-delivery",
"number": 253,
"head": "233824eeebaf4b47fd82882cd2380eb8ae7d0606",
"state": "merged",
"commit": "233824eeebaf4b47fd82882cd2380eb8ae7d0606",
"base": "main"
}
]
},
"entries": {
"mesh-delivery-indexer|src2:bf397163adea9a09c03877937f013af9ae582ed345a2baf53c99e438a49c5d3e|": {
"key": "mesh-delivery-indexer|src2:bf397163adea9a09c03877937f013af9ae582ed345a2baf53c99e438a49c5d3e|",
"module": "mesh-delivery-indexer",
"fingerprint": "src2:bf397163adea9a09c03877937f013af9ae582ed345a2baf53c99e438a49c5d3e"
}
},
"outcomes": {
"|||take-in": {
"key": "|||take-in",
"module": "",
"step": "take-in",
"outcome": "taken-in",
"at": "2026-11-19T11:51:56.318042704Z"
}
}
}
}
]
}

<!-- mesh-delivery:view --> { "records": [ { "instance": "record/main_1026_8b4d6c85/468e87645146aebd", "sequence": 10189, "bytes": 871, "of-bytes": 262144, "waits": "its difference is not known yet", "record": { "milestone": "main.1026", "heads": { "novox/mesh-delivery@253": "233824eeebaf4b47fd82882cd2380eb8ae7d0606" }, "opened": "2026-11-19T11:51:56.318824045Z", "form": 1, "group": { "group": "", "members": [ "novox/mesh-delivery@253" ], "pulls": [ { "repository": "novox/mesh-delivery", "number": 253, "head": "233824eeebaf4b47fd82882cd2380eb8ae7d0606", "state": "merged", "commit": "233824eeebaf4b47fd82882cd2380eb8ae7d0606", "base": "main" } ] }, "entries": { "mesh-delivery-indexer|src2:bf397163adea9a09c03877937f013af9ae582ed345a2baf53c99e438a49c5d3e|": { "key": "mesh-delivery-indexer|src2:bf397163adea9a09c03877937f013af9ae582ed345a2baf53c99e438a49c5d3e|", "module": "mesh-delivery-indexer", "fingerprint": "src2:bf397163adea9a09c03877937f013af9ae582ed345a2baf53c99e438a49c5d3e" } }, "outcomes": { "|||take-in": { "key": "|||take-in", "module": "", "step": "take-in", "outcome": "taken-in", "at": "2026-11-19T11:51:56.318042704Z" } } } } ] } <!-- mesh-act:view.record/main_1026_8b4d6c85/468e87645146aebd.novox/mesh-delivery#253@1795089122317524774.61cac44 -->
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-delivery#253