Indexer: write a module's value only when its fingerprint changes, so a catalogue merge no longer floods the take-in (issue 1945) #48

Merged

mesh-tools merged 4 commits from fix/indexer-writes-on-change into main 2026-10-25 20:35:24 +00:00

Conversation 1 Commits 4 Files Changed 23

+451 -53

4 Commits

Author	SHA1	Message	Date
jschoubben	ac82187b85	Indexer integration test: a disagreement keeps a computed fingerprint, as issue 1940's fix decided ... The test predates the fix that keeps a held fingerprint while builders disagree (#47, 3e7f852) and still asserted the blanking that fix removed, so it fails on main 4efe6cf as well. It now asserts the fingerprint is kept after n2's assignment, and that a merge moving avahi during the disagreement gets none until the builders agree.	2026-10-25 21:28:03 +01:00
jschoubben	8d38c6bac9	Write the source revision a candidate was previewed onto, so the builder merges its preview onto that trunk head ... Candidate.Base was never written non-zero (review round 2): the builder's base lookup would have found no trunk for any live candidate and built no preview at all. The indexer now writes, whenever it writes a candidate's fingerprints, the gate's source revision whose trunk heads it read the previews onto; that head of the pull request's repository is the preview's trunk. No mesh-sdk change: the field and its meaning were there. The builder's test now takes the candidate the indexer's own test writes (testdata/candidate-written.json, kept equal to it), not a hand-made one.	2026-10-25 21:16:20 +01:00
jschoubben	9afef800c0	Merge a candidate's preview onto the trunk head it was previewed onto, not the module value's commit ... The builder took a candidate build's merge base from the module's value commit. Now that a value keeps the commit its fingerprint first appeared at, that commit can be many merges behind the trunk, so a preview would be built onto a stale trunk (review round 1). The base is now the head of the pull request's repository in the gate's source revision the candidate names (Candidate.Base): the builder reads mesh-delivery-gate.source, watched with its history (a direct get of one revision is not what a read grants), and a candidate heard before its revision is built once the revision is heard.	2026-10-25 21:13:59 +01:00
jschoubben	eaf27f36af	Write a module's value only when the module changed, so a merge no longer rewrites every module of its repository ... The operator, 2026-10-25: only if a module has a new version in commit x is a new value written naming commit x. A merge wrote every module of the repository at the new commit, fingerprint unchanged (about 186 keys per mesh-catalog merge), and the controller's take-in took each in again: twice tonight it flooded. Now a merge that gives a module the value it holds but for the commit writes nothing, and the value keeps the commit its fingerprint first appeared at. The kind: a write that differs only in where it was computed. The other instance, a source revision re-stamping Src on every module at its repository's head after any merge anywhere, now stamps Src once. The trunk head stays the gate's source.main.	2026-10-25 21:13:59 +01:00