Assigner: take a stale ask away only once its held condition's clear was said, so a failed clear is retried (issue 1906) #61

2026-10-26T10:08:23Z

mesh-tools commented

2026-10-26 10:08:23 +00:00

Issue 1906 note 29, the leftover of #60's review: staleAsks removed a stale hold or restore ask and then cleared its held condition; when that clear failed at the router, the ask was already gone, so no pass reached that fingerprint again and its condition stayed raised until a restart.

Now clearHeld says whether the clear was said (now, before, or no router), and staleAsks clears first and removes the ask only when it was; a failed clear leaves the ask in the bucket, which is the retry: the next pass clears and removes it. No new state.

Test: a subtest of TestAsksOfAFingerprintTheTrunkLeftBehindAreTakenAway (a say that fails once, then the next pass clears and removes); fails on main. Try try-1793008995438723400 passed (2m46s).

Reviewed-by: review-asks@shanks at 366bc750da

Issue 1906 note 29, the leftover of #60's review: staleAsks removed a stale hold or restore ask and then cleared its held condition; when that clear failed at the router, the ask was already gone, so no pass reached that fingerprint again and its condition stayed raised until a restart. Now clearHeld says whether the clear was said (now, before, or no router), and staleAsks clears first and removes the ask only when it was; a failed clear leaves the ask in the bucket, which is the retry: the next pass clears and removes it. No new state. Test: a subtest of TestAsksOfAFingerprintTheTrunkLeftBehindAreTakenAway (a say that fails once, then the next pass clears and removes); fails on main. Try try-1793008995438723400 passed (2m46s). Reviewed-by: review-asks@shanks at 366bc750da8730c5268adbedc5311d47c402ff03

mesh-tools added 1 commit 2026-10-26 10:08:23 +00:00

Assigner: clear a stale hold's condition before taking its ask away, so a failed clear is retried at the next pass (issue 1906)

mesh/delivery merged: source.main moved to novox/mesh-delivery@ed1125b66d91

Details

mesh/check pass 366bc750da87 on ed1125b66d91 | unit 168 run, 489 kept | integration 21 run, 712 kept | composition passed on ace

366bc750da

mesh-tools commented

2026-10-26 10:08:27 +00:00

Delivery novox/mesh-delivery@366bc750da87 — merged since 2026-10-26T10:09:43Z

Source — source.main moved to novox/mesh-delivery@ed1125b66d. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

2026-10-26 10:08 (new) → proposed (announced): novox/mesh-delivery#61's head announced
2026-10-26 10:08 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-10-26 10:09 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-delivery@366bc750da87` — **merged** since 2026-10-26T10:09:43Z **Source** — source.main moved to novox/mesh-delivery@ed1125b66d91. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-10-26 10:08 (new) → proposed (announced): novox/mesh-delivery#61's head announced - 2026-10-26 10:08 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-26 10:09 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit ed1125b66d into main

2026-10-26 10:09:42 +00:00

mesh-tools deleted branch fix/1906-clear-retried

2026-10-26 10:09:42 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-delivery#61