novox/mesh-delivery
19
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Checker: keep no package whose tests skipped, so a skipped pass is never reused as proof (issue 890) #64

Merged
mesh-tools merged 2 commits from fix/checker-skips-not-kept into main 2026-10-26 12:01:20 +00:00
Conversation 1 Commits 2 Files Changed 3
+40 -2
mesh-tools commented 2026-10-26 11:44:28 +00:00
Member
Copy Link
Copy Source

Group fix/checker-skips-not-kept with mesh-catalog, one Approve. Issue 890 (note 18). KeepPasses (internal/check/kept.go) withholds a package with Skipped > 0 and keeps the rest of its result; with an older build module that sends no per-package count, a result with any skip keeps nothing (safe fallback). Tests: TestOnlyTheSkippingPackageOfAResultIsWithheld, TestAResultWithSkippedTestsKeepsNothing (fails on main). Try try-1793014166428516943 passed. Reviewed in two rounds (round 1 withheld whole level asks, which would have emptied mesh-catalog's kept verdicts). Placement of mesh-build-node's integration level on a node holding node-build-node stays open on issue 890.

Reviewed-by: review-nodetc@shanks at e1f1b5d18b

Group fix/checker-skips-not-kept with mesh-catalog, one Approve. Issue 890 (note 18). KeepPasses (internal/check/kept.go) withholds a package with Skipped > 0 and keeps the rest of its result; with an older build module that sends no per-package count, a result with any skip keeps nothing (safe fallback). Tests: TestOnlyTheSkippingPackageOfAResultIsWithheld, TestAResultWithSkippedTestsKeepsNothing (fails on main). Try try-1793014166428516943 passed. Reviewed in two rounds (round 1 withheld whole level asks, which would have emptied mesh-catalog's kept verdicts). Placement of mesh-build-node's integration level on a node holding node-build-node stays open on issue 890. Reviewed-by: review-nodetc@shanks at e1f1b5d18bf0fe4ea5b3d04fdb225c6ee9eb59c4
mesh-tools added 2 commits 2026-10-26 11:44:28 +00:00
Checker: a result with skipped tests keeps no verdict, so a skipped pass is run again (issue 890) f0fe454145
Checker: a package with skipped tests is withheld from the kept verdicts, not the whole result (issue 890)
mesh/delivery merged: source.main moved to novox/mesh-delivery@4861d1f78d28
Details
mesh/delivery-group group fix/checker-skips-not-kept merged: every member is merged
Details
mesh/check failed: ace: the check of novox/mesh-catalog#492 refused: the installed go version could not be read: `go version` with GOTOOLCHAIN=local f…
e1f1b5d18b
mesh-tools commented 2026-10-26 11:44:32 +00:00
Author
Member
Copy Link
Copy Source

Delivery novox/mesh-delivery@e1f1b5d18bf0 — merged since 2026-10-26T12:01:24Z

Source — source.main moved to novox/mesh-delivery@4861d1f78d. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/checker-skips-not-kept: novox/mesh-catalog@ea53b2f920, novox/mesh-delivery@e1f1b5d18b

Transitions

  • 2026-10-26 11:44 (new) → proposed (announced): novox/mesh-delivery#64's head announced
  • 2026-10-26 11:44 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-10-26 12:01 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-delivery@e1f1b5d18bf0` — **merged** since 2026-10-26T12:01:24Z **Source** — source.main moved to novox/mesh-delivery@4861d1f78d28. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/checker-skips-not-kept`: novox/mesh-catalog@ea53b2f920b5, novox/mesh-delivery@e1f1b5d18bf0 **Transitions** - 2026-10-26 11:44 (new) → proposed (announced): novox/mesh-delivery#64's head announced - 2026-10-26 11:44 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-26 12:01 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
mesh-tools merged commit 4861d1f78d into main 2026-10-26 12:01:20 +00:00
mesh-tools deleted branch fix/checker-skips-not-kept 2026-10-26 12:01:20 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-delivery#64