checker_status reads the node-engine at its running commit, as the checker decides (issue 568) #68

Merged
mesh-tools merged 1 commits from fix/status-and-holds into main 2026-10-26 12:39:56 +00:00
Member

Issue 568 (a merge check's verdict and what the status tool says about it).

checker_status listed every candidate as waiting for a trunk move, because it compared the beside repositories against their trunk heads while the checker's own stale() compares them against the commit each module runs. Status() (internal/check/read.go) now uses besideMoved(v.Beside, besideAt(heads, runs)) like stale() (internal/check/checker.go), reading the running commit from the indexer's modules state (already in module.json reads). besideAt copies the heads map instead of changing it in place.

Tests: a 3-row table; row 1 fails on main. go test ./... and go vet -tags integration ./... clean in modules/mesh-delivery-checker.

Rule bent (rules-are-weighed): no try before this pull request: tries strand today when the bus reloads (issue 734, fix in progress), and the change is a read-only tool's answer; the merge check is the gate.

Reviewed-by: review-smalls@shanks at a7e51b416b

Issue 568 (a merge check's verdict and what the status tool says about it). `checker_status` listed every candidate as waiting for a trunk move, because it compared the beside repositories against their trunk heads while the checker's own `stale()` compares them against the commit each module runs. `Status()` (internal/check/read.go) now uses `besideMoved(v.Beside, besideAt(heads, runs))` like `stale()` (internal/check/checker.go), reading the running commit from the indexer's modules state (already in module.json reads). `besideAt` copies the heads map instead of changing it in place. Tests: a 3-row table; row 1 fails on main. `go test ./...` and `go vet -tags integration ./...` clean in modules/mesh-delivery-checker. Rule bent (rules-are-weighed): no try before this pull request: tries strand today when the bus reloads (issue 734, fix in progress), and the change is a read-only tool's answer; the merge check is the gate. Reviewed-by: review-smalls@shanks at a7e51b416bc1aea0286fae168b70787b589916f9
mesh-tools added 1 commit 2026-10-26 12:38:55 +00:00
checker_status reads the node-engine at its running commit, as the checker's decision does, so it stops listing every candidate as waiting for a trunk move (issue 568)
mesh/delivery merged: source.main moved to novox/mesh-delivery@ecf532af0e85
mesh/check being carried to a7e51b416bc1 on ecf532af0e85 | from 71f786f14662
a7e51b416b
Author
Member

Delivery novox/mesh-delivery@a7e51b416bc1 — merged since 2026-10-26T12:39:59Z

Source — source.main moved to novox/mesh-delivery@ecf532af0e. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

  • 2026-10-26 12:38 (new) → proposed (announced): novox/mesh-delivery#68's head announced
  • 2026-10-26 12:38 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-10-26 12:39 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-delivery@a7e51b416bc1` — **merged** since 2026-10-26T12:39:59Z **Source** — source.main moved to novox/mesh-delivery@ecf532af0e85. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-10-26 12:38 (new) → proposed (announced): novox/mesh-delivery#68's head announced - 2026-10-26 12:38 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-26 12:39 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
mesh-tools merged commit ecf532af0e into main 2026-10-26 12:39:56 +00:00
mesh-tools deleted branch fix/status-and-holds 2026-10-26 12:39:56 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-delivery#68