The view's tools read their own reach by its bare name, and a test holds every state the commands read to what is issued (issue 1280) #82

2026-10-26T22:30:37Z

mesh-tools commented

2026-10-26 22:30:37 +00:00

Issue 1280 (note 13).

What failed. A try of main (try-1793053182282558521, 2026-10-26 22:22 UTC) failed at lint: modules/mesh-delivery-view/cmd/mesh-delivery-view-tools/main.go not as gofmt writes it. The same line makes view_reach fail on the machines: it reads stdio.State("mesh-delivery-view.reach"), a name the mesh never issued; the module's own state is issued as bare reach (module.json state), as the SDK's State takes an own state by its local name.

Change. The tools read stdio.State("reach"), gofmt'd. manifest_test.go gains TestEveryStateTheCommandsReadIsIssued: every literal stdio.State name under cmd/ must be an own state or listed in reads. It fails on the old line and passes now.

Quick or thorough. Quick: the name. Thorough for this module: the test. The same guard for every module (in mesh-sdk or each manifest test) is a note for issue 1280, not this change.

Checked locally. gofmt -l clean; go vet ./... and go vet -tags integration ./... clean; the module's 5 unit packages pass.

The writer (putReach, delivery.ReachBucket = mesh-delivery-view_reach) is unchanged and writes the bucket now read.

Reviewed-by: review-tries@shanks at efadc691e7

Issue 1280 (note 13). **What failed.** A try of main (try-1793053182282558521, 2026-10-26 22:22 UTC) failed at lint: `modules/mesh-delivery-view/cmd/mesh-delivery-view-tools/main.go` not as gofmt writes it. The same line makes `view_reach` fail on the machines: it reads `stdio.State("mesh-delivery-view.reach")`, a name the mesh never issued; the module's own state is issued as bare `reach` (module.json `state`), as the SDK's `State` takes an own state by its local name. **Change.** The tools read `stdio.State("reach")`, gofmt'd. `manifest_test.go` gains `TestEveryStateTheCommandsReadIsIssued`: every literal `stdio.State` name under `cmd/` must be an own state or listed in `reads`. It fails on the old line and passes now. **Quick or thorough.** Quick: the name. Thorough for this module: the test. The same guard for every module (in mesh-sdk or each manifest test) is a note for issue 1280, not this change. **Checked locally.** gofmt -l clean; go vet ./... and go vet -tags integration ./... clean; the module's 5 unit packages pass. The writer (`putReach`, `delivery.ReachBucket` = `mesh-delivery-view_reach`) is unchanged and writes the bucket now read. Reviewed-by: review-tries@shanks at efadc691e7ead4e0fc2eca6a1ce655217072ed14

mesh-tools added 1 commit 2026-10-26 22:30:37 +00:00

The view's tools read their own reach by its bare name, as the mesh issues it, and a test holds every state the commands read to what is issued (issue 1280)

mesh/check being carried to efadc691e7ea on 475bb4bb0b8f | from 4af36c69a761

mesh/delivery merged: source.main moved to novox/mesh-delivery@475bb4bb0b8f

Details

efadc691e7

view_reach asked for mesh-delivery-view.reach, a name the mesh never issued, so it failed on the machines;
the same line was not gofmt'd, which failed the try of main. Quick fix: the name. Thorough for this module: the
manifest test now refuses any stdio.State literal in cmd/ that is neither an own state nor listed in reads.

mesh-tools commented

2026-10-26 22:30:41 +00:00

Delivery novox/mesh-delivery@efadc691e7ea — merged since 2026-10-26T22:48:26Z

Source — source.main moved to novox/mesh-delivery@475bb4bb0b. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

2026-10-26 22:30 (new) → proposed (announced): novox/mesh-delivery#82's head announced
2026-10-26 22:30 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-10-26 22:48 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-delivery@efadc691e7ea` — **merged** since 2026-10-26T22:48:26Z **Source** — source.main moved to novox/mesh-delivery@475bb4bb0b8f. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-10-26 22:30 (new) → proposed (announced): novox/mesh-delivery#82's head announced - 2026-10-26 22:30 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-26 22:48 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit 475bb4bb0b into main

2026-10-26 22:48:25 +00:00

mesh-tools deleted branch fix/1280-view-reads-its-reach

2026-10-26 22:48:25 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-delivery#82