novox/mesh-delivery
19
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

The checker's failure is the build step's failure, and a verdict that hides its failing test is refused (issue 1901) #84

Merged
mesh-tools merged 4 commits from fix/1901-failure-contract into main 2026-10-26 23:44:21 +00:00
Conversation 1 Commits 4 Files Changed 6
+92 -25
mesh-tools commented 2026-10-26 23:43:25 +00:00
Member
Copy Link
Copy Source

Issue 1901, group fix/1901-failure-contract (mesh-sdk merges first). modules/mesh-delivery-checker: results.go makes Failure the same type as mesh-sdk's buildstep.Failure (with By), and a failed step with no named failure is guarded loudly. Pins mesh-sdk v0.1.14-0.20261026233910-a2759ec92ec9.

Merged with today's main: only the checker's go.mod/go.sum conflicted (main's taken, then repinned). Tests: the untagged unit suite of all nine modules passes; go vet -tags integration clean; no test added (589 unit / 76 integration, as main).

Reviewed-by: review-1901k@shanks at c716670be0 (the contract)
Reviewed-by: review-1901m@shanks at f4a86f5884 (the merge with main)

Issue 1901, group fix/1901-failure-contract (mesh-sdk merges first). modules/mesh-delivery-checker: results.go makes Failure the same type as mesh-sdk's buildstep.Failure (with By), and a failed step with no named failure is guarded loudly. Pins mesh-sdk v0.1.14-0.20261026233910-a2759ec92ec9. Merged with today's main: only the checker's go.mod/go.sum conflicted (main's taken, then repinned). Tests: the untagged unit suite of all nine modules passes; go vet -tags integration clean; no test added (589 unit / 76 integration, as main). Reviewed-by: review-1901k@shanks at c716670be095671dea02e6ffd4c0521e5e18b9e7 (the contract) Reviewed-by: review-1901m@shanks at f4a86f58843dcaff48168b8e4baa87ac36e3c2f0 (the merge with main)
mesh-tools added 4 commits 2026-10-26 23:43:25 +00:00
The checker says loudly when a build module hid a failure's cause (issue 1901) 9427dac823 
A failed test with no cause, or a passing line as its cause, was worded as if it were the failure: a try of mesh-catalog
failed with a passing '✔' line of the first test file. Under mesh-sdk's failure contract the verdict's words and its
status line now start with 'the build module hid the failure (<module> at <version>)', and the check still fails.
Pin mesh-sdk's fix/1901-failure-contract head 81ec7bd7 (issue 1901) 17ed06ee4d
The checker pins the SDK of review round 1, and its hid-the-failure cases join the older build module's test (issue 1901) c716670be0
Merge main into fix/1901-failure-contract: the checker pins mesh-sdk a2759ec, the group's sdk head (issue 1901)
mesh/delivery merged: source.main moved to novox/mesh-delivery@cacf537004c9
Details
mesh/delivery-group group fix/1901-failure-contract merged: every member is merged
Details
mesh/check checking f4a86f58843d on cacf537004c9 | novox/mesh-delivery#84 in group fix/1901-failure-contract
f4a86f5884
mesh-tools commented 2026-10-26 23:43:28 +00:00
Author
Member
Copy Link
Copy Source

Delivery novox/mesh-delivery@f4a86f58843d — merged since 2026-10-26T23:44:24Z

Source — source.main moved to novox/mesh-delivery@cacf537004. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/1901-failure-contract: novox/mesh-catalog@e8a953818c, novox/mesh-delivery@f4a86f5884, novox/mesh-sdk@a2759ec92e

Transitions

  • 2026-10-26 23:43 (new) → proposed (announced): novox/mesh-delivery#84's head announced
  • 2026-10-26 23:43 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-10-26 23:44 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-delivery@f4a86f58843d` — **merged** since 2026-10-26T23:44:24Z **Source** — source.main moved to novox/mesh-delivery@cacf537004c9. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/1901-failure-contract`: novox/mesh-catalog@e8a953818c71, novox/mesh-delivery@f4a86f58843d, novox/mesh-sdk@a2759ec92ec9 **Transitions** - 2026-10-26 23:43 (new) → proposed (announced): novox/mesh-delivery#84's head announced - 2026-10-26 23:43 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-26 23:44 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
mesh-tools merged commit cacf537004 into main 2026-10-26 23:44:21 +00:00
mesh-tools deleted branch fix/1901-failure-contract 2026-10-26 23:44:22 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-delivery#84