mesh-grants: stop rewriting the shadow user list every 3 s when nothing changed (issue 1126, group fix/1126-switch-safe) #91

2026-10-27T23:43:16Z

mesh-tools commented

2026-10-27 23:43:16 +00:00

Delivery group fix/1126-switch-safe with mesh-sdk and mesh-host; mesh-grants pins mesh-sdk 7359d18.

Since the take-over mesh-grants rewrote its sealed list key every ~3 s (revision 99270 to 99357 in 90 s, nothing differing): the key reads back an empty left-out list as [] where a pass composes nil, and the bus node's load report's revision and time fed the next pass. Now empty and nil compare equal, and the load report's revision/time are no longer inputs. A real change (a different list or key) is still written.

Tests: TestGrants rows over three steady passes (failed before). No new test functions.

Review: round 1 found nothing in mesh-delivery; round 2 APPROVED.

Reviewed-by: review-switch@shanks at 663c9cbc34

Delivery group fix/1126-switch-safe with mesh-sdk and mesh-host; mesh-grants pins mesh-sdk 7359d18. Since the take-over mesh-grants rewrote its sealed list key every ~3 s (revision 99270 to 99357 in 90 s, nothing differing): the key reads back an empty left-out list as [] where a pass composes nil, and the bus node's load report's revision and time fed the next pass. Now empty and nil compare equal, and the load report's revision/time are no longer inputs. A real change (a different list or key) is still written. Tests: TestGrants rows over three steady passes (failed before). No new test functions. Review: round 1 found nothing in mesh-delivery; round 2 APPROVED. Reviewed-by: review-switch@shanks at 663c9cbc348db153ef40ab9474cc68302b4c8553

mesh-tools added 2 commits 2026-10-27 23:43:16 +00:00

mesh-grants: the same list said again moves neither the sealed key nor the shadow list (issue 1126) 3d916a685e

Live since the take-over the shadow list was written every 3 s (revision 99270
to 99357 in 90 s, nothing differing): the sealed key read back says [] for the
nil left-out a pass composes, so every pass wrote the key again; each write
moved the bus node's report of what it loaded, whose revision and time were
inputs of the shadow list, and woke the next pass. The bus itself reloads only
when the list's bytes change (its log: two configurations alternating with the
placement, f8567865 and 473f9ad3), so this loop was load, not the reload.

mesh-grants: pin mesh-sdk 7359d18, the group's head (issue 1126)

mesh/delivery merged: source.main moved to novox/mesh-delivery@bab2e1391ae5

Details

mesh/delivery-group group fix/1126-switch-safe merged: every member is merged

Details

mesh/check pass 663c9cbc348d on a49fd9cc65f7 | unit 2992 run, 1008 kept, 36 skipped | integration 3025 run, 1102 kept, 29 skipped | over bound: unit (…

663c9cbc34

mesh-tools commented

2026-10-27 23:43:21 +00:00

Delivery novox/mesh-delivery@663c9cbc348d — merged since 2026-10-27T23:52:26Z

Source — source.main moved to novox/mesh-delivery@bab2e1391a. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/1126-switch-safe: novox/mesh-delivery@663c9cbc34, novox/mesh-host@a6e53a4858, novox/mesh-sdk@7359d187db

composed together: pass — the checker's verdict at the members' heads (e69dbbe0ea51)

Transitions

2026-10-27 23:43 (new) → proposed (announced): novox/mesh-delivery#91's head announced
2026-10-27 23:43 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-10-27 23:52 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-delivery@663c9cbc348d` — **merged** since 2026-10-27T23:52:26Z **Source** — source.main moved to novox/mesh-delivery@bab2e1391ae5. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/1126-switch-safe`: novox/mesh-delivery@663c9cbc348d, novox/mesh-host@a6e53a485813, novox/mesh-sdk@7359d187db8d - composed together: pass — the checker's verdict at the members' heads (e69dbbe0ea51) **Transitions** - 2026-10-27 23:43 (new) → proposed (announced): novox/mesh-delivery#91's head announced - 2026-10-27 23:43 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-27 23:52 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit bab2e1391a into main

2026-10-27 23:52:23 +00:00

mesh-tools deleted branch fix/1126-switch-safe

2026-10-27 23:52:25 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-delivery#91