mesh-delivery-view passes a node's placement answer through as written, so its bodies reach readers (issue 1126, group fix/1126-shadow-bodies) #92

Merged

mesh-tools merged 2 commits from fix/1126-shadow-bodies into main 2026-10-28 07:46:28 +00:00

Conversation 2 Commits 2 Files Changed 4

+50 -21

mesh-tools commented 2026-10-28 00:45:45 +00:00

Member

Copy Link

Copy Source

Delivery group fix/1126-shadow-bodies with mesh-sdk and mesh-host; mesh-delivery-view pins mesh-sdk 362a3f1.

Probe #532 showed every difference with digests only: the view decoded each answer with its older mesh-sdk (no Bodies, Note, Returns) and encoded it again. Now it still validates the have (DecodeHaveNode) and parses each candidate, dropping any that do not parse, then passes the raw answer through.

Tests: an answer with a note and an unknown field comes out whole (failed before).

The group's first check failed on gofmt only (read.go, struct field alignment); 289d1e8f formats it (whitespace only, 7 lines, read by the lead; gofmt -l clean in all three repositories). The code is as review-bodies@shanks approved at 968b9bf2e6.

Reviewed-by: lead-47@shanks at 289d1e8fa6

Delivery group fix/1126-shadow-bodies with mesh-sdk and mesh-host; mesh-delivery-view pins mesh-sdk 362a3f1. Probe #532 showed every difference with digests only: the view decoded each answer with its older mesh-sdk (no Bodies, Note, Returns) and encoded it again. Now it still validates the have (DecodeHaveNode) and parses each candidate, dropping any that do not parse, then passes the raw answer through. Tests: an answer with a note and an unknown field comes out whole (failed before). The group's first check failed on gofmt only (read.go, struct field alignment); 289d1e8f formats it (whitespace only, 7 lines, read by the lead; gofmt -l clean in all three repositories). The code is as review-bodies@shanks approved at 968b9bf2e6b1858a34ae9cf7cc3074d790fbb61d. Reviewed-by: lead-47@shanks at 289d1e8fa69ac28e244cf8f9a3439d044101d829

mesh-tools added 1 commit 2026-10-28 00:45:45 +00:00

mesh-delivery-view: a node's candidate answer is shown as the node wrote it; pin mesh-sdk 362a3f1 (issue 1126, probe #532) ... 968b9bf2e6

The bodies of each difference never reached the answer shown: the view decoded
the node's answer with its mesh-sdk, which did not know the field, and encoded
it again. The answer now rides through as stored; a decoded copy only says its
state.

mesh-tools commented 2026-10-28 00:45:48 +00:00

Author

Member

Copy Link

Copy Source

Delivery novox/mesh-delivery@289d1e8fa69a — merged since 2026-10-28T07:46:32Z

Source — source.main moved to novox/mesh-delivery@4d4743d900. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/1126-shadow-bodies: novox/mesh-delivery@289d1e8fa6, novox/mesh-host@82d0e125b2, novox/mesh-sdk@362a3f1378

• composed together: pass — the checker's verdict at the members' heads (409daa55f579)

Transitions

• 2026-10-28 00:49 (new) → proposed (announced): novox/mesh-delivery#92's head announced
• 2026-10-28 00:50 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
• 2026-10-28 07:46 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-delivery@289d1e8fa69a` — **merged** since 2026-10-28T07:46:32Z **Source** — source.main moved to novox/mesh-delivery@4d4743d90065. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/1126-shadow-bodies`: novox/mesh-delivery@289d1e8fa69a, novox/mesh-host@82d0e125b2c0, novox/mesh-sdk@362a3f1378aa - composed together: pass — the checker's verdict at the members' heads (409daa55f579) **Transitions** - 2026-10-28 00:49 (new) → proposed (announced): novox/mesh-delivery#92's head announced - 2026-10-28 00:50 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-28 07:46 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

jschoubben added 1 commit 2026-10-28 00:49:56 +00:00

Format mesh-delivery-view's read.go as gofmt writes it (issue 1126, the group check's failure) 289d1e8fa6

mesh-tools commented 2026-10-28 00:50:01 +00:00

Author

Member

Copy Link

Copy Source

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-tools merged commit 4d4743d900 into main 2026-10-28 07:46:28 +00:00

mesh-tools deleted branch fix/1126-shadow-bodies 2026-10-28 07:46:29 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-delivery#92