The placement test's resolved values carry their source, as mesh-config writes them (issue 1126) #159

2026-10-28T09:50:05Z

mesh-tools commented

2026-10-28 09:50:05 +00:00

The group fix/1126-seed-same was merged on the operator's Approve although its check failed (check-gates-merge false) on one integration test: TestNatsANodeThePlacementNamesComposesAndAppliesItsOwn ("nothing sets domain"). The code is right and the fixture was wrong: the test wrote values to mesh-config_resolved with no source, which mesh-config never writes (every resolved value carries default, mesh, node, module or unset), and both the controller (config_read.go laidSources = mesh, node, module) and a node composing its own (catalogue.LaidValue, C2) lay no value without a laid source.

The fix gives the five fixture values "source":"module". Test-only: no module behaviour changes.

Quick vs thorough: quick, and no thorough fix is needed: laying a value with no source would make the node and the controller differ again, which C2 removed. No other mesh-host test writes a value without a source.
Checked locally against an embedded bus: the test fails without the fix with the check's two lines and passes with it (21.8 s); go test -tags integration ./... in all of mesh-host passes.

Reviewed-by: rev-seed-same-2@shanks at 6502ba6ad6

The group fix/1126-seed-same was merged on the operator's Approve although its check failed (check-gates-merge false) on one integration test: TestNatsANodeThePlacementNamesComposesAndAppliesItsOwn ("nothing sets domain"). The code is right and the fixture was wrong: the test wrote values to mesh-config_resolved with no source, which mesh-config never writes (every resolved value carries default, mesh, node, module or unset), and both the controller (config_read.go laidSources = mesh, node, module) and a node composing its own (catalogue.LaidValue, C2) lay no value without a laid source. The fix gives the five fixture values `"source":"module"`. Test-only: no module behaviour changes. Quick vs thorough: quick, and no thorough fix is needed: laying a value with no source would make the node and the controller differ again, which C2 removed. No other mesh-host test writes a value without a source. Checked locally against an embedded bus: the test fails without the fix with the check's two lines and passes with it (21.8 s); `go test -tags integration ./...` in all of mesh-host passes. Reviewed-by: rev-seed-same-2@shanks at 6502ba6ad6e695a427eb841e2e04b13170b256f8

mesh-tools added 1 commit 2026-10-28 09:50:05 +00:00

The placement test's resolved values carry their source, as mesh-config writes them: a value with no source is laid by neither the controller nor a node composing its own (issue 1126, C2; the group check of 3cb7f74b347d)

mesh/delivery merged: source.main moved to novox/mesh-host@c3a2ffde6755

Details

mesh/check being carried to 6502ba6ad6e6 on c3a2ffde6755 | from f6c0520f26b9

6502ba6ad6

mesh-tools commented

2026-10-28 09:50:10 +00:00

Delivery novox/mesh-host@6502ba6ad6e6 — merged since 2026-10-28T10:08:47Z

Source — source.main moved to novox/mesh-host@c3a2ffde67. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

2026-10-28 09:50 (new) → proposed (announced): novox/mesh-host#159's head announced
2026-10-28 09:50 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-10-28 10:08 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-host@6502ba6ad6e6` — **merged** since 2026-10-28T10:08:47Z **Source** — source.main moved to novox/mesh-host@c3a2ffde6755. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-10-28 09:50 (new) → proposed (announced): novox/mesh-host#159's head announced - 2026-10-28 09:50 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-28 10:08 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit c3a2ffde67 into main

2026-10-28 10:08:46 +00:00

mesh-tools deleted branch fix/1126-seed-same-2

2026-10-28 10:08:46 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-host#159