Node agent: say what it holds today in its answer, so a seed holding the same is the same (issue 1126) #169

Merged
mesh-tools merged 3 commits from fix/1126-seed-held into main 2026-10-28 22:20:59 +00:00
Member

A module a node holds today, that the seed holds too, counts as the same. L2's seed was refused on novox for de-spiegel, mailu, nftables, postgres, route-proxy and node, all held today.

The fix: the shadow passes what the node holds today into its answer (frombus.Scope.HeldToday): each module whose have's phase is held, and what its own composer's last pass held (node when it could compose none). A hold's start or end answers the proposal again. The answer then names them under Held, and the proposal's brief says "stays held as today". The seed carries its nodes' differences, named in its Approve (the operator, 2026-10-28 22:34 CET), by mesh-sdk 77b48a4, which this pins. One row: a held have counts held today.

Issue 1126, ADR 0567 §3-4

Reviewed-by: rev-l2@shanks at a143678fd8 (re-pinned to the approved 77b48a4)

A module a node holds today, that the seed holds too, counts as the same. L2's seed was refused on novox for de-spiegel, mailu, nftables, postgres, route-proxy and node, all held today. The fix: the shadow passes what the node holds today into its answer (`frombus.Scope.HeldToday`): each module whose have's phase is held, and what its own composer's last pass held (`node` when it could compose none). A hold's start or end answers the proposal again. The answer then names them under `Held`, and the proposal's brief says "stays held as today". The seed carries its nodes' differences, named in its Approve (the operator, 2026-10-28 22:34 CET), by mesh-sdk 77b48a4, which this pins. One row: a held have counts held today. Issue 1126, ADR 0567 §3-4 Reviewed-by: rev-l2@shanks at a143678fd898a885b10a5413db81f2e93f8e81ba (re-pinned to the approved 77b48a4)
mesh-tools added 2 commits 2026-10-28 21:19:43 +00:00
Pin mesh-sdk 06b13ec, the group's head (issue 1126)
mesh/delivery-group group fix/1126-seed-held checking: 2 of 3 member(s) ready
mesh/delivery closed: a newer head of the same pull request
mesh/check checking 9914459830d7 on 4f6b389a37a1 | novox/mesh-host#169 in group fix/1126-seed-held
9914459830
Author
Member

Delivery novox/mesh-host@a143678fd898 — merged since 2026-10-28T22:21:00Z

Source — source.main moved to novox/mesh-host@d2a868f99f. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/1126-seed-held: novox/mesh-delivery@fc3883b0b6, novox/mesh-host@a143678fd8

  • composed together: pass — the checker's verdict at the members' heads (a1af5c9e2de5)

Transitions

  • 2026-10-28 21:41 (new) → proposed (announced): novox/mesh-host#169's head announced
  • 2026-10-28 21:41 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-10-28 22:21 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-host@a143678fd898` — **merged** since 2026-10-28T22:21:00Z **Source** — source.main moved to novox/mesh-host@d2a868f99f05. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/1126-seed-held`: novox/mesh-delivery@fc3883b0b650, novox/mesh-host@a143678fd898 - composed together: pass — the checker's verdict at the members' heads (a1af5c9e2de5) **Transitions** - 2026-10-28 21:41 (new) → proposed (announced): novox/mesh-host#169's head announced - 2026-10-28 21:41 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-28 22:21 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
Author
Member

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.
jschoubben added 1 commit 2026-10-28 21:41:25 +00:00
Pin mesh-sdk 77b48a4, the group's head (issue 1126)
mesh/delivery merged: source.main moved to novox/mesh-host@d2a868f99f05
mesh/delivery-group group fix/1126-seed-held merged: every member is merged
mesh/check pass a143678fd898 on 4f6b389a37a1 | unit 1199 run, 1015 kept, 33 skipped | integration 1218 run, 1081 kept, 26 skipped | over bound: unit (…
a143678fd8
Author
Member

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.
mesh-tools merged commit d2a868f99f into main 2026-10-28 22:20:59 +00:00
mesh-tools deleted branch fix/1126-seed-held 2026-10-28 22:21:00 +00:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-host#169