Keep the kept declaration read while a module runs at an old-form build, so novox and shanks apply their own composition again (issue 774) #182

Merged

mesh-tools merged 3 commits from fix/kept-read-and-foreseen-account into main 2026-10-30 19:49:17 +00:00

Conversation 1 Commits 3 Files Changed 5

+59 -13

3 Commits

Author	SHA1	Message	Date
jschoubben	15361c661f	Pin mesh-sdk 4e9621ed, so a proposal foresees a bus account the Approve will mint and a held module's first reason leads a refusal (issue 774)	2026-10-30 20:34:12 +01:00
jschoubben	cc3f7e8e01	Retire the kept read though mesh-wireguard has no fingerprint, since the node's own composes it from the manifest the mesh provides (issue 774) ... The review of d5e8458 found that mesh-wireguard, provided by the mesh and never wanted at a fingerprint, kept the kept declaration read on every node for ever, against ADR 0550 §2 once the lease is written. A selfcompose row shows the node's own composes it from delivery.ProvidedManifest with nothing running, so the kept read holds nothing of it. Quick fix: name mesh-wireguard in allHave. Thorough fix: allHave counts every module delivery.ProvidedByMesh says the mesh provides as covered. Chose thorough: one list of provided modules, mesh-sdk's.	2026-10-30 20:30:37 +01:00
jschoubben	d5e8458340	Keep reading the kept declaration while a placed module runs at a build of the old form, so the node's own never drops it (issue 774) ... At 19:43:01 on 2026-10-30 shanks' new engine said "the kept declaration is no longer read: each of the 77 modules placed here has a have of its own", and from 19:43:57 every apply of the node's own was refused: it would remove systemd-resolved's resources (novox the same for nats and restic). systemd-resolved's have names only a controller build (build-1791404191702719760), no fingerprint, so the assigner wants it nowhere and it runs folded in the node's own, of which the kept declaration is the one record; retired, the folded module was composed as nothing. Quick fix: never retire the kept declaration. Thorough fix: allHave counts only a have naming a fingerprint of the new form (or removed); a module at a build of the old form keeps the read, named with why, until it has one. Chose thorough: the read retires by itself once every placed module is wanted.	2026-10-30 20:27:12 +01:00