The node-engine takes the indexer's verdict and never ends a read on a refused manifest (ADR 0578 §3) #192

2026-11-01T02:19:52Z

mesh-tools commented

2026-11-01 02:19:52 +00:00

Delivery group feat/judge-once (mesh-sdk, mesh-delivery, mesh-catalog, mesh-host, mesh-controller, mesh-tools), one check, one Approve. Issue 1585. Decisions: ADR 0578 (a manifest is judged once, by the indexer; every other part decodes it and takes the verdict; packages carry contracts only), ADR 0579 (a stricter judge never holds a module already running: it warns), and ADR 0573 §2/§4 built (each build takes the latest published package; a group check builds against the group's package heads).

Quick fix (readers hold a refused module, ~4 h) weighed against the thorough fix (judge once, ~32 h) and the thorough fix chosen with the operator (2026-11-01): the kind (a reader with an old judge silences itself) was met twice on 2026-10-31.

Rule bent, said here: mesh-delivery's unit tests rise 662 -> 892 because the judge's tests moved there from mesh-sdk (1686 -> 1440); the mesh-wide total falls. After the delivery every Go module rebuilds against the latest mesh-sdk (about 120 modules; all compile against it).

Controller research "The controller, NATS-native": manifest judgement leaves the controller; it reads the indexer's verdicts state.

This member: selfcompose and the data items decode, take the verdict, hold and name a refused module; ignored errors are said once.

Reviewed-by: reviewer-1585@shanks at 07066fe7a0
Pushed-by: lead-47@shanks

https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL

The first group check failed only on gofmt (one blank line in mesh-sdk go/catalogue/streams.go); the fix is whitespace only, and every member re-pinned mesh-sdk 8af6e72; the reviewer checked each diff mechanically.

Delivery group feat/judge-once (mesh-sdk, mesh-delivery, mesh-catalog, mesh-host, mesh-controller, mesh-tools), one check, one Approve. Issue 1585. Decisions: ADR 0578 (a manifest is judged once, by the indexer; every other part decodes it and takes the verdict; packages carry contracts only), ADR 0579 (a stricter judge never holds a module already running: it warns), and ADR 0573 §2/§4 built (each build takes the latest published package; a group check builds against the group's package heads). Quick fix (readers hold a refused module, ~4 h) weighed against the thorough fix (judge once, ~32 h) and the thorough fix chosen with the operator (2026-11-01): the kind (a reader with an old judge silences itself) was met twice on 2026-10-31. Rule bent, said here: mesh-delivery's unit tests rise 662 -> 892 because the judge's tests moved there from mesh-sdk (1686 -> 1440); the mesh-wide total falls. After the delivery every Go module rebuilds against the latest mesh-sdk (about 120 modules; all compile against it). Controller research "The controller, NATS-native": manifest judgement leaves the controller; it reads the indexer's verdicts state. This member: selfcompose and the data items decode, take the verdict, hold and name a refused module; ignored errors are said once. Reviewed-by: reviewer-1585@shanks at 07066fe7a0a87551028f7548105bf0bb19dc83fe Pushed-by: lead-47@shanks https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL The first group check failed only on gofmt (one blank line in mesh-sdk go/catalogue/streams.go); the fix is whitespace only, and every member re-pinned mesh-sdk 8af6e72; the reviewer checked each diff mechanically.

mesh-tools added 4 commits 2026-11-01 02:19:52 +00:00

Take the indexer's verdict on a manifest instead of judging it, and name a held module (ADR 0578) af66f72931

Issue 1585, S17: the engine decodes manifests leniently; a module whose manifest the indexer refused is held and named,
its data key stands, and every other module's items are still published. Policy, HoldsData and the certificate check no
longer parse with the judge.

Claude-Session: https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL

Decode manifests in the packaging test, since the SDK's judge is deleted (ADR 0578) 1d3029fa1e

Claude-Session: https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL

Pin mesh-sdk at the final head of the judge-once work (ADR 0578) 0422893873

Claude-Session: https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL

Pin mesh-sdk after the first review round of the judge-once work (ADR 0578)

mesh/delivery-group group feat/judge-once checking: 6 of 6 member(s) ready

Details

mesh/delivery closed: a newer head of the same pull request

Details

mesh/check checking 974177a07478 on 233bb23bbcb1 | novox/mesh-host#192 in group feat/judge-once

974177a074

Claude-Session: https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL

mesh-tools commented

2026-11-01 02:20:01 +00:00

Delivery novox/mesh-host@07066fe7a0a8 — merged since 2026-11-01T07:55:06Z

Source — source.main moved to novox/mesh-host@bc960c51db. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group feat/judge-once: novox/mesh-catalog@432326264f, novox/mesh-controller@b564c315d0, novox/mesh-delivery@8e9cc58301, novox/mesh-host@07066fe7a0, novox/mesh-sdk@8af6e72669, novox/mesh-tools@c494018074

composed together: pass — the checker's verdict at the members' heads (a0269268ba29)

Transitions

2026-11-01 02:31 (new) → proposed (announced): novox/mesh-host#192's head announced
2026-11-01 02:31 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-11-01 07:55 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-host@07066fe7a0a8` — **merged** since 2026-11-01T07:55:06Z **Source** — source.main moved to novox/mesh-host@bc960c51dbf0. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `feat/judge-once`: novox/mesh-catalog@432326264f6c, novox/mesh-controller@b564c315d012, novox/mesh-delivery@8e9cc5830119, novox/mesh-host@07066fe7a0a8, novox/mesh-sdk@8af6e7266915, novox/mesh-tools@c4940180746a - composed together: pass — the checker's verdict at the members' heads (a0269268ba29) **Transitions** - 2026-11-01 02:31 (new) → proposed (announced): novox/mesh-host#192's head announced - 2026-11-01 02:31 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-01 07:55 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools commented

2026-11-01 02:22:13 +00:00

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: its head 62cddf4efc62 is no longer the pull request's head, or the pull request closed. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

jschoubben added 1 commit 2026-11-01 02:31:11 +00:00

Pin the group's mesh-sdk head after the gofmt fix

mesh/delivery merged: source.main moved to novox/mesh-host@bc960c51dbf0

Details

mesh/delivery-group group feat/judge-once merged: every member is merged

Details

mesh/check checking 07066fe7a0a8 on 233bb23bbcb1 | novox/mesh-host#192 in group feat/judge-once

07066fe7a0

Claude-Session: https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL

mesh-tools commented

2026-11-01 02:41:34 +00:00

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-tools commented

2026-11-01 03:14:51 +00:00

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-tools commented

2026-11-01 03:50:21 +00:00

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-tools merged commit bc960c51db into main

2026-11-01 07:55:04 +00:00

mesh-tools deleted branch feat/judge-once

2026-11-01 07:55:05 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-host#192