Node-engine: a stop never cuts a save off, an archive's unpack is recorded at once, and an answer the want carries is acted on at start (issue 1585) #207

Merged

mesh-tools merged 4 commits from fix/archive-record-at-unpack into main 2026-11-04 10:04:26 +00:00

Conversation 1 Commits 4 Files Changed 18

+658 -62

4 Commits

Author	SHA1	Message	Date
jschoubben	5dc3a8e17f	Keep what an archive unpacked in the engine's own state directory, never beside the archive, and stop no slower than the host waits (issue 1585, review round 1) ... The journal of an unpack sat at <target>.unpacked.json, in a directory the module's account may write: a forged one would make the root engine remove or adopt any path it named. It now lives under <statedir>/unpacked/<sha256 of the target>.json, mode 0600, names its target, and is refused whole when an entry is not filepath.IsLocal or a parent is not above the target. It goes when the archive is taken off, whether its state record still said what it unpacked or not. The launcher's stop grace for a host on trial rises from 20 s to 75 s and the unit's TimeoutStopSec is 120 s (openrc the same), past the host's own 60 s wait for the apply in flight, so neither cuts a save off again. Tests folded as rows into existing ones (the repository is over its unit budget): the journal's rows, a forged entry and parent refused, the journal gone with a record that lost its Unpacked; the test that passed on main dropped; the stop test waits on its own line, not a sleep, and no longer consumes the save it waits for. Claude-Session: https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn	2026-11-04 10:52:42 +01:00
jschoubben	768f637bd0	Act at the engine's start on a backup answer the want already carries, so an answer written before a restart is never swallowed (issue 1585) ... nats on novox, 2026-11-04: the operator answered "Back up again", the engine restarted, and baseline() took the hold with AnsweredRev = the want's current revision, so the answer in that very revision was never acted on and compose refused "held for a failed backup". Quick fix: answer once more (a new want revision). Thorough fix, chosen: at baseline, a held module whose want carries again or skip is applied (again backs it up first, skip goes on without one); a hold with no answer stays held. The cost said in the code: an answer already acted on before a stop, whose backup failed again, is tried once more per start. Claude-Session: https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn	2026-11-04 10:36:48 +01:00
jschoubben	ee0f46b78f	Stop between applies and save the node's state as one writer, so a stop never cuts a save off and loses its records (issue 1585) ... On novox the node-engine's state had lost the records of nats's two archives, which only a temporary save file of 2026-10-24 still held, and about 260 such files (~80 MB) lay beside it. The cause: an apply runs detached from the engine's stop (applyContext, WithoutCancel), and runLink returned, and the process ended, without waiting for it; a save cut between its write and its rename left its temporary file and the state before it, and whatever the apply did was never recorded. Quick fix: remove the leftover files by hand and restore the records. Thorough fix, chosen: the engine ends between applies whichever way it ends (a stop, standing aside, a move to another bus): it waits up to 60 s for the apply in flight, then lets no save start (store.Quiesce). Save is one writer per process, flushes the directory after its rename, and says loudly each record the state saved before held that this save drops and nothing forgot (Forget, Release mark what is dropped on purpose, and no longer write into an array an earlier copy reads). The engine's start removes leftover temporary saves under the apply lock and says how many. Claude-Session: https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn	2026-11-04 10:36:48 +01:00
jschoubben	84a14b08d5	Write down what an archive unpacked as soon as it is unpacked, so a lost record never makes the host's own files foreign (issue 1585) ... Claude-Session: https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn	2026-11-04 10:26:43 +01:00