novox/mesh-host
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

The node-engine passes seats with the SDK's one rule, by the build its node runs, and says the pass (ADR 0660, issue 1966, recovery) #212

Merged
mesh-tools merged 2 commits from fix/1966-seat-pass-shared into main 2026-11-08 14:47:22 +00:00
Conversation 1 Commits 2 Files Changed 5
+93 -172
mesh-tools commented 2026-11-08 14:46:22 +00:00
Member
Copy Link
Copy Source

Recovery fix under the instruction section recovery-fixes-merge-and-tell; one delivery group with mesh-sdk and mesh-delivery on the same branch.

Cause. See mesh-sdk's pull request on this branch: a stale holder of mesh-catalog holds the grants user list back, and ace's node-engine refuses every pass for want of its seat-list grant. ADR 0660 §3 has the node-engine and the grants part apply one rule.

Change. internal/compose/resolution/seat_pass.go and its test deleted; rest.go calls catalogue.SeatsToPassOn; each assignment is read by its node's Kept build, else the trunk's, else unread; Declared.Said carries each pass and the two-claimant line (ADR 0660 §4). Other nodes' running builds are read from the trunk for now: the read of their wants is a subtask on issue 1966 (note 101).

Undo. Revert the merge commit.

Reviewed-by: mesh-code-reviewer@shanks at 60f413f9bc

https://claude.ai/code/session_01NcbgfFfQ4Z9UE5jK32PmE5

Recovery fix under the instruction section recovery-fixes-merge-and-tell; one delivery group with mesh-sdk and mesh-delivery on the same branch. **Cause.** See mesh-sdk's pull request on this branch: a stale holder of mesh-catalog holds the grants user list back, and ace's node-engine refuses every pass for want of its seat-list grant. ADR 0660 §3 has the node-engine and the grants part apply one rule. **Change.** `internal/compose/resolution/seat_pass.go` and its test deleted; `rest.go` calls `catalogue.SeatsToPassOn`; each assignment is read by its node's `Kept` build, else the trunk's, else unread; `Declared.Said` carries each pass and the two-claimant line (ADR 0660 §4). Other nodes' running builds are read from the trunk for now: the read of their wants is a subtask on issue 1966 (note 101). **Undo.** Revert the merge commit. Reviewed-by: mesh-code-reviewer@shanks at 60f413f9bc6ac7868663cef884a9f6f0331516fa https://claude.ai/code/session_01NcbgfFfQ4Z9UE5jK32PmE5
mesh-tools added 2 commits 2026-11-08 14:46:23 +00:00
The node-engine composes seat passes with the SDK's one rule instead of its own copy (issue 1966, ADR 0660) 5108c28e22 
Claude-Session: https://claude.ai/code/session_01NcbgfFfQ4Z9UE5jK32PmE5
The node-engine reads each assignment by the build its node keeps and says a seat pass in its answer (issue 1966, ADR 0660)
mesh/delivery merged: source.main moved to novox/mesh-host@6dd8e08a84ed
Details
mesh/delivery-group group fix/1966-seat-pass-shared merged: every member is merged
Details
mesh/check checking 60f413f9bc6a on 6dd8e08a84ed | novox/mesh-host#212 in group fix/1966-seat-pass-shared
60f413f9bc 
Claude-Session: https://claude.ai/code/session_01NcbgfFfQ4Z9UE5jK32PmE5
mesh-tools commented 2026-11-08 14:46:26 +00:00
Author
Member
Copy Link
Copy Source

Delivery novox/mesh-host@60f413f9bc6a — merged since 2026-11-08T14:47:24Z

Source — source.main moved to novox/mesh-host@6dd8e08a84. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/1966-seat-pass-shared: novox/mesh-delivery@d88c0f269d, novox/mesh-host@60f413f9bc, novox/mesh-sdk@3379b24c80

Transitions

  • 2026-11-08 14:46 (new) → proposed (announced): novox/mesh-host#212's head announced
  • 2026-11-08 14:46 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-11-08 14:47 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-host@60f413f9bc6a` — **merged** since 2026-11-08T14:47:24Z **Source** — source.main moved to novox/mesh-host@6dd8e08a84ed. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/1966-seat-pass-shared`: novox/mesh-delivery@d88c0f269d5f, novox/mesh-host@60f413f9bc6a, novox/mesh-sdk@3379b24c8092 **Transitions** - 2026-11-08 14:46 (new) → proposed (announced): novox/mesh-host#212's head announced - 2026-11-08 14:46 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-08 14:47 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
mesh-tools merged commit 6dd8e08a84 into main 2026-11-08 14:47:22 +00:00
mesh-tools deleted branch fix/1966-seat-pass-shared 2026-11-08 14:47:23 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
mesh/ready
Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-host#212