The filter keeps the openings of a module left out of the declaration that still runs (issue 1966, recovery) #218

Merged

mesh-tools merged 2 commits from fix/1966-filter-keeps-openings into main 2026-11-09 09:49:15 +00:00

Conversation 1 Commits 2 Files Changed 2

+123 -37

2 Commits

Author	SHA1	Message	Date
jschoubben	17a4ac620c	A left-out module's openings keep its per-node narrowing (issue 1966, review round 1) ... Rules skipped a left-out module's expose and reaches, so its listens opened at the manifest's default source and an operator's narrowing for the node was dropped (ADR 0046). Its exposure is now read like any module's (exposureOf); where it cannot be read for that module, its listens open no wider than the mesh (noWiderThanTheMesh), never at the manifest's default. Left for the thorough fix, composing a left-out module as what runs of it (Carried, as a held module is): the filter also opens for a left-out module that never ran on the node, and it opens the new manifest's listens rather than what the old composition runs. Claude-Session: https://claude.ai/code/session_01NcbgfFSnn24M3GcqttoU7i	2026-11-09 10:43:48 +01:00
jschoubben	95f45b1a74	Keep a left-out module's openings in the filter: it still runs (issue 1966) ... A module left out of the declaration for a setting its new definition no longer composes (ADR 0163 rule 6) keeps running what it ran, but resolutionCompose dropped it from the modules the filter is derived from, so the filter closed the ports it still serves. On novox, 2026-11-09 07:46-09:24 UTC, the artifact store's want at build 6e1dfaa8 (listens on 5100, no container publishes 5000) met the node layer's ports {"5000": 5100}: GivenPorts refused it, distribution was left out, and 5100 closed while the old registry container served there; every build failed "dial tcp 10.10.0.1:5100: i/o timeout". The filter is now derived from the composed modules and the left-out ones; a left-out module's settings (exposure) are still not read. Claude-Session: https://claude.ai/code/session_01NcbgfFSnn24M3GcqttoU7i	2026-11-09 10:36:55 +01:00