The node-engine stops a module's apply at its first failed resource, and reads if-config, config-lines and config-json (issue 1979) #227

Merged

mesh-tools merged 8 commits from feature/1979-zfs-owns-zfs into main 2026-11-13 08:00:44 +00:00

Conversation 2 Commits 8 Files Changed 15

+582 -116

8 Commits

Author	SHA1	Message	Date
jschoubben	96a8690639	Fix 1979: mib-bytes writes the bytes as a whole number for every size ... A size of a million MiB or more reached the file in exponent form and was refused. Builds: design 42 zfs-owns-zfs §3, A-24	2026-11-13 01:32:36 +01:00
jschoubben	7868c9f365	Fix 1979: ${config-json} writes only the keys the module declares under config ... A key a layer holds that the manifest does not declare (scrub-pool during a rename) is not a config value of the module. Builds: design 42 zfs-owns-zfs §9, A-15, A-24, A-25	2026-11-13 01:32:27 +01:00
jschoubben	225f2abb1f	H5 engine-integration: the node-engine whole applies if-config, config-lines and a module's stop at a failure ... The existing node-engine integration test's module gains a file under if-config, a template with config-lines from a list, and two files that fail and are left under a value; the test asserts the file appears and goes with its value, the lines follow the list, and the failing resource fails the module with the later resource left. No integration test is added. Builds: design 42 zfs-owns-zfs §5 (and §1 to §3), A-22	2026-11-13 00:24:20 +01:00
jschoubben	61806a7a92	H4 engine-states: the node record states the new words and forms ... The node record's reads come from mesh-sdk's ManifestReads, so building with S1 and S2 states word:resources.if-config, form:config-lines and form:config-json; the record test now asserts them. Builds: design 42 zfs-owns-zfs §4, answer A-13	2026-11-13 00:22:48 +01:00
jschoubben	61c42f9fbc	H3 engine-config-lines, H3b engine-config-json: a template writes lines from a config value and the config as JSON ... `${config-lines:<key>:<prefix>[:mib-bytes]}` in a file's content writes one line per entry (nothing for an unset value or empty list; a newline in an entry refuses the composition); `${config-json}` writes the module's set config values as one JSON object. Both join the sweep's table of fillers. Their rows join the config table test (A-22). Builds: design 42 zfs-owns-zfs §3, §9; answers A-15, A-24, A-22	2026-11-13 00:22:22 +01:00
jschoubben	86048f0ed9	H2b engine-found-handed: the found state of a unit passes to the record that stays ... When one record of a unit goes while another still declares it, what the going record found of the unit is kept for the staying one when that has no finding of its own, so the module's leave gives back the state found before the mesh. The preview test and the new case are one test (A-22). Builds: design 42 zfs-owns-zfs §2, answers A-21, A-22	2026-11-13 00:20:59 +01:00
jschoubben	039415cdd9	H2 engine-if-config: a resource is declared only while a config value holds ... The composer leaves out each resource whose `if-config` holds none of its conditions against the module's config values (with defaults), and drops the key from the rest, as the node-engine parses strictly. A resource that leaves is removed by the existing orphan removal. One table test replaces the two tests of setting_into_test.go. Builds: design 42 zfs-owns-zfs §2, A-21 (declaration side), A-22	2026-11-13 00:19:49 +01:00
jschoubben	fb492da7e7	H1 engine-stop-at-failure: a module's apply stops at its first failed resource ... A failed resource of a module gates the rest of that module, which is reported skipped with the failed resource named; the module's result names each one left. A resource of no module, and other modules, go on as before. One table test replaces two in apply_test.go; two fixtures adapted to the rule. Builds: design 42 zfs-owns-zfs §1 (ADR 0679 §16 (a)), A-22	2026-11-13 00:19:49 +01:00