node-engine: the golden node grant holds every verb the manifest invokes (A-461c) #234

Merged
mesh-tools merged 3 commits from fix/47-G-node-engine-integration into main 2026-11-17 08:49:22 +00:00
Member

Design 47 G, the lead's answers A-461b and A-461c (hq G-22-lead-answers-2.md).

Cause: #233's askTrunkBuilds (internal/selfcompose/entries.go) asks the seat mesh-catalog's verb module in every pass; the golden node grant (internal/nodegrant/testdata/node.json) lacked its call subject, so in the tests every pass waited out the call's bound, and three integration tests of cmd/mesh-host failed in pipeline main.992.mesh-host (they pass at #233's first parent).

  • The golden grant gains the call subject of module and of the eight other invoked verbs (flat form, checked live against grants_why_refused).
  • A check reads the manifest's invokes and fails on any invoked seat verb whose subject the golden grant lacks (checkGrantHoldsEveryInvokedVerb, called from TestTheNodeComposesItsWantsFromTheBus; no new test function: test budget).

Quick vs thorough: thorough (the class: a test grant that lags the manifest; every invoke now checked).

Tests: vet, vet -tags integration, go test ./... pass; cmd/mesh-host integration passes (28.9 s); the reviewer removed each of the 11 verbs in turn and the check failed naming it. After G: no pass waits on a call (hq G-23 item 14).

Reviewed-by: mesh-code-reviewer for lead-47@shanks at 85ad1eef74 (round 2)

Design 47 G, the lead's answers A-461b and A-461c (hq G-22-lead-answers-2.md). Cause: #233's askTrunkBuilds (internal/selfcompose/entries.go) asks the seat mesh-catalog's verb module in every pass; the golden node grant (internal/nodegrant/testdata/node.json) lacked its call subject, so in the tests every pass waited out the call's bound, and three integration tests of cmd/mesh-host failed in pipeline main.992.mesh-host (they pass at #233's first parent). - The golden grant gains the call subject of module and of the eight other invoked verbs (flat form, checked live against grants_why_refused). - A check reads the manifest's invokes and fails on any invoked seat verb whose subject the golden grant lacks (checkGrantHoldsEveryInvokedVerb, called from TestTheNodeComposesItsWantsFromTheBus; no new test function: test budget). Quick vs thorough: thorough (the class: a test grant that lags the manifest; every invoke now checked). Tests: vet, vet -tags integration, go test ./... pass; cmd/mesh-host integration passes (28.9 s); the reviewer removed each of the 11 verbs in turn and the check failed naming it. After G: no pass waits on a call (hq G-23 item 14). Reviewed-by: mesh-code-reviewer for lead-47@shanks at 85ad1eef745a931bba6838168f8f8235089feeee (round 2)
mesh-tools added 3 commits 2026-11-17 08:49:18 +00:00
The composer asks the trunk build of another node's module through the seat mesh-catalog's verb module (declared in the manifest); the golden grant lacked its call subject, so the ask hung to the node's bound in every pass and held the integration tests.

Builds: design 47 G-22 A-461b
Builds: design 47 G-22 A-461c, A-461b
Builds: design 47 G-22 A-461c
mesh-tools merged commit d0b208b668 into main 2026-11-17 08:49:22 +00:00
mesh-tools deleted branch fix/47-G-node-engine-integration 2026-11-17 08:49:23 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-host#234