G-24: the node-engine's composer names the modules it blames #235

Merged
mesh-tools merged 6 commits from fix/47-G-composer-blames into main 2026-11-17 12:15:37 +00:00
6 Commits
Author SHA1 Message Date
jschoubben ed7cefb5d8 composer: the search for culprits goes on past a hold that changes the problem (G-24 review r2)
A hold that changes the problem but leaves the machine not composing keeps that module held and blamed,
and the search goes on against the retry's problem within the same blame_tries, until the machine
composes or no hold changes it: every module the change refuses is blamed, never only the first.

Builds: design 47 G §721, §722, A-470c, A-470v
2026-11-17 13:10:51 +01:00
jschoubben f21b8c202d composer: a build that can never be made is blamed after the held composition is judged (G-24 H3 review r1)
The held composition's own blames and its search come first; the module whose build can never be made is
then blamed beside them. A held composition that still fails and blames nobody stays on the node's own
account, so the module is not blamed in its place.

Builds: design 47 G §721, §722, A-470j, A-470k
2026-11-17 13:05:38 +01:00
jschoubben b4bf772de4 composer: one search for culprits, inside the node-engine's composition, bounded by blame_tries (G-24 H2 review r1)
ComposeSent no longer runs the node-engine's own culprit search (fixed at eight modules), and the composer's
own loop, which reran that search at every try, is gone: ComposeSent holds the case's changed modules on the
machine one at a time, one composition each, at most blame_tries, and blames the first whose hold ends the
problem; past the bound the untried are named. Without blame_tries there is no search. A module the node
holds composing without the change is held as there, and two owners of one path are blamed outside the search.

Builds: design 47 G §721, A-468i, A-468l, A-469j, A-469k, A-470c
2026-11-17 13:03:15 +01:00
jschoubben c5f76cb974 composer: a build that can never be made is blamed, not a reason to judge no machine (G-24 H3)
A module awaited on a machine whose revision gives it no fingerprint (the case's none) is held as its
node-engine holds it, the machine judged from that composition, and the module blamed with the revision's
none words, so only its own pipelines fail. An awaited build with a fingerprint keeps the machine not judged.

Builds: design 47 G §721, §722, A-470j, A-470k
2026-11-17 12:04:20 +01:00
jschoubben 8700aabba3 composer: a machine that fails with no module held is searched for its culprit, bounded by blame_tries (G-24 H2)
The composer program has no settings, so the assigner bounds the search through the request: only the candidate's
changed modules placed on the machine are held, one at a time, the search ending at the first whose hold ends the
problem; past the bound the untried are named. A request with no blame_tries gets no search.

Builds: design 47 G §721, §733; A-468h, A-468i, A-469i, A-469j, A-469k
2026-11-17 11:21:49 +01:00
jschoubben 06781d4dbc composer: a machine's verdict names the modules it blames (G-24 H1)
The assigner fails only the composition steps of the modules a machine blames, so the composer names them: the modules
the change refuses that the node held neither in its read nor composing without the change, answered structured by
ComposeSent, and both owners of a path two modules own, from the resolution's pairs. Blamed is always written, so a
verdict blaming none is told from an old composer's. The two request-file tests are one, for the test budget.

Builds: design 47 G §721, §733; A-468h, A-468l, A-469h, A-469j
2026-11-17 11:19:54 +01:00