novox/mesh-host
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Give back only the groups the mesh added, and say when a new login is needed (hq ADR 0252, issue 247) #54

Merged
mesh-admin merged 1 commits from feat/module-groups into main 2026-10-08 10:09:23 +00:00
Conversation 3 Commits 1 Files Changed 13
+1096 -31
mesh-admin commented 2026-10-08 10:02:55 +00:00
Contributor
Copy Link
Copy Source

A module puts the operator's account in a group by declaring the account as a user resource with that group alone (hq ADR 0252, to-be 41 WP6). The controller already lets several modules add groups to one account.

What changes in the node-engine:

  • Applying (internal/apply/groups.go): asks the group database before usermod --append, so a group the machine lacks fails the resource with that reason. Records on the resource each group it added that the account was not in before (store.Applied.Groups). The outcome says a session that began before has the group only after a new login.
  • Removing: a group this resource added and no longer asks for, or every such group when undeclared, is given back with gpasswd --delete (busybox delgroup), read back, never fatal. Kept while another declared resource asks for it. A group the account was in before is never recorded and never taken back.
  • Looking (internal/accounts): beside liveness and the failed-unit reading, reads for each account a module puts in groups the database's groups and the running account manager's groups (from /proc/<pid>/status, the manager found through the machine's own systemctl show user@<uid>.service, never starting it). Stated as the module's resource of kind account: healthy, or unhealthy with not in the group or relogin needed: .... The controller raises that as the module's condition with no change of its own.

Tests: internal/apply/groups_test.go, internal/accounts/accounts_test.go. merge-check.sh passes locally.

A module puts the operator's account in a group by declaring the account as a `user` resource with that group alone (hq ADR 0252, to-be 41 WP6). The controller already lets several modules add groups to one account. What changes in the node-engine: - **Applying** (`internal/apply/groups.go`): asks the group database before `usermod --append`, so a group the machine lacks fails the resource with that reason. Records on the resource each group it added that the account was not in before (`store.Applied.Groups`). The outcome says a session that began before has the group only after a new login. - **Removing**: a group this resource added and no longer asks for, or every such group when undeclared, is given back with `gpasswd --delete` (busybox `delgroup`), read back, never fatal. Kept while another declared resource asks for it. A group the account was in before is never recorded and never taken back. - **Looking** (`internal/accounts`): beside liveness and the failed-unit reading, reads for each account a module puts in groups the database's groups and the running account manager's groups (from `/proc/<pid>/status`, the manager found through the machine's own `systemctl show user@<uid>.service`, never starting it). Stated as the module's resource of kind `account`: healthy, or unhealthy with `not in the group` or `relogin needed: ...`. The controller raises that as the module's condition with no change of its own. Tests: `internal/apply/groups_test.go`, `internal/accounts/accounts_test.go`. `merge-check.sh` passes locally.
mesh-admin commented 2026-10-08 10:03:19 +00:00
Author
Contributor
Copy Link
Copy Source

Delivery novox/mesh-host@ab4ca44f98e8 — delivered since 2026-10-08T10:12:56Z

Delivery plan — builds mesh-host → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-host
  • ace: receives mesh-host
  • g14: receives mesh-host
  • novox: receives mesh-host
  • shanks: receives mesh-host

Group feat/module-groups, in order: novox/mesh-catalog@da57051fa3 → novox/mesh-host@ab4ca44f98

  • composed together: pass — every machine composes with the change as it did without (4 of 4 compose)

Machines

  • mesh-host on ace: passed — healthy 3 times over 2m18s
  • mesh-host on the rest running it: sent

Transitions

  • 2026-10-08 10:04 (new) → proposed (announced): novox/mesh-host#54's head announced
  • 2026-10-08 10:08 proposed → checked (checked): the verdict names this commit
  • 2026-10-08 10:08 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-08 10:09 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-08 10:09 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path
  • 2026-10-08 10:12 delivering → delivered (done): its walk is done: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-host@ab4ca44f98e8` — **delivered** since 2026-10-08T10:12:56Z **Delivery plan** — builds mesh-host → ace, g14, novox, shanks; no bus step - tier 0: mesh-host - ace: receives mesh-host - g14: receives mesh-host - novox: receives mesh-host - shanks: receives mesh-host **Group** `feat/module-groups`, in order: novox/mesh-catalog@da57051fa3b9 → novox/mesh-host@ab4ca44f98e8 - composed together: pass — every machine composes with the change as it did without (4 of 4 compose) **Machines** - mesh-host on ace: passed — healthy 3 times over 2m18s - mesh-host on the rest running it: sent **Transitions** - 2026-10-08 10:04 (new) → proposed (announced): novox/mesh-host#54's head announced - 2026-10-08 10:08 proposed → checked (checked): the verdict names this commit - 2026-10-08 10:08 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-08 10:09 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-08 10:09 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path - 2026-10-08 10:12 delivering → delivered (done): its walk is done: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
jschoubben added 1 commit 2026-10-08 10:04:28 +00:00
Give back only the groups the mesh added, and say when a new login is needed (hq ADR 0252, issue 247)
mesh/merge-gate pass: builds mesh-host → ace, g14, novox, shanks; no bus step; every machine composes with the change as it did without (4 of 4 compose)
Details
mesh/repo-check pass: its merge-check.sh passed
Details
mesh/delivery delivered
Details
mesh/delivery-group group feat/module-groups merged: every member is merged
Details
ab4ca44f98 
A module puts the operator's account in a group by declaring the account with that group alone.
The node-engine now records each group it added, takes back only those when nothing declared still
asks for them, refuses a group the machine lacks before usermod runs, and states each such account
as its module's resource of kind account: relogin needed while the running session lacks the group.
jschoubben force-pushed feat/module-groups from 73a5cd1ad2 to ab4ca44f98 2026-10-08 10:04:28 +00:00 Compare
mesh-admin changed title from Give back only the groups the mesh added, and say when a new login is needed (hq ADR 0251, issue 247) to Give back only the groups the mesh added, and say when a new login is needed (hq ADR 0252, issue 247) 2026-10-08 10:04:36 +00:00
mesh-admin commented 2026-10-08 10:04:54 +00:00
Author
Contributor
Copy Link
Copy Source

Merge check at 73a5cd1a

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-host)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds mesh-host → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-host
  • ace: receives mesh-host
  • g14: receives mesh-host
  • novox: receives mesh-host
  • shanks: receives mesh-host

Run by the build seat on ace as build-1791453793123397182 (builds --log build-1791453793123397182).

--- the gate: mesh-host
mesh-host: ok
long-running resources without health: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-08T09:54:03Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-08T09:54:03Z

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 1 module(s) in 1 tier(s): mesh-host
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-host/cmd/mesh-bootstrap	1.013s
ok  	github.com/novox/mesh-host/cmd/mesh-host	5.343s
ok  	github.com/novox/mesh-host/examples	1.015s
ok  	github.com/novox/mesh-host/internal/accounts	1.012s
ok  	github.com/novox/mesh-host/internal/apply	4.373s
ok  	github.com/novox/mesh-host/internal/bootstrap	1.552s
ok  	github.com/novox/mesh-host/internal/bundle	1.013s
ok  	github.com/novox/mesh-host/internal/declaration	1.069s
ok  	github.com/novox/mesh-host/internal/firewall	1.645s
ok  	github.com/novox/mesh-host/internal/identity	1.159s
ok  	github.com/novox/mesh-host/internal/image	1.013s
ok  	github.com/novox/mesh-host/internal/inventory	1.046s
ok  	github.com/novox/mesh-host/internal/link	10.377s
ok  	github.com/novox/mesh-host/internal/liveness	2.130s
ok  	github.com/novox/mesh-host/internal/network	1.102s
ok  	github.com/novox/mesh-host/internal/outward	1.064s
ok  	github.com/novox/mesh-host/internal/profile	1.519s
ok  	github.com/novox/mesh-host/internal/reachable	1.044s
ok  	github.com/novox/mesh-host/internal/store	1.281s
ok  	github.com/novox/mesh-host/internal/system	1.049s
ok  	github.com/novox/mesh-host/internal/tunnel	1.044s
ok  	github.com/novox/mesh-host/internal/units	1.059s
ok  	github.com/novox/mesh-host/internal/upgrade	1.200s
ok  	github.com/novox/mesh-host/internal/witness	4.622s
ok  	github.com/novox/mesh-host/packaging	1.041s
ok  	github.com/novox/mesh-host/validate	1.038s
**Merge check** at `73a5cd1a` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-host) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds mesh-host → ace, g14, novox, shanks; no bus step - tier 0: mesh-host - ace: receives mesh-host - g14: receives mesh-host - novox: receives mesh-host - shanks: receives mesh-host Run by the build seat on ace as `build-1791453793123397182` (`builds --log build-1791453793123397182`). ``` --- the gate: mesh-host mesh-host: ok long-running resources without health: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-08T09:54:03Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-08T09:54:03Z machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 1 module(s) in 1 tier(s): mesh-host --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-host/cmd/mesh-bootstrap 1.013s ok github.com/novox/mesh-host/cmd/mesh-host 5.343s ok github.com/novox/mesh-host/examples 1.015s ok github.com/novox/mesh-host/internal/accounts 1.012s ok github.com/novox/mesh-host/internal/apply 4.373s ok github.com/novox/mesh-host/internal/bootstrap 1.552s ok github.com/novox/mesh-host/internal/bundle 1.013s ok github.com/novox/mesh-host/internal/declaration 1.069s ok github.com/novox/mesh-host/internal/firewall 1.645s ok github.com/novox/mesh-host/internal/identity 1.159s ok github.com/novox/mesh-host/internal/image 1.013s ok github.com/novox/mesh-host/internal/inventory 1.046s ok github.com/novox/mesh-host/internal/link 10.377s ok github.com/novox/mesh-host/internal/liveness 2.130s ok github.com/novox/mesh-host/internal/network 1.102s ok github.com/novox/mesh-host/internal/outward 1.064s ok github.com/novox/mesh-host/internal/profile 1.519s ok github.com/novox/mesh-host/internal/reachable 1.044s ok github.com/novox/mesh-host/internal/store 1.281s ok github.com/novox/mesh-host/internal/system 1.049s ok github.com/novox/mesh-host/internal/tunnel 1.044s ok github.com/novox/mesh-host/internal/units 1.059s ok github.com/novox/mesh-host/internal/upgrade 1.200s ok github.com/novox/mesh-host/internal/witness 4.622s ok github.com/novox/mesh-host/packaging 1.041s ok github.com/novox/mesh-host/validate 1.038s ```
mesh-admin commented 2026-10-08 10:08:11 +00:00
Author
Contributor
Copy Link
Copy Source

Merge check at ab4ca44f

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-host)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds mesh-host → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-host
  • ace: receives mesh-host
  • g14: receives mesh-host
  • novox: receives mesh-host
  • shanks: receives mesh-host

Run by the build seat on g14 as build-1791453886623568634 (builds --log build-1791453886623568634).

--- the gate: mesh-host
mesh-host: ok
long-running resources without health: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-08T10:04:03Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-08T10:04:03Z

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 1 module(s) in 1 tier(s): mesh-host
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-host/cmd/mesh-bootstrap	1.013s
ok  	github.com/novox/mesh-host/cmd/mesh-host	5.315s
ok  	github.com/novox/mesh-host/examples	1.019s
ok  	github.com/novox/mesh-host/internal/accounts	1.032s
ok  	github.com/novox/mesh-host/internal/apply	2.129s
ok  	github.com/novox/mesh-host/internal/bootstrap	1.341s
ok  	github.com/novox/mesh-host/internal/bundle	1.011s
ok  	github.com/novox/mesh-host/internal/declaration	1.048s
ok  	github.com/novox/mesh-host/internal/firewall	1.684s
ok  	github.com/novox/mesh-host/internal/identity	1.067s
ok  	github.com/novox/mesh-host/internal/image	1.014s
ok  	github.com/novox/mesh-host/internal/inventory	1.037s
ok  	github.com/novox/mesh-host/internal/link	10.360s
ok  	github.com/novox/mesh-host/internal/liveness	2.053s
ok  	github.com/novox/mesh-host/internal/network	1.037s
ok  	github.com/novox/mesh-host/internal/outward	1.025s
ok  	github.com/novox/mesh-host/internal/profile	1.487s
ok  	github.com/novox/mesh-host/internal/reachable	1.023s
ok  	github.com/novox/mesh-host/internal/store	1.117s
ok  	github.com/novox/mesh-host/internal/system	1.012s
ok  	github.com/novox/mesh-host/internal/tunnel	1.019s
ok  	github.com/novox/mesh-host/internal/units	1.010s
ok  	github.com/novox/mesh-host/internal/upgrade	1.037s
ok  	github.com/novox/mesh-host/internal/witness	1.444s
ok  	github.com/novox/mesh-host/packaging	1.013s
ok  	github.com/novox/mesh-host/validate	1.006s
**Merge check** at `ab4ca44f` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-host) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds mesh-host → ace, g14, novox, shanks; no bus step - tier 0: mesh-host - ace: receives mesh-host - g14: receives mesh-host - novox: receives mesh-host - shanks: receives mesh-host Run by the build seat on g14 as `build-1791453886623568634` (`builds --log build-1791453886623568634`). ``` --- the gate: mesh-host mesh-host: ok long-running resources without health: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-08T10:04:03Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-08T10:04:03Z machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 1 module(s) in 1 tier(s): mesh-host --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-host/cmd/mesh-bootstrap 1.013s ok github.com/novox/mesh-host/cmd/mesh-host 5.315s ok github.com/novox/mesh-host/examples 1.019s ok github.com/novox/mesh-host/internal/accounts 1.032s ok github.com/novox/mesh-host/internal/apply 2.129s ok github.com/novox/mesh-host/internal/bootstrap 1.341s ok github.com/novox/mesh-host/internal/bundle 1.011s ok github.com/novox/mesh-host/internal/declaration 1.048s ok github.com/novox/mesh-host/internal/firewall 1.684s ok github.com/novox/mesh-host/internal/identity 1.067s ok github.com/novox/mesh-host/internal/image 1.014s ok github.com/novox/mesh-host/internal/inventory 1.037s ok github.com/novox/mesh-host/internal/link 10.360s ok github.com/novox/mesh-host/internal/liveness 2.053s ok github.com/novox/mesh-host/internal/network 1.037s ok github.com/novox/mesh-host/internal/outward 1.025s ok github.com/novox/mesh-host/internal/profile 1.487s ok github.com/novox/mesh-host/internal/reachable 1.023s ok github.com/novox/mesh-host/internal/store 1.117s ok github.com/novox/mesh-host/internal/system 1.012s ok github.com/novox/mesh-host/internal/tunnel 1.019s ok github.com/novox/mesh-host/internal/units 1.010s ok github.com/novox/mesh-host/internal/upgrade 1.037s ok github.com/novox/mesh-host/internal/witness 1.444s ok github.com/novox/mesh-host/packaging 1.013s ok github.com/novox/mesh-host/validate 1.006s ```
mesh-admin merged commit 9815796891 into main 2026-10-08 10:09:23 +00:00
mesh-admin deleted branch feat/module-groups 2026-10-08 10:09:23 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
mesh/ready
Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-host#54