Merge pull request 'Register R310: a pull request is judged by the base branch's merge-check.sh (hq issue 310)' (#65) from replays/310-the-base-branchs-check-judges into main
This commit was merged in pull request #65.
This commit is contained in:
@@ -166,6 +166,18 @@ var Register = []Replay{
|
||||
Module: "modules/mesh-delivery", Package: "./cmd/mesh-delivery", Test: "TestARecheck",
|
||||
Files: []string{"modules/mesh-delivery/cmd/mesh-delivery/recheck_test.go",
|
||||
"modules/mesh-delivery/cmd/mesh-delivery/fakes_test.go"}},
|
||||
// A pull request ran its own copy of the repository's check (2026-10-08): the build agent read
|
||||
// merge-check.sh from the change's head, so a branch cut before the script, or one that deleted or
|
||||
// gutted it, merged with none of its tests run. Written with only what the agent had before the fix, so
|
||||
// it fails on the commit before by answering the warning. The fix is still on its branch: proved
|
||||
// against the main it branched from.
|
||||
{ID: "R310", Issue: 310, Kind: InRepository, Repository: "mesh-controller", Fix: "cb0327d",
|
||||
Before: "1a50d6e",
|
||||
What: "the media catalogue's Lidarr pull request, cut before its repository had a merge-check.sh, was " +
|
||||
"answered no repository check defined as a warning and merged with none of its tests run",
|
||||
Asserts: "where the base branch holds a merge-check.sh, its script judges the change's tree, and a head " +
|
||||
"without one is never answered the warning",
|
||||
Package: "./internal/builder", Test: "TestReplay310", Files: []string{"internal/builder/replay310_test.go"}},
|
||||
// Not a core incident, and the first of its kind: a module's. The crash loop was found by a person
|
||||
// reading the agent server's log for another reason (issue 268); research 032 measured it, and ADR
|
||||
// 0240 makes the node-engine judge it and the gate fail it.
|
||||
|
||||
Reference in New Issue
Block a user