novox/mesh-lab
6
0
Fork 0
Code Issues Pull Requests 1 Releases Wiki Activity

Register the replay of issue 309 (hq ADR 0237)
mesh/merge-gate pass: the change touches no module of the mesh's graph
Details
mesh/repo-check pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (typescript), replays/merge-check.sh (go)
Details
mesh/delivery superseded: a newer head of the same pull request
Details

Browse Source 
Proved with cmd/prove: TestReplay309 fails on the controller before c5a2edf
(the group refused as a cycle) and passes on it.
This commit is contained in:
jochen
2026-10-08 10:44:39 +02:00
parent 6fd0683425
commit 535a363ddf
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
replays/register.go
+10
View File
@@ -166,6 +166,16 @@ var Register = []Replay{
Module: "modules/mesh-delivery", Package: "./cmd/mesh-delivery", Test: "TestARecheck",
Files: []string{"modules/mesh-delivery/cmd/mesh-delivery/recheck_test.go",
"modules/mesh-delivery/cmd/mesh-delivery/fakes_test.go"}},
// Two order rules ordered one pair both ways (2026-10-08): the controller's member moved the build agent,
// which builds the node-engine, and the node-engine goes before the controller, so the group
// feat/a-machine-joins-through-the-tunnel was refused as a cycle and merged by hand. A test in the
// controller, using only what orderOf had before its fix, laid over the commit before it.
{ID: "R309", Issue: 309, Kind: InRepository, Repository: "mesh-controller", Fix: "c5a2edf",
What: "a delivery group of the controller, the node-engine and the lab, each ready, was rejected: built by " +
"put the controller's member first and engine before controller put the node-engine's first",
Asserts: "rules that order one pair both ways are resolved by precedence — built by over engine before " +
"controller — and the group is ordered, the controller's member first",
Package: "./cmd/mesh-controller", Test: "TestReplay309", Files: []string{"cmd/mesh-controller/replay309_test.go"}},
// Not a core incident, and the first of its kind: a module's. The crash loop was found by a person
// reading the agent server's log for another reason (issue 268); research 032 measured it, and ADR
// 0240 makes the node-engine judge it and the gate fail it.