Register R237: assign's answer agrees with plan right after the act (hq issue 237) #83

2026-10-12T14:24:46Z

mesh-admin commented

2026-10-12 14:24:46 +00:00

Replaces #81 (approved at a020f60, review on #81). #80 (R358) merged into the same spot in replays/register.go that #81 used, so #81 could no longer merge. This PR is #81's content rebased onto current main: the R237 block is byte-identical to the one approved at a020f60, only its place in the file differs — it now sits after R358's entry instead of directly after R294's, since R358 is now already on main.

assign on a workstation already running a module that contributed node-hotkeys, after assigning the module holding that seat, said the seat was now held and then that the node was left out of the mesh for lack of it, naming the assignment just made as the remedy. plan for the node right after resolved.

TestReplay237 needs a store: it goes through inventory.ForTest, which raises a throwaway PostgreSQL database against MESH_TEST_POSTGRES, the same as the controller's other store-backed replays (e.g. R368).

Proved (fresh Postgres container of my own, torn down after):

$ MESH_TEST_POSTGRES=postgres://postgres:check@127.0.0.1:<port>/postgres?sslmode=disable go run ./cmd/prove --repos /home/jochen/projects/novox R237
R237 (issue 237): PROVED — before its fix fails, on its fix passes
  before: replay237_test.go:43: the answer says "laptop is left out", which `plan` right after contradicts:

Also reran, against this rebased tree: gofmt clean, go vet ./... clean, go test -run '^(TestEveryReplayIsWhole|TestTheBedProvesWhatTheChangeTouches)$' . — both pass.

Does not merge this PR itself; leaving it open for review.

Replaces #81 (approved at a020f60, review on #81). #80 (R358) merged into the same spot in replays/register.go that #81 used, so #81 could no longer merge. This PR is #81's content rebased onto current main: the R237 block is byte-identical to the one approved at a020f60, only its place in the file differs — it now sits after R358's entry instead of directly after R294's, since R358 is now already on main. assign on a workstation already running a module that contributed node-hotkeys, after assigning the module holding that seat, said the seat was now held and then that the node was left out of the mesh for lack of it, naming the assignment just made as the remedy. `plan` for the node right after resolved. TestReplay237 needs a store: it goes through inventory.ForTest, which raises a throwaway PostgreSQL database against MESH_TEST_POSTGRES, the same as the controller's other store-backed replays (e.g. R368). Proved (fresh Postgres container of my own, torn down after): ``` $ MESH_TEST_POSTGRES=postgres://postgres:check@127.0.0.1:<port>/postgres?sslmode=disable go run ./cmd/prove --repos /home/jochen/projects/novox R237 R237 (issue 237): PROVED — before its fix fails, on its fix passes before: replay237_test.go:43: the answer says "laptop is left out", which `plan` right after contradicts: ``` Also reran, against this rebased tree: gofmt clean, go vet ./... clean, go test -run '^(TestEveryReplayIsWhole|TestTheBedProvesWhatTheChangeTouches)$' . — both pass. Does not merge this PR itself; leaving it open for review.

mesh-admin added 1 commit 2026-10-12 14:24:46 +00:00

Register R237: assign's answer agrees with plan right after the act (hq issue 237)

mesh/merge-gate pass: the change touches no module of the mesh's graph

Details

mesh/repo-check pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (typescript), replays/merge-check.sh (go), asks/merge-check.sh …

Details

mesh/delivery delivered

Details

bd33abf3dd

Rebase of #81 (a020f60) onto main after #80 (R358) merged into the same
spot in register.go. The R237 block is byte-identical to the one approved
at a020f60; only its place in the file differs, now after R358.

Proved with go run ./cmd/prove R237: fails on mesh-controller #253's commit
before (72edb45), passes on the fix (5facd8b, mesh-controller #253).
TestReplay237 needs MESH_TEST_POSTGRES (inventory.ForTest raises a throwaway
database), same as the controller's other store-backed replays.

mesh-admin commented

2026-10-12 14:24:54 +00:00

Delivery novox/mesh-lab@bd33abf3ddac — delivered since 2026-10-12T14:37:52Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Transitions

2026-10-12 14:24 (new) → proposed (announced): novox/mesh-lab#83's head announced
2026-10-12 14:30 proposed → checked (checked): the verdict names this commit
2026-10-12 14:30 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
2026-10-12 14:37 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
2026-10-12 14:37 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

**Delivery** `novox/mesh-lab@bd33abf3ddac` — **delivered** since 2026-10-12T14:37:52Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Transitions** - 2026-10-12 14:24 (new) → proposed (announced): novox/mesh-lab#83's head announced - 2026-10-12 14:30 proposed → checked (checked): the verdict names this commit - 2026-10-12 14:30 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-12 14:37 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-12 14:37 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.

mesh-admin referenced this pull request

2026-10-12 14:25:02 +00:00

Register R237: assign's answer agrees with plan right after the act (hq issue 237) #81

mesh-admin merged commit a97ba661d9 into main

2026-10-12 14:37:46 +00:00

mesh-admin deleted branch replay/r237-rebased

2026-10-12 14:37:47 +00:00

mesh-admin referenced this issue from a commit

2026-10-12 14:41:43 +00:00

Register R233: a declaration that restores the package manager applies while it does not answer (hq issue 233)

mesh-admin referenced this pull request

2026-10-12 14:41:51 +00:00