novox/mesh-lab
7
0
Fork 0
Code Issues Pull Requests 1 Releases Wiki Activity

Register R237: assign's answer agrees with plan right after the act (hq issue 237) #81

Closed
mesh-admin wants to merge 1 commits from replay/r237 into main
pull from: replay/r237
merge into: :main
Conversation 3 Commits 1 Files Changed 1
+15
mesh-admin commented 2026-10-12 13:43:22 +00:00
Contributor
Copy Link
Copy Source

Registers R237, same shape as #80 (R358): issue 237, Kind InRepository, repository mesh-controller, Fix the merge commit of mesh-controller #253 (5facd8b08e245545fb7656dd4af11280d9306a08), package ./cmd/mesh-controller, test TestReplay237, file cmd/mesh-controller/replay237_test.go (present in that commit's tree).

assign on a workstation already running a module that contributed node-hotkeys, after assigning the module holding that seat, said the seat was now held and then that the node was left out of the mesh for lack of it, naming the assignment just made as the remedy. plan for the node right after resolved.

TestReplay237 needs a store: it goes through inventory.ForTest, which raises a throwaway PostgreSQL database against MESH_TEST_POSTGRES, the same as the controller's other store-backed replays (e.g. R368). Proved it here with a Postgres container of my own.

Proved:

$ MESH_TEST_POSTGRES=postgres://postgres:check@127.0.0.1:<port>/postgres?sslmode=disable go run ./cmd/prove R237
R237 (issue 237): PROVED — before its fix fails, on its fix passes
  before: replay237_test.go:43: the answer says "laptop is left out", which `plan` right after contradicts:

Ran the lab's merge-check.sh (npm typecheck, npm test, replays/merge-check.sh, asks/merge-check.sh): exit 0, 161 passed, 2 skipped (the operator's-answer proof and the container-based replays themselves, neither of which run in this check's own container — as documented).

Does not merge this PR itself; leaving it open for review.

Registers R237, same shape as #80 (R358): issue 237, Kind InRepository, repository mesh-controller, Fix the merge commit of mesh-controller #253 (5facd8b08e245545fb7656dd4af11280d9306a08), package ./cmd/mesh-controller, test TestReplay237, file cmd/mesh-controller/replay237_test.go (present in that commit's tree). assign on a workstation already running a module that contributed node-hotkeys, after assigning the module holding that seat, said the seat was now held and then that the node was left out of the mesh for lack of it, naming the assignment just made as the remedy. `plan` for the node right after resolved. TestReplay237 needs a store: it goes through inventory.ForTest, which raises a throwaway PostgreSQL database against MESH_TEST_POSTGRES, the same as the controller's other store-backed replays (e.g. R368). Proved it here with a Postgres container of my own. Proved: ``` $ MESH_TEST_POSTGRES=postgres://postgres:check@127.0.0.1:<port>/postgres?sslmode=disable go run ./cmd/prove R237 R237 (issue 237): PROVED — before its fix fails, on its fix passes before: replay237_test.go:43: the answer says "laptop is left out", which `plan` right after contradicts: ``` Ran the lab's merge-check.sh (npm typecheck, npm test, replays/merge-check.sh, asks/merge-check.sh): exit 0, 161 passed, 2 skipped (the operator's-answer proof and the container-based replays themselves, neither of which run in this check's own container — as documented). Does not merge this PR itself; leaving it open for review.
mesh-admin added 1 commit 2026-10-12 13:43:22 +00:00
Register R237: assign's answer agrees with plan right after the act (hq issue 237)
mesh/merge-gate pass: the change touches no module of the mesh's graph
Details
mesh/repo-check pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (typescript), replays/merge-check.sh (go), asks/merge-check.sh …
Details
mesh/delivery stopped: the pull request closed unmerged
Details
a020f60243 
Proved with go run ./cmd/prove R237: fails on mesh-controller #253's commit
before (72edb45), passes on the fix (5facd8b, mesh-controller #253).
TestReplay237 needs MESH_TEST_POSTGRES (inventory.ForTest raises a throwaway
database), same as the controller's other store-backed replays.
mesh-admin commented 2026-10-12 13:44:03 +00:00
Author
Contributor
Copy Link
Copy Source

Delivery novox/mesh-lab@a020f60243bd — stopped since 2026-10-12T14:25:13Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Transitions

  • 2026-10-12 13:43 (new) → proposed (announced): novox/mesh-lab#81's head announced
  • 2026-10-12 13:47 proposed → checked (checked): the verdict names this commit
  • 2026-10-12 13:47 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-12 14:25 ready → stopped (closed): the pull request closed unmerged

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-lab@a020f60243bd` — **stopped** since 2026-10-12T14:25:13Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Transitions** - 2026-10-12 13:43 (new) → proposed (announced): novox/mesh-lab#81's head announced - 2026-10-12 13:47 proposed → checked (checked): the verdict names this commit - 2026-10-12 13:47 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-12 14:25 ready → stopped (closed): the pull request closed unmerged The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
mesh-admin commented 2026-10-12 13:46:04 +00:00
Author
Contributor
Copy Link
Copy Source

Verdict: approve at a020f60

Independent review from a fresh clone at the PR head (a020f60243), with mesh-controller cloned beside mesh-lab as the prover expects.

  • Shape: the R237 entry matches the other InRepository entries' field order and comment style (compared against R358, R368, R294) — a prefatory comment on the incident, how it was found, the store note, and where the fix is, then ID, Issue, Kind, Repository, Fix, What, Asserts, Package, Test, Files. No Home/HomeRef, consistent with other entries whose test file is already part of the Fix merge commit.
  • Only replays/register.go changes in this PR — no scope creep.
  • replays/merge-check.sh steps pass: gofmt clean, go vet ./... clean, the two local tests pass.
  • go run ./cmd/prove R237, run against a throwaway Postgres container of my own (torn down after) via MESH_TEST_POSTGRES, says: R237 (issue 237): PROVED — before its fix fails, on its fix passes, with the before-failure line the answer says "laptop is left out", which \plan` right after contradicts:` — matching the PR body's own test-plan output exactly.
  • Verified independently in a fresh clone of mesh-controller: commit 5facd8b08e245545fb7656dd4af11280d9306a08 is on mesh-controller's main, is the merge of mesh-controller #253 ("An act's answer is said from one resolution after its write"), and its diff includes exactly cmd/mesh-controller/replay237_test.go among its five changed files, matching Package: "./cmd/mesh-controller" and Test: "TestReplay237".
  • Read the test itself: it assigns the seat-holding module onto a workstation already running a dependent module, asserts plan for the node resolves right after, and asserts the answer's lines agree with that (no "left out"/"does not resolve" wording once the seat is held) — matches the entry's What and Asserts text precisely.

Checks at the time of this review: mesh/merge-gate is still pending (building on shanks since 15:43) and mesh/repo-check has not yet posted (shows "missing"), so main's branch protection does not yet consider this mergeable. Re-check both before merging.

Verdict: approve at a020f60 Independent review from a fresh clone at the PR head (a020f60243bd606e2f2bc49295d2340f2677c1db), with mesh-controller cloned beside mesh-lab as the prover expects. - Shape: the R237 entry matches the other `InRepository` entries' field order and comment style (compared against R358, R368, R294) — a prefatory comment on the incident, how it was found, the store note, and where the fix is, then `ID`, `Issue`, `Kind`, `Repository`, `Fix`, `What`, `Asserts`, `Package`, `Test`, `Files`. No `Home`/`HomeRef`, consistent with other entries whose test file is already part of the Fix merge commit. - Only `replays/register.go` changes in this PR — no scope creep. - `replays/merge-check.sh` steps pass: gofmt clean, `go vet ./...` clean, the two local tests pass. - `go run ./cmd/prove R237`, run against a throwaway Postgres container of my own (torn down after) via `MESH_TEST_POSTGRES`, says: `R237 (issue 237): PROVED — before its fix fails, on its fix passes`, with the before-failure line `the answer says "laptop is left out", which \`plan\` right after contradicts:` — matching the PR body's own test-plan output exactly. - Verified independently in a fresh clone of mesh-controller: commit 5facd8b08e245545fb7656dd4af11280d9306a08 is on mesh-controller's main, is the merge of mesh-controller #253 ("An act's answer is said from one resolution after its write"), and its diff includes exactly `cmd/mesh-controller/replay237_test.go` among its five changed files, matching `Package: "./cmd/mesh-controller"` and `Test: "TestReplay237"`. - Read the test itself: it assigns the seat-holding module onto a workstation already running a dependent module, asserts `plan` for the node resolves right after, and asserts the answer's lines agree with that (no "left out"/"does not resolve" wording once the seat is held) — matches the entry's `What` and `Asserts` text precisely. Checks at the time of this review: `mesh/merge-gate` is still pending (building on shanks since 15:43) and `mesh/repo-check` has not yet posted (shows "missing"), so main's branch protection does not yet consider this mergeable. Re-check both before merging.
mesh-admin commented 2026-10-12 14:25:02 +00:00
Author
Contributor
Copy Link
Copy Source

Superseded by #83: main moved out from under this PR (#80/R358 merged into the same spot in replays/register.go), so this head (a020f60) can no longer merge cleanly. #83 carries the same R237 block — byte-identical content, approved here — rebased onto current main. Closing this one; please re-point any approval there.

Superseded by #83: main moved out from under this PR (#80/R358 merged into the same spot in replays/register.go), so this head (a020f60) can no longer merge cleanly. #83 carries the same R237 block — byte-identical content, approved here — rebased onto current main. Closing this one; please re-point any approval there.
mesh-admin closed this pull request 2026-10-12 14:25:12 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
jschoubben miel.truyen
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-lab#81