novox/mesh-lab
6
0
Fork 0
Code Issues Pull Requests 2 Releases Wiki Activity

Register R341: a check judged the head alone and let a merge that does not compile through (hq issue 341) #86

Merged
mesh-admin merged 1 commits from feat/341-a-merge-check-judges-the-merge into main 2026-10-12 16:11:30 +00:00
Conversation 1 Commits 1 Files Changed 1
+11
mesh-admin commented 2026-10-12 15:31:03 +00:00
Contributor
Copy Link
Copy Source

This adds R341 to replays/register.go, the replay of novox/hq issue 341 under ADR 0323.

  • Kind: InRepository in mesh-controller, ./internal/builder, TestReplay341 (file internal/builder/replay341_test.go).
  • Fix and Before: Fix is 83a9cf6, the head of mesh-controller feat/341-a-merge-check-judges-the-merge. Before is 3cfc121, the main it branched from. Once the controller's pull request merges, set Fix to its merge and clear Before, as the register says.
  • Proved by hand: go run ./replays/cmd/prove --repos <clones> R341 answered R341 (issue 341): PROVED — before its fix fails, on its fix passes. Before the fix, #66's head was answered its merge-check.sh passed.
  • How it runs: the replay runs the builder's Check whole. It uses a container runtime on PATH that runs each container's command on the machine, the store and bus answering and the judge never built. The repository's own check is go build ./... on a two-commit miniature of the node-engine's store record of 2026-10-09.

replays/merge-check.sh passes: register, prover and tests.

This adds R341 to `replays/register.go`, the replay of novox/hq issue 341 under ADR 0323. - **Kind**: `InRepository` in mesh-controller, `./internal/builder`, `TestReplay341` (file `internal/builder/replay341_test.go`). - **Fix and Before**: Fix is `83a9cf6`, the head of mesh-controller `feat/341-a-merge-check-judges-the-merge`. Before is `3cfc121`, the main it branched from. Once the controller's pull request merges, set Fix to its merge and clear Before, as the register says. - **Proved by hand**: `go run ./replays/cmd/prove --repos <clones> R341` answered `R341 (issue 341): PROVED — before its fix fails, on its fix passes`. Before the fix, #66's head was answered `its merge-check.sh passed`. - **How it runs**: the replay runs the builder's `Check` whole. It uses a container runtime on PATH that runs each container's command on the machine, the store and bus answering and the judge never built. The repository's own check is `go build ./...` on a two-commit miniature of the node-engine's store record of 2026-10-09. `replays/merge-check.sh` passes: register, prover and tests.
mesh-admin added 1 commit 2026-10-12 15:31:03 +00:00
Register R341: a check judged the head alone and let a merge that does not compile through
mesh/merge-gate pass: the change touches no module of the mesh's graph
Details
mesh/repo-check pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (typescript), replays/merge-check.sh (go), asks/merge-check.sh …
Details
mesh/delivery delivered
Details
mesh/delivery-group group feat/341-a-merge-check-judges-the-merge delivered: every member is delivered
Details
79108a72a0 
Proved with replays/cmd/prove: TestReplay341 fails on the controller's main
and passes on its fix (novox/hq ADR 0323, issue 341).
mesh-admin commented 2026-10-12 15:31:14 +00:00
Author
Contributor
Copy Link
Copy Source

Delivery novox/mesh-lab@79108a72a0df — delivered since 2026-10-12T16:11:52Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Group feat/341-a-merge-check-judges-the-merge, in order: novox/hq@09916e2bbc → novox/mesh-controller@875ebc093e → novox/mesh-catalog@41b6e10077 → novox/mesh-lab@79108a72a0

Transitions

  • 2026-10-12 15:31 (new) → proposed (announced): novox/mesh-lab#86's head announced
  • 2026-10-12 15:35 proposed → checked (checked): the verdict names this commit
  • 2026-10-12 15:35 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-12 16:11 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-12 16:11 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-lab@79108a72a0df` — **delivered** since 2026-10-12T16:11:52Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Group** `feat/341-a-merge-check-judges-the-merge`, in order: novox/hq@09916e2bbc07 → novox/mesh-controller@875ebc093e18 → novox/mesh-catalog@41b6e10077ef → novox/mesh-lab@79108a72a0df - novox/mesh-controller@875ebc093e18 before novox/mesh-catalog@41b6e10077ef: built by - composed together: pass — every machine composes with the change as it did without (4 of 4 compose) **Transitions** - 2026-10-12 15:31 (new) → proposed (announced): novox/mesh-lab#86's head announced - 2026-10-12 15:35 proposed → checked (checked): the verdict names this commit - 2026-10-12 15:35 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-12 16:11 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-12 16:11 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
mesh-admin merged commit 24b833d19d into main 2026-10-12 16:11:30 +00:00
mesh-admin deleted branch feat/341-a-merge-check-judges-the-merge 2026-10-12 16:11:30 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
jschoubben miel.truyen
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-lab#86