Register R363: a README-only merge made a new digest of an unchanged Go program (hq issue 363) #97

Merged

mesh-admin merged 1 commits from fix/363-replay into main 2026-10-13 05:08:20 +00:00

Conversation 1 Commits 1 Files Changed 1

+13

mesh-admin commented 2026-10-13 05:01:58 +00:00

Contributor

Copy Link

Copy Source

after: novox/mesh-controller fix/363-replay

What: the register entry R363, added after R348. It is InRepository in mesh-controller.

• Fix: cd6757f1 (the merge of #292).
• Test: TestReplay363 in ./internal/builder.
• Home: mesh-controller 94c928b1, the head of mesh-controller's fix/363-replay, which is reachable once that PR merges.

Tested:

• go run ./cmd/prove --repos <clones> R363 says "PROVED — before its fix fails, on its fix passes".
• Before the fix the test fails with: "one build source, two digests: … a README-only merge is a new program".
• go test ./... in replays passes.
• It needs no store.

Issue 363 (its replay).

after: novox/mesh-controller fix/363-replay **What**: the register entry R363, added after R348. It is `InRepository` in mesh-controller. - Fix: cd6757f1 (the merge of #292). - Test: `TestReplay363` in `./internal/builder`. - Home: mesh-controller 94c928b1, the head of mesh-controller's `fix/363-replay`, which is reachable once that PR merges. **Tested**: - `go run ./cmd/prove --repos <clones> R363` says "PROVED — before its fix fails, on its fix passes". - Before the fix the test fails with: "one build source, two digests: … a README-only merge is a new program". - `go test ./...` in replays passes. - It needs no store. Issue 363 (its replay).

mesh-admin added 1 commit 2026-10-13 05:01:58 +00:00

Register R363: a README-only merge made a new digest of an unchanged Go program (hq issue 363) ... 5f13bf0aff

Proved with replays/cmd/prove: it fails on mesh-controller #292's first parent
and passes on its merge.

mesh-admin commented 2026-10-13 05:02:09 +00:00

Author

Contributor

Copy Link

Copy Source

Delivery novox/mesh-lab@5f13bf0aff9c — delivered since 2026-10-13T05:08:23Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Group fix/363-replay, in order: novox/mesh-controller@94c928b1f5 → novox/mesh-lab@5f13bf0aff

Transitions

• 2026-10-13 05:02 (new) → proposed (announced): novox/mesh-lab#97's head announced
• 2026-10-13 05:07 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
• 2026-10-13 05:07 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
• 2026-10-13 05:08 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
• 2026-10-13 05:08 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-lab@5f13bf0aff9c` — **delivered** since 2026-10-13T05:08:23Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Group** `fix/363-replay`, in order: novox/mesh-controller@94c928b1f5af → novox/mesh-lab@5f13bf0aff9c **Transitions** - 2026-10-13 05:02 (new) → proposed (announced): novox/mesh-lab#97's head announced - 2026-10-13 05:07 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-13 05:07 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-13 05:08 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-13 05:08 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.

mesh-admin reviewed 2026-10-13 05:07:49 +00:00

mesh-admin left a comment

Author

Contributor

Copy Link

Copy Source

Verdict: approve at 5f13bf0aff

The entry is well formed and placed correctly after R348 in replays/register.go: Kind: InRepository, Repository "mesh-controller", Fix "cd6757f1e3c818bc6043178bfb4edb42b8f3c63d" (the full sha of the merge of mesh-controller #292, confirmed by git rev-parse cd6757f1 against the mesh-controller clone), Package "./internal/builder", Test "TestReplay363", Files ["internal/builder/replay363_test.go"], Home "mesh-controller", HomeRef "94c928b1f5af099c328eb6950550b6380df24b31" (the exact head of mesh-controller #293).

I cloned mesh-controller and mesh-lab side by side under one directory (as cmd/prove's default --repos=../.. expects when run from replays/), fetched mesh-controller's pr293 head into that clone so the HomeRef commit is present, checked out this PR's head, and ran GOTMPDIR=/var/tmp go run ./cmd/prove R363 from mesh-lab's replays/ directory. Output: "R363 (issue 363): PROVED — before its fix fails, on its fix passes", with the before line "replay363_test.go:84: one build source, two digests: sha256:94a5f99... at b1019630325e, sha256:95256b4... at 0cd091e14305 — a README-only merge is a new program". I also ran the replays module's own suite, go test ./... in replays/, which passed ("ok github.com/novox/mesh-lab/replays 27.385s"), so TestEveryReplayIsWhole accepts the new entry's shape (its Kind, Files and Package satisfy the InRepository case, its ID matches the R pattern, and no ID collides).

Verdict: approve at 5f13bf0aff9c7b584054b53b237d646dfc5d42ce The entry is well formed and placed correctly after R348 in replays/register.go: Kind: InRepository, Repository "mesh-controller", Fix "cd6757f1e3c818bc6043178bfb4edb42b8f3c63d" (the full sha of the merge of mesh-controller #292, confirmed by `git rev-parse cd6757f1` against the mesh-controller clone), Package "./internal/builder", Test "TestReplay363", Files ["internal/builder/replay363_test.go"], Home "mesh-controller", HomeRef "94c928b1f5af099c328eb6950550b6380df24b31" (the exact head of mesh-controller #293). I cloned mesh-controller and mesh-lab side by side under one directory (as cmd/prove's default --repos=../.. expects when run from replays/), fetched mesh-controller's pr293 head into that clone so the HomeRef commit is present, checked out this PR's head, and ran `GOTMPDIR=/var/tmp go run ./cmd/prove R363` from mesh-lab's replays/ directory. Output: "R363 (issue 363): PROVED — before its fix fails, on its fix passes", with the before line "replay363_test.go:84: one build source, two digests: sha256:94a5f99... at b1019630325e, sha256:95256b4... at 0cd091e14305 — a README-only merge is a new program". I also ran the replays module's own suite, `go test ./...` in replays/, which passed ("ok github.com/novox/mesh-lab/replays 27.385s"), so TestEveryReplayIsWhole accepts the new entry's shape (its Kind, Files and Package satisfy the InRepository case, its ID matches the R<issue> pattern, and no ID collides).

mesh-admin merged commit 3eb48c949f into main 2026-10-13 05:08:20 +00:00

mesh-admin deleted branch fix/363-replay 2026-10-13 05:08:20 +00:00

mesh-admin referenced this pull request 2026-10-13 05:24:50 +00:00

Register the replay of issue 239: a module's name is not taken over by another repository (hq issue 239) #98

Sign in to join this conversation.

Reviewers

No Reviewers

mesh-admin

Labels

No items

No labels

Milestone

No items

No Milestone

Assignees

Clear assignees

jschoubben miel.truyen

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-lab#97