novox/mesh-lab
7
0
Fork 0
Code Issues Pull Requests 1 Releases Wiki Activity

Register the replay of issue 239: a module's name is not taken over by another repository (hq issue 239) #98

Merged
mesh-admin merged 1 commits from fix/239-replay into main 2026-10-13 05:37:15 +00:00
Conversation 1 Commits 1 Files Changed 1
+16
mesh-admin commented 2026-10-13 05:03:01 +00:00
Contributor
Copy Link
Copy Source

What. Register entry R239 in replays/register.go, after R348: the replay TestReplay239AModuleNameIsNotTakenOverByAnotherRepository in mesh-controller (#294).

Why. Issue 239 (2026-10-04: the photo app replaced by the catalogue's stub of the same name) was fixed by mesh-controller #174 (merge eb7a15808641f2075d9fd1660fa0e949b9cd7230, hq ADR 0266 §7) and had no replay.

Tested. sh replays/merge-check.sh passes. go run ./cmd/prove -repos <dir> R239 with a throwaway store: "PROVED — before its fix fails, on its fix passes". HomeRef 95556b8def3f3f21e3d037617d73f97606e6ea1f is mesh-controller #294's head, reachable once it merges: merge #294 first.

Fixes issue 239 (replay).

**What.** Register entry R239 in `replays/register.go`, after R348: the replay `TestReplay239AModuleNameIsNotTakenOverByAnotherRepository` in mesh-controller (#294). **Why.** Issue 239 (2026-10-04: the photo app replaced by the catalogue's stub of the same name) was fixed by mesh-controller #174 (merge `eb7a15808641f2075d9fd1660fa0e949b9cd7230`, hq ADR 0266 §7) and had no replay. **Tested.** `sh replays/merge-check.sh` passes. `go run ./cmd/prove -repos <dir> R239` with a throwaway store: "PROVED — before its fix fails, on its fix passes". HomeRef `95556b8def3f3f21e3d037617d73f97606e6ea1f` is mesh-controller #294's head, reachable once it merges: merge #294 first. Fixes issue 239 (replay).
mesh-admin commented 2026-10-13 05:03:18 +00:00
Author
Contributor
Copy Link
Copy Source

Delivery novox/mesh-lab@3b4ba29becc8 — delivered since 2026-10-13T05:37:39Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Group fix/239-replay, in order: novox/mesh-controller@95556b8def → novox/mesh-lab@3b4ba29bec

  • composed together: pass — the change touches no module of the mesh's graph

Transitions

  • 2026-10-13 05:26 (new) → proposed (announced): novox/mesh-lab#98's head announced
  • 2026-10-13 05:30 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-13 05:30 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-13 05:37 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-13 05:37 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-lab@3b4ba29becc8` — **delivered** since 2026-10-13T05:37:39Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Group** `fix/239-replay`, in order: novox/mesh-controller@95556b8def3f → novox/mesh-lab@3b4ba29becc8 - composed together: pass — the change touches no module of the mesh's graph **Transitions** - 2026-10-13 05:26 (new) → proposed (announced): novox/mesh-lab#98's head announced - 2026-10-13 05:30 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-13 05:30 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-13 05:37 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-13 05:37 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
mesh-admin left a comment
Author
Contributor
Copy Link
Copy Source

Verdict: request changes at 3e33caffdd

I ran go run ./cmd/prove R239 from mesh-lab/replays, with the repositories cloned side by side as the lab expects. It reported: "R239 (issue 239): PROVED — before its fix fails, on its fix passes", with before detail "replay239_test.go:61: a build of photos from the catalogue was registered over the app's own repository". The register entry's Fix and HomeRef are correctly wired to mesh-controller #174's merge and #294's head.

I also ran replays/merge-check.sh on this branch: it passed, gofmt and vet clean, with the expected "NOT RUN HERE" note for the replays that raise containers, matching the PR's own claim.

However, gitea reports this PR as not mergeable, and I confirmed why. R363 ("Register R363: a README-only merge made a new digest of an unchanged Go program", mesh-lab #97) merged into main after this PR's branch point, and it inserts its replays/register.go entry at the exact same place this PR inserts R239: immediately after the R348 entry, before the slice's closing brace. I reproduced the conflict directly: checking out this PR's head and running git merge origin/main gives "CONFLICT (content): Merge conflict in replays/register.go". The content fix is trivial — both entries kept, in either order — but the PR as submitted cannot be merged as-is. Please rebase onto current main and resolve the conflict in replays/register.go before this merges.

Verdict: request changes at 3e33caffdd6bd32b0a526ef874011e23349e869e I ran `go run ./cmd/prove R239` from mesh-lab/replays, with the repositories cloned side by side as the lab expects. It reported: "R239 (issue 239): PROVED — before its fix fails, on its fix passes", with before detail "replay239_test.go:61: a build of photos from the catalogue was registered over the app's own repository". The register entry's Fix and HomeRef are correctly wired to mesh-controller #174's merge and #294's head. I also ran replays/merge-check.sh on this branch: it passed, gofmt and vet clean, with the expected "NOT RUN HERE" note for the replays that raise containers, matching the PR's own claim. However, gitea reports this PR as not mergeable, and I confirmed why. R363 ("Register R363: a README-only merge made a new digest of an unchanged Go program", mesh-lab #97) merged into main after this PR's branch point, and it inserts its replays/register.go entry at the exact same place this PR inserts R239: immediately after the R348 entry, before the slice's closing brace. I reproduced the conflict directly: checking out this PR's head and running `git merge origin/main` gives "CONFLICT (content): Merge conflict in replays/register.go". The content fix is trivial — both entries kept, in either order — but the PR as submitted cannot be merged as-is. Please rebase onto current main and resolve the conflict in replays/register.go before this merges.
jschoubben added 1 commit 2026-10-13 05:25:50 +00:00
Register the replay of issue 239: a module's name is not taken over by another repository
mesh/merge-gate head 3b4ba29becc8 merged into trunk 3eb48c949fc2 — pass: the change touches no module of the mesh's graph
Details
mesh/repo-check head 3b4ba29becc8 merged into trunk 3eb48c949fc2 — pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (typescript)…
Details
mesh/delivery delivered
Details
mesh/delivery-group group fix/239-replay delivered: every member is delivered
Details
3b4ba29bec 
Its replay (mesh-controller #294) holds the photo app's outage of 2026-10-04 against the fix that
refuses a build from a repository other than the module's own (mesh-controller #174).
jschoubben force-pushed fix/239-replay from 3e33caffdd to 3b4ba29bec 2026-10-13 05:25:50 +00:00 Compare
mesh-admin left a comment
Author
Contributor
Copy Link
Copy Source

Verdict: approve at 3b4ba29bec

The rebase resolves review 166's conflict cleanly. git range-diff shows the one commit carried over unchanged in substance, now laid on top of R363 instead of R348; the full diff of replays/register.go against current main (3eb48c9) is a pure 16-line addition that keeps R363's entry untouched and appends R239 right after it, before the slice's closing brace — nothing else in the file changed. A real merge of origin/main into this head reports "Already up to date", so it is mergeable as a fast-forward. go run ./cmd/prove R239 reports "PROVED — before its fix fails, on its fix passes". No further concerns.

Verdict: approve at 3b4ba29becc85d360523f93d9abc38df64ecf2b0 The rebase resolves review 166's conflict cleanly. `git range-diff` shows the one commit carried over unchanged in substance, now laid on top of R363 instead of R348; the full diff of replays/register.go against current main (3eb48c9) is a pure 16-line addition that keeps R363's entry untouched and appends R239 right after it, before the slice's closing brace — nothing else in the file changed. A real merge of origin/main into this head reports "Already up to date", so it is mergeable as a fast-forward. `go run ./cmd/prove R239` reports "PROVED — before its fix fails, on its fix passes". No further concerns.
mesh-admin merged commit 9497dda929 into main 2026-10-13 05:37:15 +00:00
mesh-admin deleted branch fix/239-replay 2026-10-13 05:37:16 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
mesh-admin
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
jschoubben miel.truyen
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-lab#98