The bed's 058 claim, base64 dump, and 063 comment made honest (review) #36

Merged
jschoubben merged 1 commits from bed/honest-058-and-diagnostics into main 2026-09-20 11:42:00 +00:00
Owner

From the review of the bed's own assertions:

  • The RestartCount == 0 check cannot discriminate the 058 fix — the consumer is built after its broker is already up, so patient and exit-on-unreachable code both connect first-try, and restart-on recreates reset the count anyway. Downgraded to an honest liveness check; the comment points at the mesh-tools unit test as the real proof.
  • The trust-failure dump ran base64 -d over declared.json, which is JSON (not base64), so it always reported "no trust" whether or not it was declared. Removed; the adjacent Python check that decodes the inner declaration field is kept.
  • The 063 comment claimed the vhost is re-listed after the restart; the code only runs a TCP probe. Corrected, and the docker-proxy-vs-DNAT coupling noted.

Green fresh on run 17.

From the review of the bed's own assertions: - The `RestartCount == 0` check cannot discriminate the 058 fix — the consumer is built after its broker is already up, so patient and exit-on-unreachable code both connect first-try, and `restart-on` recreates reset the count anyway. Downgraded to an honest liveness check; the comment points at the mesh-tools unit test as the real proof. - The trust-failure dump ran `base64 -d` over `declared.json`, which is JSON (not base64), so it always reported "no trust" whether or not it was declared. Removed; the adjacent Python check that decodes the inner `declaration` field is kept. - The 063 comment claimed the vhost is re-listed after the restart; the code only runs a TCP probe. Corrected, and the docker-proxy-vs-DNAT coupling noted. Green fresh on run 17.
jschoubben added 1 commit 2026-09-20 11:41:43 +00:00
- The RestartCount==0 assertion cannot discriminate the 058 fix: the
  consumer is built after its broker is already up, so patient and
  exit-on-unreachable code both connect first-try; and restart-on
  recreates reset the count. Downgraded to an honest liveness check and
  the comment now points at the mesh-tools unit test as the real proof.
- The trust-failure dump ran base64 -d over declared.json, which is JSON
  (not base64), so it always reported 'no trust' — removed; the adjacent
  python check that decodes the inner declaration field is kept.
- The 063 comment claimed the vhost is re-listed after the restart; the
  code only runs a TCP probe. Comment corrected to what the code proves,
  and the docker-proxy-vs-DNAT coupling is noted.
jschoubben merged commit 3c3fa04949 into main 2026-09-20 11:42:00 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-lab#36