Check the Go replays in the Go toolchain, and register R301 and R302 (hq issues 301, 302) #59

2026-10-07T22:16:54Z

mesh-admin commented

2026-10-07 22:16:54 +00:00

hq issue 302. The lab's merge-check.sh runs in the TypeScript toolchain, which holds no Go compiler, so replays/ was "NOT CHECKED HERE" on every lab PR (#58's report) and a broken register would merge green.

merge-check.sh declares its Go part: # mesh-check-also: go replays/merge-check.sh.
replays/merge-check.sh (Go toolchain): gofmt, go vet ./... (compiles every test file), and the tests that need only Go and git: TestEveryReplayIsWhole and TestTheBedProvesWhatTheChangeTouches. It says that the replays themselves are not run there (no container runtime in the check's container).
By hand with Go at hand, merge-check.sh runs the Go part itself.

The build seat runs the declared part once novox/mesh-controller#125 is live; until then the header line is a comment and this repository is checked as before.

Register:

R301 (hq issue 301): a person's push of recorded builds counted as a repair; TestReplay301 in mesh-controller, fix e92a3fe (novox/mesh-controller#126).
R302 (hq issue 302): a gate replay of TestARepositoryInTwoLanguagesIsCheckedInBoth, fix 98ef7ba (novox/mesh-controller#125).

go run ./cmd/prove R301 R302: R301 PROVED (fails before, passes on its fix); R302 PROVED (absent before, passes on its fix).

Local sh merge-check.sh: the Go part passes. Two TypeScript tests (listing instances/networks fails rather than reporting none) fail on this workstation because it has a real incus. That happens without this change too; the change touches no TypeScript.

**hq issue 302.** The lab's `merge-check.sh` runs in the TypeScript toolchain, which holds no Go compiler, so `replays/` was "NOT CHECKED HERE" on every lab PR (#58's report) and a broken register would merge green. - `merge-check.sh` declares its Go part: `# mesh-check-also: go replays/merge-check.sh`. - `replays/merge-check.sh` (Go toolchain): gofmt, `go vet ./...` (compiles every test file), and the tests that need only Go and git: `TestEveryReplayIsWhole` and `TestTheBedProvesWhatTheChangeTouches`. It says that the replays themselves are not run there (no container runtime in the check's container). - By hand with Go at hand, `merge-check.sh` runs the Go part itself. The build seat runs the declared part once novox/mesh-controller#125 is live; until then the header line is a comment and this repository is checked as before. **Register:** - R301 (hq issue 301): a person's push of recorded builds counted as a repair; `TestReplay301` in mesh-controller, fix e92a3fe (novox/mesh-controller#126). - R302 (hq issue 302): a `gate` replay of `TestARepositoryInTwoLanguagesIsCheckedInBoth`, fix 98ef7ba (novox/mesh-controller#125). `go run ./cmd/prove R301 R302`: R301 PROVED (fails before, passes on its fix); R302 PROVED (absent before, passes on its fix). Local `sh merge-check.sh`: the Go part passes. Two TypeScript tests (`listing instances/networks fails rather than reporting none`) fail on this workstation because it has a real `incus`. That happens without this change too; the change touches no TypeScript.

mesh-admin added 1 commit 2026-10-07 22:16:54 +00:00

Check the Go replays in the Go toolchain, and register R301 and R302 (hq issues 301, 302)

mesh/merge-gate pass: the change touches no module of the mesh's graph

Details

mesh/repo-check pass: its merge-check.sh passed

Details

mesh/delivery delivered

Details

c4f57432e1

The lab's check ran in the TypeScript toolchain, which holds no Go compiler,
so the replays register was never compiled before a merge. merge-check.sh now
declares replays/merge-check.sh as its Go part, which the build seat runs in
the Go toolchain: gofmt, go vet and the register's own tests. Both new
replays are proved: each fails on the commit before its fix and passes on it.

mesh-admin commented

2026-10-07 22:17:18 +00:00

Delivery novox/mesh-lab@c4f57432e1ab — delivered since 2026-10-07T22:26:33Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Transitions

2026-10-07 22:17 (new) → proposed (announced): novox/mesh-lab#59's head announced
2026-10-07 22:17 proposed → checked (checked): the verdict names this commit
2026-10-07 22:17 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
2026-10-07 22:26 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
2026-10-07 22:26 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

**Delivery** `novox/mesh-lab@c4f57432e1ab` — **delivered** since 2026-10-07T22:26:33Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Transitions** - 2026-10-07 22:17 (new) → proposed (announced): novox/mesh-lab#59's head announced - 2026-10-07 22:17 proposed → checked (checked): the verdict names this commit - 2026-10-07 22:17 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-07 22:26 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-07 22:26 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.

mesh-admin referenced this pull request from novox/hq

2026-10-07 22:17:26 +00:00

Issues 301, 302: a push of recorded builds is no repair; the lab's Go replays are checked in Go #184

mesh-admin merged commit b75a17e51b into main

2026-10-07 22:26:27 +00:00

mesh-admin deleted branch fix/the-replays-are-checked-in-go

2026-10-07 22:26:27 +00:00

mesh-admin referenced this pull request

2026-10-09 09:09:58 +00:00

Prove the operator's answers end to end before anybody uses them (hq ADR 0259) #74

Sign in to join this conversation.