novox/mesh-lab
7
0
Fork 0
Code Issues Pull Requests 1 Releases Wiki Activity

Register R201: a plan sent the control node a controller older than the one running there (hq issue 201) #88

Merged
mesh-admin merged 1 commits from fix/201-replay into main 2026-10-12 20:22:44 +00:00
Conversation 2 Commits 1 Files Changed 1
+16
mesh-admin commented 2026-10-12 19:19:07 +00:00
Contributor
Copy Link
Copy Source

What

replays/register.go: R201, after R561. Kind InRepository in mesh-controller; Fix is #273's merge 84deb530ee5afe2ffdf4d2cc65cdc355b12f8ccb; Test TestReplay201ThePlansSend in ./cmd/mesh-controller; Files cmd/mesh-controller/replay201_test.go; Home mesh-controller at 45a1783ba9a43fd466a518ee85673c701223b517 (the head of mesh-controller #275).

Why

hq issue 201 resolves with its replay. The fix's own TestReplay201 (store-backed) uses names #273 added, so it cannot be laid over the commit before. mesh-controller #275 adds a dedicated replay written with only what the controller had before the fix, as R401 did with #274.

Order: merge mesh-controller #275 first. Until it merges, HomeRef 45a1783 is reachable only on its branch.

Proof

MESH_TEST_POSTGRES=<throwaway local postgres> go run ./cmd/prove --repos <dir with a mesh-controller clone holding 45a1783> R201:

R201 (issue 201): PROVED — before its fix fails, on its fix passes
  before: replay201_test.go:84: a plan's send carried anchor the controller c1aaaaaa, older than the c2bbbbbb anchor was last sent: the older binary would read the row its successor widened

sh replays/merge-check.sh passes (vet, register tests).

Replay for hq issue 201.

## What `replays/register.go`: R201, after R561. Kind InRepository in mesh-controller; Fix is #273's merge 84deb530ee5afe2ffdf4d2cc65cdc355b12f8ccb; Test `TestReplay201ThePlansSend` in `./cmd/mesh-controller`; Files `cmd/mesh-controller/replay201_test.go`; Home mesh-controller at 45a1783ba9a43fd466a518ee85673c701223b517 (the head of mesh-controller #275). ## Why hq issue 201 resolves with its replay. The fix's own `TestReplay201` (store-backed) uses names #273 added, so it cannot be laid over the commit before. mesh-controller #275 adds a dedicated replay written with only what the controller had before the fix, as R401 did with #274. **Order: merge mesh-controller #275 first.** Until it merges, HomeRef 45a1783 is reachable only on its branch. ## Proof `MESH_TEST_POSTGRES=<throwaway local postgres> go run ./cmd/prove --repos <dir with a mesh-controller clone holding 45a1783> R201`: R201 (issue 201): PROVED — before its fix fails, on its fix passes before: replay201_test.go:84: a plan's send carried anchor the controller c1aaaaaa, older than the c2bbbbbb anchor was last sent: the older binary would read the row its successor widened `sh replays/merge-check.sh` passes (vet, register tests). Replay for hq issue 201.
mesh-admin added 1 commit 2026-10-12 19:19:07 +00:00
Register R201: a plan sent the control node a controller older than the one running there (hq issue 201)
mesh/merge-gate head a96226f22819 merged into trunk 5c1c6f56c9d9 — pass: the change touches no module of the mesh's graph
Details
mesh/repo-check head a96226f22819 merged into trunk 5c1c6f56c9d9 — pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (typescript)…
Details
mesh/delivery delivered
Details
a96226f228 
Proved: fails on mesh-controller 84deb53^1, passes on 84deb53 (the fix, #273).
The replay is mesh-controller #275's TestReplay201ThePlansSend, since the
fix's own TestReplay201 reads what the fix added.
mesh-admin commented 2026-10-12 19:19:14 +00:00
Author
Contributor
Copy Link
Copy Source

Delivery novox/mesh-lab@a96226f22819 — delivered since 2026-10-12T20:22:50Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Transitions

  • 2026-10-12 19:19 (new) → proposed (announced): novox/mesh-lab#88's head announced
  • 2026-10-12 19:22 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-12 19:22 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-12 20:22 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-12 20:22 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-lab@a96226f22819` — **delivered** since 2026-10-12T20:22:50Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Transitions** - 2026-10-12 19:19 (new) → proposed (announced): novox/mesh-lab#88's head announced - 2026-10-12 19:22 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-12 19:22 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-12 20:22 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-12 20:22 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
mesh-admin left a comment
Author
Contributor
Copy Link
Copy Source

Verdict: approve at a96226f228

Independent review (registers R201).

What I checked:

  1. The entry follows the register's conventions as R237, R233 and R401 do. Its comment gives the incident and its date, why the test is its own laid over the commit before, that it needs MESH_TEST_POSTGRES, that Fix is the merge of its pull request, and that Home is the commit that added the replay. It has InRepository kind, a full 40-character Fix (84deb530, the merge of mesh-controller #273), What, Asserts, Package, Test and Files, and Home/HomeRef as R401 has them. TestEveryReplayIsWhole passes.
  2. Asserts matches the test (mesh-controller #275, TestReplay201ThePlansSend): a send that is no person's push carries the controller at the build the machine was last sent, and a person's push carries the record. The test uses only names present on 84deb530^1.
  3. Ran go run ./cmd/prove R201 in replays/ with a throwaway Postgres as MESH_TEST_POSTGRES (GOTMPDIR=/var/tmp): R201 PROVED. Before its fix it fails with "a plan's send carried anchor the controller c1aaaaaa, older than the c2bbbbbb anchor was last sent"; on its fix it passes.

Statuses at this head: mesh/merge-gate pending (building on ace since 21:19), mesh/repo-check missing (the required one), mesh/delivery pending (waits for its check). Not mergeable yet. There is no mesh/delivery-group status: this branch is fix/201-replay and mesh-controller #275's is test/201-replay, so they are not grouped.

For the merge: HomeRef 45a1783b is mesh-controller #275's head and becomes reachable from main only when #275 merges with a merge commit (not a squash). Merge #275 first, or rename one branch so the two form a delivery group.

Verdict: approve at a96226f228198624ea622a4bc70d8206431f6261 Independent review (registers R201). What I checked: 1. The entry follows the register's conventions as R237, R233 and R401 do. Its comment gives the incident and its date, why the test is its own laid over the commit before, that it needs MESH_TEST_POSTGRES, that Fix is the merge of its pull request, and that Home is the commit that added the replay. It has InRepository kind, a full 40-character Fix (84deb530, the merge of mesh-controller #273), What, Asserts, Package, Test and Files, and Home/HomeRef as R401 has them. TestEveryReplayIsWhole passes. 2. Asserts matches the test (mesh-controller #275, TestReplay201ThePlansSend): a send that is no person's push carries the controller at the build the machine was last sent, and a person's push carries the record. The test uses only names present on 84deb530^1. 3. Ran go run ./cmd/prove R201 in replays/ with a throwaway Postgres as MESH_TEST_POSTGRES (GOTMPDIR=/var/tmp): R201 PROVED. Before its fix it fails with "a plan's send carried anchor the controller c1aaaaaa, older than the c2bbbbbb anchor was last sent"; on its fix it passes. Statuses at this head: mesh/merge-gate pending (building on ace since 21:19), mesh/repo-check missing (the required one), mesh/delivery pending (waits for its check). Not mergeable yet. There is no mesh/delivery-group status: this branch is fix/201-replay and mesh-controller #275's is test/201-replay, so they are not grouped. For the merge: HomeRef 45a1783b is mesh-controller #275's head and becomes reachable from main only when #275 merges with a merge commit (not a squash). Merge #275 first, or rename one branch so the two form a delivery group.
mesh-admin merged commit 782aa9f737 into main 2026-10-12 20:22:44 +00:00
mesh-admin deleted branch fix/201-replay 2026-10-12 20:22:44 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
mesh-admin
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
jschoubben miel.truyen
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-lab#88