RemovedDeliveryVerbs leaves mesh-sdk for the seat mesh-delivery's client (ADR 0634 section 2, issue 1966)
Claude-Session: https://claude.ai/code/session_01NcbgfFSnn24M3GcqttoU7i
This commit is contained in:
@@ -1,19 +1,5 @@
|
|||||||
package catalogue
|
package catalogue
|
||||||
|
|
||||||
// DeliverySeat is the seat mesh-delivery holds.
|
|
||||||
|
|
||||||
// RemovedDeliveryVerbs are the delivery seat's verbs release 6 removed (novox/hq ADR 0539 clause 17): with no plan the
|
|
||||||
// gate keeps the merge's states and derives nothing after the merge. Each stays in deliveryVerbs as an optional row
|
|
||||||
// with no input, so the holder of before and the holder of release 6 both hold the seat and a caller is answered by
|
|
||||||
// name with its replacement, given here.
|
|
||||||
var RemovedDeliveryVerbs = map[string]string{
|
|
||||||
"times": "the delivery view (nox-delivery): each machine's want and have, and since when",
|
|
||||||
"what-if": "the merge check's composition, which composes every machine a change touches",
|
|
||||||
"release": "the assigner's asks (hold, restore, backup, record), answered on the phone or in the delivery view",
|
|
||||||
"stop": "a bad fingerprint is held and its canary set back by the assigner (ADR 0429 §6, ADR 0539 clause 18)",
|
|
||||||
"retire-history": "nothing to retire: the gate keeps no delivery after its merge",
|
|
||||||
}
|
|
||||||
|
|
||||||
// SeatSays is whether a consumed `<seat>.<event>` names one of the seat's own events: the seat emits it,
|
// SeatSays is whether a consumed `<seat>.<event>` names one of the seat's own events: the seat emits it,
|
||||||
// exactly or by one of its patterns (`log.*`). A consumed name whose emitter is a seat and whose event the
|
// exactly or by one of its patterns (`log.*`). A consumed name whose emitter is a seat and whose event the
|
||||||
// seat does not emit is the event of the module of that name (novox/hq ADR 0239): mesh-delivery is a seat
|
// seat does not emit is the event of the module of that name (novox/hq ADR 0239): mesh-delivery is a seat
|
||||||
|
|||||||
@@ -19,9 +19,9 @@ func TestTheDeliverySeatHasNoPlanVerbs(t *testing.T) {
|
|||||||
}
|
}
|
||||||
for _, name := range []string{"times", "what-if", "release", "stop", "retire-history"} {
|
for _, name := range []string{"times", "what-if", "release", "stop", "retire-history"} {
|
||||||
v, ok := rows[name]
|
v, ok := rows[name]
|
||||||
replacement, removed := RemovedDeliveryVerbs[name]
|
replacement := strings.TrimPrefix(v.Description, "Removed in R6 (ADR 0539): refused by name, naming its replacement: ")
|
||||||
if !ok || !removed || replacement == "" {
|
if !ok || replacement == "" || replacement == v.Description {
|
||||||
t.Errorf("%s: in the table %v, in the removed list %v", name, ok, removed)
|
t.Errorf("%s: in the table %v, replacement %q", name, ok, replacement)
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
if !strings.HasPrefix(v.Description, "Removed in R6 (ADR 0539): refused by name") || !strings.Contains(v.Description, replacement) || !v.Optional {
|
if !strings.HasPrefix(v.Description, "Removed in R6 (ADR 0539): refused by name") || !strings.Contains(v.Description, replacement) || !v.Optional {
|
||||||
|
|||||||
Reference in New Issue
Block a user