approval: the first views run before any seat list is read #197

Merged
mesh-tools merged 1 commits from fix/approval-first-view into main 2026-11-16 17:03:27 +00:00
Member

novox 2026-11-16 17:37-18:03: every catalog read refused ('the marks of ... are not read yet'): startRead looked only in the held seat list, itself read through mesh-catalog, so before the catalog half was ready no seat verb counted as a start read and a runner's own account (other runners' first views, the builder's reads) was refused. Now the foundation's bootstrapped definitions answer for seats the held list lacks. Test TestTheFirstViewsRunBeforeAnySeatListIsRead. Quick fix (not chosen): runner account in calledByModule; thorough (chosen): definitions known before any seat list. Second of a kind after A-433 (1182cad). Placed by hand as pack19 18:02 on novox and shanks; first views answered 18:02:57. Recovery mode: merged directly by lead-47@shanks.

novox 2026-11-16 17:37-18:03: every catalog read refused ('the marks of ... are not read yet'): startRead looked only in the held seat list, itself read through mesh-catalog, so before the catalog half was ready no seat verb counted as a start read and a runner's own account (other runners' first views, the builder's reads) was refused. Now the foundation's bootstrapped definitions answer for seats the held list lacks. Test TestTheFirstViewsRunBeforeAnySeatListIsRead. Quick fix (not chosen): runner account in calledByModule; thorough (chosen): definitions known before any seat list. Second of a kind after A-433 (1182cad). Placed by hand as pack19 18:02 on novox and shanks; first views answered 18:02:57. Recovery mode: merged directly by lead-47@shanks.
mesh-tools added 1 commit 2026-11-16 17:03:20 +00:00
Cause: startRead looked only in the definitions the runner holds. The seat list is itself read through the seat
mesh-catalog, so before the catalog half is ready the runner holds none, and every first view it waits on (its own
and another runner's, from any account) was refused with "marks not read yet" for ever.

Quick fix: let the one account that stalled through (calledByModule). Thorough fix (chosen): the foundation's bootstrapped
definitions answer for the seats they name wherever the held list lacks them, so a first view runs whoever asks; an act
of the same seat and a seat no definition names stay held.

Test: TestTheFirstViewsRunBeforeAnySeatListIsRead (fails without run.go change).

Builds: design 47 G A-387, A-388, A-433
mesh-tools merged commit 57f03e9f65 into main 2026-11-16 17:03:27 +00:00
mesh-tools deleted branch fix/approval-first-view 2026-11-16 17:03:28 +00:00
Author
Member

{
"records": [
{
"instance": "record/main_966_958d7704/711b77f8444c7d8b",
"sequence": 9286,
"bytes": 2428,
"of-bytes": 262144,
"waits": "its difference is not known yet",
"record": {
"milestone": "main.966",
"heads": {
"novox/mesh-delivery@225": "7c3b6211b0c874fe4406d51c409fbda677b87f8a",
"novox/mesh-delivery@226": "48ba977270675d41fc190c2b18700415ba4f4096",
"novox/mesh-delivery@227": "bfea3d36ad3281baba58b69459efb95bdb164865",
"novox/mesh-sdk@197": "57f03e9f650d464e8a4ab4044ee3116926306658"
},
"opened": "2026-11-16T18:53:26.48072318Z",
"form": 1,
"group": {
"group": "",
"members": [
"novox/mesh-delivery@227",
"novox/okioki@0"
],
"pulls": [
{
"repository": "novox/mesh-sdk",
"number": 197,
"head": "57f03e9f650d464e8a4ab4044ee3116926306658",
"state": "merged",
"commit": "57f03e9f650d464e8a4ab4044ee3116926306658",
"base": "main"
},
{
"repository": "novox/mesh-delivery",
"number": 225,
"head": "7c3b6211b0c874fe4406d51c409fbda677b87f8a",
"state": "merged",
"commit": "7c3b6211b0c874fe4406d51c409fbda677b87f8a",
"base": "main"
},
{
"repository": "novox/mesh-delivery",
"number": 226,
"head": "48ba977270675d41fc190c2b18700415ba4f4096",
"state": "merged",
"commit": "48ba977270675d41fc190c2b18700415ba4f4096",
"base": "main"
},
{
"repository": "novox/mesh-delivery",
"number": 227,
"head": "bfea3d36ad3281baba58b69459efb95bdb164865",
"state": "merged",
"commit": "bfea3d36ad3281baba58b69459efb95bdb164865",
"base": "main"
}
]
},
"entries": {
"mesh-delivery-assigner|src2:e7928b1dbf1942199741145b338a28c39bac3bff933a0a5d16b53885473ba6a6|": {
"key": "mesh-delivery-assigner|src2:e7928b1dbf1942199741145b338a28c39bac3bff933a0a5d16b53885473ba6a6|",
"module": "mesh-delivery-assigner",
"fingerprint": "src2:e7928b1dbf1942199741145b338a28c39bac3bff933a0a5d16b53885473ba6a6"
},
"mesh-delivery-builder|src2:0411855917bdac5b9664cfd946f75bbcc3a7aa93ec46b7552f632d22964204bc|": {
"key": "mesh-delivery-builder|src2:0411855917bdac5b9664cfd946f75bbcc3a7aa93ec46b7552f632d22964204bc|",
"module": "mesh-delivery-builder",
"fingerprint": "src2:0411855917bdac5b9664cfd946f75bbcc3a7aa93ec46b7552f632d22964204bc"
},
"okioki|src2:d0d697df3f1086bacccab10999c0a3471ee915c06a326a8b717e4afc97d6a6b6|": {
"key": "okioki|src2:d0d697df3f1086bacccab10999c0a3471ee915c06a326a8b717e4afc97d6a6b6|",
"module": "okioki",
"fingerprint": "src2:d0d697df3f1086bacccab10999c0a3471ee915c06a326a8b717e4afc97d6a6b6"
}
},
"outcomes": {
"|||take-in": {
"key": "|||take-in",
"module": "",
"step": "take-in",
"outcome": "taken-in",
"why": "lead-47@shanks, operator's go 2026-11-16 ~19:53: indexer build 25425b20 is never composed on novox; the 4 merges (mesh-sdk #197, mesh-delivery #225-#227) do not change how the catalog is computed",
"at": "2026-11-16T18:53:26.477209807Z"
}
}
}
}
]
}

<!-- mesh-delivery:view --> { "records": [ { "instance": "record/main_966_958d7704/711b77f8444c7d8b", "sequence": 9286, "bytes": 2428, "of-bytes": 262144, "waits": "its difference is not known yet", "record": { "milestone": "main.966", "heads": { "novox/mesh-delivery@225": "7c3b6211b0c874fe4406d51c409fbda677b87f8a", "novox/mesh-delivery@226": "48ba977270675d41fc190c2b18700415ba4f4096", "novox/mesh-delivery@227": "bfea3d36ad3281baba58b69459efb95bdb164865", "novox/mesh-sdk@197": "57f03e9f650d464e8a4ab4044ee3116926306658" }, "opened": "2026-11-16T18:53:26.48072318Z", "form": 1, "group": { "group": "", "members": [ "novox/mesh-delivery@227", "novox/okioki@0" ], "pulls": [ { "repository": "novox/mesh-sdk", "number": 197, "head": "57f03e9f650d464e8a4ab4044ee3116926306658", "state": "merged", "commit": "57f03e9f650d464e8a4ab4044ee3116926306658", "base": "main" }, { "repository": "novox/mesh-delivery", "number": 225, "head": "7c3b6211b0c874fe4406d51c409fbda677b87f8a", "state": "merged", "commit": "7c3b6211b0c874fe4406d51c409fbda677b87f8a", "base": "main" }, { "repository": "novox/mesh-delivery", "number": 226, "head": "48ba977270675d41fc190c2b18700415ba4f4096", "state": "merged", "commit": "48ba977270675d41fc190c2b18700415ba4f4096", "base": "main" }, { "repository": "novox/mesh-delivery", "number": 227, "head": "bfea3d36ad3281baba58b69459efb95bdb164865", "state": "merged", "commit": "bfea3d36ad3281baba58b69459efb95bdb164865", "base": "main" } ] }, "entries": { "mesh-delivery-assigner|src2:e7928b1dbf1942199741145b338a28c39bac3bff933a0a5d16b53885473ba6a6|": { "key": "mesh-delivery-assigner|src2:e7928b1dbf1942199741145b338a28c39bac3bff933a0a5d16b53885473ba6a6|", "module": "mesh-delivery-assigner", "fingerprint": "src2:e7928b1dbf1942199741145b338a28c39bac3bff933a0a5d16b53885473ba6a6" }, "mesh-delivery-builder|src2:0411855917bdac5b9664cfd946f75bbcc3a7aa93ec46b7552f632d22964204bc|": { "key": "mesh-delivery-builder|src2:0411855917bdac5b9664cfd946f75bbcc3a7aa93ec46b7552f632d22964204bc|", "module": "mesh-delivery-builder", "fingerprint": "src2:0411855917bdac5b9664cfd946f75bbcc3a7aa93ec46b7552f632d22964204bc" }, "okioki|src2:d0d697df3f1086bacccab10999c0a3471ee915c06a326a8b717e4afc97d6a6b6|": { "key": "okioki|src2:d0d697df3f1086bacccab10999c0a3471ee915c06a326a8b717e4afc97d6a6b6|", "module": "okioki", "fingerprint": "src2:d0d697df3f1086bacccab10999c0a3471ee915c06a326a8b717e4afc97d6a6b6" } }, "outcomes": { "|||take-in": { "key": "|||take-in", "module": "", "step": "take-in", "outcome": "taken-in", "why": "lead-47@shanks, operator's go 2026-11-16 ~19:53: indexer build 25425b20 is never composed on novox; the 4 merges (mesh-sdk #197, mesh-delivery #225-#227) do not change how the catalog is computed", "at": "2026-11-16T18:53:26.477209807Z" } } } } ] } <!-- mesh-act:view.record/main_966_958d7704/711b77f8444c7d8b.novox/mesh-sdk#197@1794855219014003871.78a10b37 -->
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-sdk#197