Nodes compose: placement, node records and one composer input for three callers (issue 1126) #98

Merged

mesh-tools merged 29 commits from feat/1126-nodes-compose into main 2026-10-26 21:11:06 +00:00

Conversation 1 Commits 29 Files Changed 26

+2480 -37

mesh-tools commented 2026-10-26 17:34:51 +00:00

Member

Copy Link

Copy Source

Milestone L2 "nodes compose" (issue 1126; ADR 0547 §2, §3; ADR 0549; ADR 0555). Member of the delivery group feat/1126-nodes-compose, which the milestone's one review approved; merged with main at 7187beaf (#101), taking main's test/standing.test.ts and test/retire.test.ts.

• delivery/placement.go: the catalogue's placement file and the indexer's key placement.<node> (ADR 0549 §1, §2): the node's decided facts (endpoint, site, hub, address, public domain, accounts, adoption, the tunnel found at adoption, the hub's peer names; ADR 0555), its modules in order with host ports, bindings and config placement as two layers (mesh-wide and layer, with has-layer), pins and holdings; CheckPlacements refuses clashes, unplaced providers, a mesh seat held twice, one address on two nodes and a second hub.
• delivery/noderecord.go: what the machine observes, riding in HaveNode.Record of its own have key <node>.node (ADR 0555 §3).
• compose/frombus: fills compose.Input from placement, records, the indexer's manifests and mesh-config's slice; one composer for the node agent, the composition check and the grants part.
• delivery/judge.go: the judgement of a move as a pure function (ADR 0547 §3), moved from the controller's composed_judge.go.
• A merged message of the catalogue carries its placement files (Forge.Placements).
• buscompose: node principals read every node's <node>.node. The copy diverges from the controller's on purpose by that read only; the test holds it to every controller grant plus exactly that.

Test budget: no net new test function (four folded into existing ones).

Reviewed-by: review-1126@shanks at 9796444201

Milestone L2 "nodes compose" (issue 1126; ADR 0547 §2, §3; ADR 0549; ADR 0555). Member of the delivery group feat/1126-nodes-compose, which the milestone's one review approved; merged with main at 7187beaf (#101), taking main's test/standing.test.ts and test/retire.test.ts. - `delivery/placement.go`: the catalogue's placement file and the indexer's key `placement.<node>` (ADR 0549 §1, §2): the node's decided facts (endpoint, site, hub, address, public domain, accounts, adoption, the tunnel found at adoption, the hub's peer names; ADR 0555), its modules in order with host ports, bindings and **config placement as two layers** (`mesh-wide` and `layer`, with `has-layer`), pins and holdings; `CheckPlacements` refuses clashes, unplaced providers, a mesh seat held twice, one address on two nodes and a second hub. - `delivery/noderecord.go`: what the machine observes, riding in `HaveNode.Record` of its own have key `<node>.node` (ADR 0555 §3). - `compose/frombus`: fills `compose.Input` from placement, records, the indexer's manifests and mesh-config's slice; one composer for the node agent, the composition check and the grants part. - `delivery/judge.go`: the judgement of a move as a pure function (ADR 0547 §3), moved from the controller's composed_judge.go. - A merged message of the catalogue carries its placement files (`Forge.Placements`). - `buscompose`: node principals read every node's `<node>.node`. The copy diverges from the controller's on purpose by that read only; the test holds it to every controller grant plus exactly that. Test budget: no net new test function (four folded into existing ones). Reviewed-by: review-1126@shanks at 979644420117d8d48c7228fc06a51a92a1dc5279

mesh-tools added 9 commits 2026-10-26 17:34:51 +00:00

Placement and the node record have one layout in mesh-sdk, so the indexer, the node agents and the composition check read them alike (issue 1126, ADR 0549 §1-§2, ADR 0547 §2) 146cd858a3

frombus fills the composition's input from placement, node records, the indexer's manifests and mesh-config's slice, so one composer serves the node agent, the check and the grants part (issue 1126, ADR 0547 §2, ADR 0549 §3) e982072443

The judgement of a move is a pure function in mesh-sdk, so a node agent judges what it composed against what it runs (issue 1126, ADR 0547 §3, ADR 0377 §3) bdd4c7b875

A merged message of the catalogue carries its placement files, so the indexer reads placement at the merge without asking the forge again (issue 1126, ADR 0549 §2) 9f7f50de8d

Name the catalogue repository whose placement files are read (issue 1126, ADR 0549 §1) 5db53e738f

What a person decides of a node lives in its placement file and what the machine observes in its record; two nodes on one address or two hubs are refused (issue 1126, K2) a431746c0e

The tunnel found at adoption and the names of the hub's peers are kept in the placement; whether the hub took it over and who enrolled under a peer's key are read from placement and records, as the controller reads them (issue 1126, ADR 0555) 5b1e990eb4

A node's record rides in its own have key, <node>.node: no bucket, writer or grant of its own, and its key's change is what readers hear (issue 1126, ADR 0555 §3) 2b0689f654

Node principals read every node's own facts, where its record rides; the composer copy is checked to grant all the controller's grants and only that and the issue 1790 rows more (issue 1126, ADR 0555 §3) 9789c8379a

mesh-tools commented 2026-10-26 17:34:55 +00:00

Author

Member

Copy Link

Copy Source

Delivery novox/mesh-sdk@979644420117 — merged since 2026-10-26T21:11:09Z

Source — source.main moved to novox/mesh-sdk@823d52051f. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group feat/1126-nodes-compose: novox/hq@28d84f31bf, novox/mesh-catalog@c085975146, novox/mesh-controller@df8ebf6a77, novox/mesh-delivery@297992a4ae, novox/mesh-host@1d44288514, novox/mesh-sdk@9796444201

Transitions

• 2026-10-26 21:09 (new) → proposed (announced): novox/mesh-sdk#98's head announced
• 2026-10-26 21:10 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
• 2026-10-26 21:11 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-sdk@979644420117` — **merged** since 2026-10-26T21:11:09Z **Source** — source.main moved to novox/mesh-sdk@823d52051f03. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `feat/1126-nodes-compose`: novox/hq@28d84f31bfcb, novox/mesh-catalog@c0859751461a, novox/mesh-controller@df8ebf6a77c1, novox/mesh-delivery@297992a4ae55, novox/mesh-host@1d442885148a, novox/mesh-sdk@979644420117 **Transitions** - 2026-10-26 21:09 (new) → proposed (announced): novox/mesh-sdk#98's head announced - 2026-10-26 21:10 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-26 21:11 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

jschoubben added 3 commits 2026-10-26 17:44:26 +00:00

A want names the build alone from the second milestone, and the yes a person gave; a have waits for that yes with its judgement (issue 1126, ADR 0547 §2, §3) e49309d61c

A node's own want names no composition from the second milestone: the node composes its own (issue 1126, ADR 0547 §2) 9532b78724

Node principals read what they compose their own modules from; the composer copy is held per user to the controller's grants plus exactly these (issue 1126, ADR 0547 §2, ADR 0549 §3) 6df0dfe208

jschoubben added 2 commits 2026-10-26 18:04:42 +00:00

A node applying what it composed refuses a composition that stands in for anything its input lacks, the bus's user list alone held out (issue 1126, ADR 0547 §2) b72de2b75a

frombus reads the composing node's own secrets sealed to it, and node principals may ask the vault's own in their own name (issue 1126, ADR 0550 §5) f1d7c7377d

jschoubben added 1 commit 2026-10-26 18:11:38 +00:00

frombus exports a node's placement from a composition input, Input's inverse for what a person decides, and the controller's seat declares placement-export (issue 1126, ADR 0555 §6) dfe3ba9475

jschoubben added 1 commit 2026-10-26 18:13:58 +00:00

A want the node composes itself says so (Self) and names the build alone; every other want names its composition as before, so no caller of the old form changes (issue 1126, ADR 0547 §2) 4d5f430224

jschoubben added 1 commit 2026-10-26 18:17:48 +00:00

placement-seed writes each node's first placement file from the controller's export, checked before anything is written, once (issue 1126, ADR 0549 §4, ADR 0555 §6) 6447a1c6d4

jschoubben added 1 commit 2026-10-26 18:18:49 +00:00

compose names the pair credentials a node's composition reads as consumer and provider, and frombus asks them sealed before it composes (issue 1126, ADR 0550 §5) 91413de335

jschoubben added 2 commits 2026-10-26 18:23:08 +00:00

frombus gives the composing node's core credentials as the vault's boxes sealed to it, from the same own secrets (issue 1126, ADR 0349 §16, ADR 0550 §5) 7d81e8326f

A node's record carries the mesh's own certificate as the machine holds it, and frombus composes with the composing node's (issue 1126, ADR 0555 §3) 944a35d200

jschoubben added 1 commit 2026-10-26 18:25:12 +00:00

A node composing its own hears the vault's secret-changed, names and generations only (issue 1126, ADR 0547 §2) f55b34febc

jschoubben added 1 commit 2026-10-26 18:25:22 +00:00

VaultSecretChanged is a variable (its seat is), and gofmt (issue 1126) 53c2def1a5

jschoubben added 1 commit 2026-10-26 18:38:40 +00:00

Placement carries a settings-form module's config values, which mesh-config does not hold, and the export writes them (issue 1126, ADR 0555 §1): the media modules on one node would compose without them 9713c3023a

jschoubben added 1 commit 2026-10-26 19:08:35 +00:00

Review of L2: the export is a placement file at its version with its modules (S1); a node asks the vault only when a module placed on it declares an own secret, so one with none composes whether or not the vault answers (H8's failure) (issue 1126) 3968849b1b

jschoubben added 1 commit 2026-10-26 19:19:57 +00:00

A have carries the values a self-composing node's running composition holds sealed to its key, so its composer reuses them after a restart (review of L2, round 2; issue 1126, ADR 0547 §3) 2c0ab3a592

jschoubben added 1 commit 2026-10-26 19:20:15 +00:00

Compare haves with SameHave in the round-trip tests, now that a have carries a list (issue 1126) dd9d9d5b5f

jschoubben added 1 commit 2026-10-26 19:33:25 +00:00

The standing test keeps c failing alone after its ask is dropped, so its only recovery is its retirement: clearing every failure at once raced the loop's read of the new list under load (issue 1126; the hidden failure of try-1793042418286545971, issue 1901) 03dce12378

mesh-tools marked the pull request as ready for review 2026-10-26 21:09:16 +00:00

jschoubben added 2 commits 2026-10-26 21:09:55 +00:00

Merge remote-tracking branch 'origin/main' into feat/1126-nodes-compose 5f45175ed0

Merge remote-tracking branch 'origin/main' into feat/1126-nodes-compose ... 9796444201

# Conflicts:
#	test/standing.test.ts

mesh-tools merged commit 823d52051f into main 2026-10-26 21:11:06 +00:00

mesh-tools deleted branch feat/1126-nodes-compose 2026-10-26 21:11:07 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

mesh/ready

Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-sdk#98