A held module offers what it runs, and its hold no longer spreads to the modules that read from it (issue 1960) #131

Merged

mesh-tools merged 1 commits from fix/1960-no-hold-spread into main 2026-10-29 15:35:25 +00:00

Conversation 2 Commits 1 Files Changed 3

+211 -202

1 Commits

Author	SHA1	Message	Date
jschoubben	dbcaa29a1a	Never hold a module because a module it reads from is held: it composes with what the held one last offered (issue 1960) ... On novox on 2026-10-29 de-spiegel, held for an unset config value, held mailu, route-proxy and nftables ("it reads what de-spiegel contributes or listens on"), and mailu held postgres. mesh-sdk #128 (issue 1126) stopped the hold spreading to consumers and collectors but kept dependents(): the provider of what a held module contributes to, and the filter where it listens, were held behind it, transitively. - Quick fix: drop dependents() alone. The filter and the proxy would then read a held module's new manifest, which may not be what runs (review of the apply, round 2). - Thorough fix, chosen: no module is held behind another, in the apply and in the answer (dependents, heldBehind and the held-behind path of heldAsToday removed). A held module offers what it last offered: its contributions and listens from its manifest at the build its own composition runs at (ranOf), else the manifest it is composed from. Only the part of its offer that does not compose is left out, by provision (culprit): de-spiegel's routes leave route-proxy without them, while mailu keeps its smtp account; the hold names it. Tests: rows changed in the existing answer test (de-spiegel held, mailu and proxy composed; site held, the filter composed with what runs; leave-out by provision). No new test function.	2026-10-29 15:54:21 +01:00