A build not done yet holds its module, never every module of a node, and a refusal names what was held (issue 774) #140

Merged

jschoubben merged 3 commits from fix/build-not-done-holds-one-module into main 2026-10-30 18:53:04 +00:00

Conversation 1 Commits 3 Files Changed 4

+196 -12

3 Commits

Author	SHA1	Message	Date
jschoubben	9685990a15	Compose a module at the build its want names and hold a running one whose build is not done, so the runtime never loses its bundle (issue 774) ... At 19:30 on 2026-10-30 node-tools' trunk fingerprint moved to a build not yet done; fromBuilds then composed it from the indexer's manifest, which names no bundle, and ace, g14 and shanks refused every module ("its build produced 0 bundle(s)") until another input moved after the build landed. Quick fix: skip the runtime's check while its build is not done. Thorough fix: Compose reads each placed module at the build its want names (as Scope.KeptAt), and a module that runs whose build is not done is held, keeping what runs (a held runtime is composed as what runs of it, its running bundle), named with why; a module nothing runs of still composes from the indexer's manifest as before. Input, PlansHeld and Answer read the trunk's builds as before. Chose thorough: no running module is ever composed from a source manifest that names no build.	2026-10-30 19:45:32 +01:00
jschoubben	d539d7e4eb	Take the runtime as a culprit only where its stub composes, so node-tools is never held for an error that names it (issue 774) ... The culprit rule held a module whose stub made the composition fail otherwise. The runtime's stub carries no bundle, so it always fails otherwise: any refusal naming node-tools (or a module whose name holds it) held the runtime, and the node was then refused whole for the runtime's "0 bundle(s)". Quick fix: never take node-tools as a culprit. Thorough fix: blames, the rule as one function, takes the runtime only where its stub composes. Chose thorough: a runtime whose stub composes may still be held alone.	2026-10-30 19:44:08 +01:00
jschoubben	c1bc21c35f	Say what a node held on the way when it is refused whole, so a held module's own refusal is never hidden (issue 774) ... At 19:30 on 2026-10-30 ace, g14 and shanks refused every module with "node-tools … its build produced 0 bundle(s)": the refusal of node-tools' stand-in, while why node-tools could not be composed was dropped with the hold. Quick fix: log held in mesh-host before marking. Thorough fix: Compose's node-wide error carries "(held before: <module>: <why>; …)", so the engine's journal, every have's detail and any caller see the cause. Chose thorough.	2026-10-30 19:43:46 +01:00