novox/mesh-sdk
9
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

A check ask runs every level and every package after a failure, so one check names every failure (ADR 0591) #160

Closed
mesh-tools wants to merge 1 commits from fix/check-every-failure into main
pull from: fix/check-every-failure
merge into: :main
Conversation 2 Commits 1 Files Changed 4
+39 -48
mesh-tools commented 2026-11-02 15:34:13 +00:00
Member
Copy Link
Copy Source

Delivery group fix/check-every-failure: mesh-sdk, mesh-catalog, mesh-delivery. ADR 0591 (accepted on the operator's Approve, 2026-11-02): a failed check runs to its end and names every failure; it changes ADR 0444 §4 and ADR 0484 §13. Here: buildstep/askrun.go runs every level and every package after a failure; the change's own tests still run first. Issue 1921 (note 35).

Tests: the level test asserts later levels run after a failure (written first); the whole suite offline; vet both tags.

Reviewed-by: review-1126@shanks at 43788bbfde

https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL

Delivery group fix/check-every-failure: mesh-sdk, mesh-catalog, mesh-delivery. ADR 0591 (accepted on the operator's Approve, 2026-11-02): a failed check runs to its end and names every failure; it changes ADR 0444 §4 and ADR 0484 §13. Here: buildstep/askrun.go runs every level and every package after a failure; the change's own tests still run first. Issue 1921 (note 35). Tests: the level test asserts later levels run after a failure (written first); the whole suite offline; vet both tags. Reviewed-by: review-1126@shanks at 43788bbfdef31adaff8987d03b0e7e3e3fa30965 https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL
mesh-tools added 1 commit 2026-11-02 15:34:13 +00:00
buildstep: a check ask runs every level and every package after a failure, so one check names every failure
mesh/delivery-group group fix/check-every-failure checking: 3 of 3 member(s) ready
Details
mesh/delivery closed: the pull request closed unmerged
Details
mesh/check checking 43788bbfdef3 on d6c87ee1a7ae | novox/mesh-sdk#160 in group fix/check-every-failure
43788bbfde 
The operator, 2026-11-02: a failed check showed only its first fault; a group's three faults took three runs.
The change's own packages still run first (issue 1289), and nothing after them is skipped.

Claude-Session: https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL
mesh-tools commented 2026-11-02 15:34:21 +00:00
Author
Member
Copy Link
Copy Source

Delivery novox/mesh-sdk@43788bbfdef3 — closed since 2026-11-02T16:07:21Z

Group fix/check-every-failure: novox/mesh-catalog@831f34e59a, novox/mesh-delivery@b55a735a97

Transitions

  • 2026-11-02 15:34 (new) → proposed (announced): novox/mesh-sdk#160's head announced
  • 2026-11-02 15:34 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-11-02 16:07 ready → closed (closed): the pull request closed unmerged

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-sdk@43788bbfdef3` — **closed** since 2026-11-02T16:07:21Z **Group** `fix/check-every-failure`: novox/mesh-catalog@831f34e59ac7, novox/mesh-delivery@b55a735a97e0 **Transitions** - 2026-11-02 15:34 (new) → proposed (announced): novox/mesh-sdk#160's head announced - 2026-11-02 15:34 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-02 16:07 ready → closed (closed): the pull request closed unmerged The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
mesh-tools commented 2026-11-02 16:01:34 +00:00
Author
Member
Copy Link
Copy Source

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.
mesh-tools closed this pull request 2026-11-02 16:07:20 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
mesh/ready
Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-sdk#160