The builder builds a retakeable failure again by itself: the retake class and its count (issue 1748) #168

2026-11-04T21:46:27Z

mesh-tools commented

2026-11-04 21:46:27 +00:00

Issue 1748: a build that fails on a network lookup is built again by itself.

Until now the builder never built such a failure again: "may be retaken" was only wording in mesh-build-go's error. Tonight's lookup pauses on shanks left mesh-build-image and mesh-build-node failed until someone built them again by hand. The registry group's delivery will start about 300 builds and would meet the same pauses.

Delivery group fix/1748-retake-and-resolver, merged together:

mesh-sdk (go/delivery/builder.go): Retake, Retakeable() and MaxRetakes (3) beside FailedUntilChanged; a Retakes count on the build key and on the build's log entry (read by builder_builds_since).
mesh-delivery (mesh-delivery-builder): after a key is written failed with a retakeable error, armRetake takes it again after 60 s, then 120 s, then 240 s. Only that claim counts toward the cap, and Sweep re-arms from the key's count after a restart. The journal says each retake with its count. A compile error or a FailedUntilChanged error is never retaken, and the retake prefix is added only when every failing lane is retakeable.
mesh-catalog (mesh-build-go): a network failure of the fetch opens with the retake prefix. An unknown revision, a compile error or a failing test does not.

Acceptance criteria: issue 1748 note 14. AC5 (dnsmasq) was withdrawn in review (note 18): dnsmasq logs when it reaches its cap, and no such line was seen, so the cap was not the cause.

Rules bent, said here:

Playbook 08's one-repository bound: the mesh-sdk part is one exported name and one field.
ADR 0437 §8 (no timers in the builder): the backoff waits on a context's bound. The guard in manifest_test.go names armRetake as the one allowed bounded wait (issue 1748) and refuses any other. A bus delivery delay is a follow-up (issue 1748 note 16).
Test budget: mesh-sdk adds no test function. mesh-delivery adds one top-level unit function with five subtests, and its integration count stays at 71 (AC6 is a subtest of the existing failed-key test).

Integration test run locally by name against an embedded bus: TestAFailedKeyIsBuiltAgainAsANewRevisionFromANewModulesValueWithTheSameFingerprint (with the AC6 subtest): pass.

Review: review-1748@shanks approved round 2 at mesh-sdk 0d97c09c49, mesh-delivery 1d9ac0c8da9c74edc51c1e7d9d0630c3c087681e, mesh-catalog 82aaae846ea9c535d34465a90e902e5d9f773338; the only commit after them is the pin of mesh-sdk 0d97c09c (go.mod and go.sum), in mesh-delivery ab253515 and mesh-catalog 06cdac97.
Reviewed-by: review-1748@shanks at 0d97c09c49
Pushed-by: fix-1965@shanks

https://claude.ai/code/session_01JG73KJNrH5EgFXMKKYSrig

Issue 1748: a build that fails on a network lookup is built again by itself. Until now the builder never built such a failure again: "may be retaken" was only wording in mesh-build-go's error. Tonight's lookup pauses on shanks left mesh-build-image and mesh-build-node failed until someone built them again by hand. The registry group's delivery will start about 300 builds and would meet the same pauses. Delivery group `fix/1748-retake-and-resolver`, merged together: - **mesh-sdk** (go/delivery/builder.go): `Retake`, `Retakeable()` and `MaxRetakes` (3) beside `FailedUntilChanged`; a `Retakes` count on the build key and on the build's log entry (read by `builder_builds_since`). - **mesh-delivery** (mesh-delivery-builder): after a key is written failed with a retakeable error, `armRetake` takes it again after 60 s, then 120 s, then 240 s. Only that claim counts toward the cap, and `Sweep` re-arms from the key's count after a restart. The journal says each retake with its count. A compile error or a `FailedUntilChanged` error is never retaken, and the retake prefix is added only when every failing lane is retakeable. - **mesh-catalog** (mesh-build-go): a network failure of the fetch opens with the retake prefix. An unknown revision, a compile error or a failing test does not. Acceptance criteria: issue 1748 note 14. AC5 (dnsmasq) was withdrawn in review (note 18): dnsmasq logs when it reaches its cap, and no such line was seen, so the cap was not the cause. Rules bent, said here: - Playbook 08's one-repository bound: the mesh-sdk part is one exported name and one field. - ADR 0437 §8 (no timers in the builder): the backoff waits on a context's bound. The guard in manifest_test.go names `armRetake` as the one allowed bounded wait (issue 1748) and refuses any other. A bus delivery delay is a follow-up (issue 1748 note 16). - Test budget: mesh-sdk adds no test function. mesh-delivery adds one top-level unit function with five subtests, and its integration count stays at 71 (AC6 is a subtest of the existing failed-key test). Integration test run locally by name against an embedded bus: `TestAFailedKeyIsBuiltAgainAsANewRevisionFromANewModulesValueWithTheSameFingerprint` (with the AC6 subtest): pass. Review: review-1748@shanks approved round 2 at mesh-sdk 0d97c09c49b4a583ce51d76b29310581987aaf02, mesh-delivery 1d9ac0c8da9c74edc51c1e7d9d0630c3c087681e, mesh-catalog 82aaae846ea9c535d34465a90e902e5d9f773338; the only commit after them is the pin of mesh-sdk 0d97c09c (go.mod and go.sum), in mesh-delivery ab253515 and mesh-catalog 06cdac97. Reviewed-by: review-1748@shanks at 0d97c09c49b4a583ce51d76b29310581987aaf02 Pushed-by: fix-1965@shanks https://claude.ai/code/session_01JG73KJNrH5EgFXMKKYSrig

mesh-tools added 3 commits 2026-11-04 21:46:27 +00:00

Add the retake class beside FailedUntilChanged and the retake count on a build key (issue 1748) 0261881feb

A network failure passes by itself; the build contract names it so every build module is held to it and the builder acts on it.

Claude-Session: https://claude.ai/code/session_01JG73KJNrH5EgFXMKKYSrig

A build's log entry says how many times its key was retaken (issue 1748) 9c4b2c5e56

Claude-Session: https://claude.ai/code/session_01JG73KJNrH5EgFXMKKYSrig

Fold the retake test into the prefix test (issue 1748 review 1)

mesh/delivery-group group fix/1748-retake-and-resolver ready: every member ready, and composed together they pass

Details

mesh/delivery closed: the pull request closed unmerged

Details

mesh/check pass 0d97c09c49b4 on 5a38a1221659 | unit 6409 run, 187 kept, 14 skipped | integration 6544 run, 220 kept, 23 skipped | over bound: unit, in…

0d97c09c49

Claude-Session: https://claude.ai/code/session_01JG73KJNrH5EgFXMKKYSrig

mesh-tools commented

2026-11-04 21:46:32 +00:00

Delivery novox/mesh-sdk@0d97c09c49b4 — closed since 2026-11-04T22:24:01Z

Group fix/1748-retake-and-resolver: novox/mesh-catalog@06cdac97e3, novox/mesh-delivery@ab2535158a

Transitions

2026-11-04 21:46 (new) → proposed (announced): novox/mesh-sdk#168's head announced
2026-11-04 21:46 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-11-04 22:24 ready → closed (closed): the pull request closed unmerged

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-sdk@0d97c09c49b4` — **closed** since 2026-11-04T22:24:01Z **Group** `fix/1748-retake-and-resolver`: novox/mesh-catalog@06cdac97e32c, novox/mesh-delivery@ab2535158a45 **Transitions** - 2026-11-04 21:46 (new) → proposed (announced): novox/mesh-sdk#168's head announced - 2026-11-04 21:46 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-04 22:24 ready → closed (closed): the pull request closed unmerged The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools commented

2026-11-04 22:23:23 +00:00

mesh-delivery: not merged. The merge of this pull request into main at 0d97c09c49 was declined: the operator, via telegram (user id verified), chose Decline. A new head asks the operator again.

mesh-delivery: **not merged.** The merge of this pull request into main at 0d97c09c49b4a583ce51d76b29310581987aaf02 was declined: the operator, via telegram (user id verified), chose Decline. A new head asks the operator again.

mesh-tools closed this pull request

2026-11-04 22:23:59 +00:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-sdk#168