approval: test table as gofmt writes it (unblocks the sdk's lint step) #199

Merged
mesh-tools merged 1 commits from fix/gofmt-approval-test into main 2026-11-19 12:23:25 +00:00
Member

The pipeline main.1014.mesh-sdk (61548a07, #198) failed its lint step on 2026-11-18: "go gofmt: not as gofmt writes them: go/approval/approval_test.go". So #198's sdk version (catalogue TemplatesDigest) was never published, and every module built against the latest published sdk that uses it fails to compile in its pipeline (mesh-host main.1024: m.TemplatesDigest undefined).

Only whitespace: gofmt -w go/approval/approval_test.go; gofmt -l is empty, go test ./approval/ passes.

Quick fix (this) vs thorough: the thorough fix is a gofmt check before a commit can reach main; the pipeline's lint step already is that check, it ran after the merge. Noted, not built here.

https://claude.ai/code/session_01JG73KHUnBze48rdua8u2sy

The pipeline main.1014.mesh-sdk (61548a07, #198) failed its lint step on 2026-11-18: "go gofmt: not as gofmt writes them: go/approval/approval_test.go". So #198's sdk version (catalogue `TemplatesDigest`) was never published, and every module built against the latest published sdk that uses it fails to compile in its pipeline (mesh-host main.1024: `m.TemplatesDigest undefined`). Only whitespace: `gofmt -w go/approval/approval_test.go`; `gofmt -l` is empty, `go test ./approval/` passes. Quick fix (this) vs thorough: the thorough fix is a gofmt check before a commit can reach main; the pipeline's lint step already is that check, it ran after the merge. Noted, not built here. https://claude.ai/code/session_01JG73KHUnBze48rdua8u2sy
mesh-tools added 1 commit 2026-11-19 11:06:24 +00:00
mesh-tools merged commit bee9aa6e1c into main 2026-11-19 12:23:25 +00:00
mesh-tools deleted branch fix/gofmt-approval-test 2026-11-19 12:23:25 +00:00
Author
Member

{
"records": [
{
"instance": "record/main_1028_f73997fa/a2bb48de34069746",
"sequence": 10209,
"bytes": 1389,
"of-bytes": 262144,
"waits": "its difference is not known yet",
"record": {
"milestone": "main.1028",
"heads": {
"novox/mesh-sdk@199": "bee9aa6e1c61573cf4efc24a9c0bc14435486600"
},
"opened": "2026-11-19T12:23:41.792287331Z",
"form": 1,
"group": {
"group": "",
"members": [
"novox/mesh-media-catalog@0",
"novox/mesh-sdk@199"
],
"pulls": [
{
"repository": "novox/mesh-sdk",
"number": 199,
"head": "bee9aa6e1c61573cf4efc24a9c0bc14435486600",
"state": "merged",
"commit": "bee9aa6e1c61573cf4efc24a9c0bc14435486600",
"base": "main"
}
]
},
"entries": {
"lidarr|src2:8ffc4c1cf86c19e0eaee537698228685b2453ad677c29ed48de97c685ba02d68|": {
"key": "lidarr|src2:8ffc4c1cf86c19e0eaee537698228685b2453ad677c29ed48de97c685ba02d68|",
"module": "lidarr",
"fingerprint": "src2:8ffc4c1cf86c19e0eaee537698228685b2453ad677c29ed48de97c685ba02d68"
},
"mesh-sdk|src2:864bcf0852eb4f145af445aec143e435cc6423f01805dc5bf68b159f965ce68e|": {
"key": "mesh-sdk|src2:864bcf0852eb4f145af445aec143e435cc6423f01805dc5bf68b159f965ce68e|",
"module": "mesh-sdk",
"fingerprint": "src2:864bcf0852eb4f145af445aec143e435cc6423f01805dc5bf68b159f965ce68e"
},
"radarr|src2:b29277c353aed2385d20b47a04f35a2e909af3991c2522f270cf134ab11d40a5|": {
"key": "radarr|src2:b29277c353aed2385d20b47a04f35a2e909af3991c2522f270cf134ab11d40a5|",
"module": "radarr",
"fingerprint": "src2:b29277c353aed2385d20b47a04f35a2e909af3991c2522f270cf134ab11d40a5"
}
},
"outcomes": {
"|||take-in": {
"key": "|||take-in",
"module": "",
"step": "take-in",
"outcome": "taken-in",
"at": "2026-11-19T12:23:41.79117154Z"
}
}
}
}
]
}

<!-- mesh-delivery:view --> { "records": [ { "instance": "record/main_1028_f73997fa/a2bb48de34069746", "sequence": 10209, "bytes": 1389, "of-bytes": 262144, "waits": "its difference is not known yet", "record": { "milestone": "main.1028", "heads": { "novox/mesh-sdk@199": "bee9aa6e1c61573cf4efc24a9c0bc14435486600" }, "opened": "2026-11-19T12:23:41.792287331Z", "form": 1, "group": { "group": "", "members": [ "novox/mesh-media-catalog@0", "novox/mesh-sdk@199" ], "pulls": [ { "repository": "novox/mesh-sdk", "number": 199, "head": "bee9aa6e1c61573cf4efc24a9c0bc14435486600", "state": "merged", "commit": "bee9aa6e1c61573cf4efc24a9c0bc14435486600", "base": "main" } ] }, "entries": { "lidarr|src2:8ffc4c1cf86c19e0eaee537698228685b2453ad677c29ed48de97c685ba02d68|": { "key": "lidarr|src2:8ffc4c1cf86c19e0eaee537698228685b2453ad677c29ed48de97c685ba02d68|", "module": "lidarr", "fingerprint": "src2:8ffc4c1cf86c19e0eaee537698228685b2453ad677c29ed48de97c685ba02d68" }, "mesh-sdk|src2:864bcf0852eb4f145af445aec143e435cc6423f01805dc5bf68b159f965ce68e|": { "key": "mesh-sdk|src2:864bcf0852eb4f145af445aec143e435cc6423f01805dc5bf68b159f965ce68e|", "module": "mesh-sdk", "fingerprint": "src2:864bcf0852eb4f145af445aec143e435cc6423f01805dc5bf68b159f965ce68e" }, "radarr|src2:b29277c353aed2385d20b47a04f35a2e909af3991c2522f270cf134ab11d40a5|": { "key": "radarr|src2:b29277c353aed2385d20b47a04f35a2e909af3991c2522f270cf134ab11d40a5|", "module": "radarr", "fingerprint": "src2:b29277c353aed2385d20b47a04f35a2e909af3991c2522f270cf134ab11d40a5" } }, "outcomes": { "|||take-in": { "key": "|||take-in", "module": "", "step": "take-in", "outcome": "taken-in", "at": "2026-11-19T12:23:41.79117154Z" } } } } ] } <!-- mesh-act:view.record/main_1028_f73997fa/a2bb48de34069746.novox/mesh-sdk#199@1795091024871874735.454a41ee -->
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-sdk#199