A change that adds a compiled binary is refused, in any repository (issue 1577) #99

Merged
mesh-tools merged 2 commits from fix/1577-checker-refuses-binaries into main 2026-10-26 19:32:25 +00:00
Member

Issue 1577, part 2: met four times on 2026-10-26 (committed binaries in mesh-catalog and mesh-delivery branches, one of 17.8 MB). Part 1 (mesh-catalog #507, delivered 19:19) refuses an ELF under modules/ in the catalogue only; this group makes the checker refuse any added binary in any repository's change, commit by commit (base..head), so a binary in a branch's history is refused too.

Quick fix: a .gitignore line per repository. Thorough fix (chosen): the shared check in mesh-sdk, used by the checker for every repository, because the kind met four times in three repositories.

Group: mesh-sdk (this), mesh-catalog, mesh-delivery on branch fix/1577-checker-refuses-binaries. mesh-sdk merges first, as a merge commit: the others pin this head.

Tried: try-1793040485235020449 passed (unit 1460, integration 1470).

Reviewed-by: review-1577b@shanks at fe11db9293

Issue 1577, part 2: met four times on 2026-10-26 (committed binaries in mesh-catalog and mesh-delivery branches, one of 17.8 MB). Part 1 (mesh-catalog #507, delivered 19:19) refuses an ELF under modules/ in the catalogue only; this group makes the checker refuse any added binary in any repository's change, commit by commit (base..head), so a binary in a branch's history is refused too. Quick fix: a .gitignore line per repository. Thorough fix (chosen): the shared check in mesh-sdk, used by the checker for every repository, because the kind met four times in three repositories. Group: mesh-sdk (this), mesh-catalog, mesh-delivery on branch fix/1577-checker-refuses-binaries. **mesh-sdk merges first, as a merge commit**: the others pin this head. Tried: try-1793040485235020449 passed (unit 1460, integration 1470). Reviewed-by: review-1577b@shanks at fe11db9293973f098ef48eebe350a684574d2b39
mesh-tools added 2 commits 2026-10-26 19:23:57 +00:00
MergeInto also names programs a commit of the branch added and a later one removed: the merge commit would keep the blob in history (issue 1577)
mesh/delivery merged: source.main moved to novox/mesh-sdk@dae8e288d2e1
mesh/delivery-group group fix/1577-checker-refuses-binaries merged: every member is merged
mesh/check checking fe11db929397 on a7a1fbd34e1d | novox/mesh-sdk#99 in group fix/1577-checker-refuses-binaries
fe11db9293
Author
Member

Delivery novox/mesh-sdk@fe11db929397 — merged since 2026-10-26T19:32:26Z

Source — source.main moved to novox/mesh-sdk@dae8e288d2. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/1577-checker-refuses-binaries: novox/mesh-catalog@8530a9730f, novox/mesh-delivery@d74e082155, novox/mesh-sdk@fe11db9293

Transitions

  • 2026-10-26 19:24 (new) → proposed (announced): novox/mesh-sdk#99's head announced
  • 2026-10-26 19:24 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-10-26 19:32 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-sdk@fe11db929397` — **merged** since 2026-10-26T19:32:26Z **Source** — source.main moved to novox/mesh-sdk@dae8e288d2e1. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/1577-checker-refuses-binaries`: novox/mesh-catalog@8530a9730fbc, novox/mesh-delivery@d74e0821552c, novox/mesh-sdk@fe11db929397 **Transitions** - 2026-10-26 19:24 (new) → proposed (announced): novox/mesh-sdk#99's head announced - 2026-10-26 19:24 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-26 19:32 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
Author
Member

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.
mesh-tools merged commit dae8e288d2 into main 2026-10-26 19:32:25 +00:00
mesh-tools deleted branch fix/1577-checker-refuses-binaries 2026-10-26 19:32:25 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-sdk#99