node-tools says it is the tool runner (tool-runner), so mesh-sdk and its readers never know it by its name; pinned at mesh-sdk a973bfa (issue 774, the operator 2026-11-03)

2026-11-03 17:15:16 +01:00
parent 8c1e04dd37
commit ea516ece5a
4 changed files with 13 additions and 5 deletions
@@ -206,7 +206,12 @@ func TestTheManifestNamesNothingOfTheController(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	if refused := catalogue.ManifestRefusals(map[string]catalogue.Manifest{Module: m}); len(refused) != 0 {
-		t.Errorf("the controller-dependence check refuses node-tools' manifest: %v", refused)
+	// Read as text, as mesh-catalog's controllerdeps check reads its own: mesh-sdk names no module (issue 774), and the
+	// manifest says it is the tool runner rather than being known by its name.
+	if strings.Contains(string(raw), "mesh-controller") {
+		t.Error("node-tools' manifest names the ended controller")
+	}
+	if !catalogue.IsToolRunner(m) {
+		t.Error("node-tools' manifest does not say it is the tool runner (\"tool-runner\": true)")
 	}
 }