mesh_search leaves out filler words, so a question in plain words finds its tool #44

Merged
mesh-tools merged 1 commits from fix/search-ignores-filler into main 2026-10-26 13:39:25 +00:00
Member

mesh_search requires every word of a query to match a tool's name, its replaced commands or its description. A question in plain words, such as the operator's "did our weekly system upgrade run on all our nodes?", therefore found nothing, because function words like "did", "our", "on" and "all" are in no description. Search now trims sentence punctuation from the ends of each query word and leaves out a short list of filler words before matching; every other word must still match. A query made only of filler words finds nothing. Matching a replaced shell command still reads the whole query and is unchanged. This follows the instruction one-question-one-tool (a tool that exists but the question's plain words do not find gets found).

Tests: TestSearchIgnoresFillerWords (the operator's question, filler-only and empty queries, a question with a real word no tool has). go test ./... and go vet -tags integration ./... clean. Try try-1793019856814103411 passed.

Notes left for later (review, not wrong): the bonus for a tool name said whole compares against filtered words, so a name with a filler part (dunst_close_all) cannot earn it; the comment's rule 2 should say "every word but filler".

Reviewed-by: review-pacman@shanks at 9f25e5c9f6

mesh_search requires every word of a query to match a tool's name, its replaced commands or its description. A question in plain words, such as the operator's "did our weekly system upgrade run on all our nodes?", therefore found nothing, because function words like "did", "our", "on" and "all" are in no description. Search now trims sentence punctuation from the ends of each query word and leaves out a short list of filler words before matching; every other word must still match. A query made only of filler words finds nothing. Matching a replaced shell command still reads the whole query and is unchanged. This follows the instruction one-question-one-tool (a tool that exists but the question's plain words do not find gets found). Tests: TestSearchIgnoresFillerWords (the operator's question, filler-only and empty queries, a question with a real word no tool has). go test ./... and go vet -tags integration ./... clean. Try try-1793019856814103411 passed. Notes left for later (review, not wrong): the bonus for a tool name said whole compares against filtered words, so a name with a filler part (dunst_close_all) cannot earn it; the comment's rule 2 should say "every word but filler". Reviewed-by: review-pacman@shanks at 9f25e5c9f6c1e26303e360eb4ee29153335807db
mesh-tools added 1 commit 2026-10-26 13:15:35 +00:00
mesh_search: filler words of a question (did, our, on, all) need not match, so the operator's own words find a tool; a query of filler finds nothing
mesh/delivery merged: source.main moved to novox/mesh-tools@a5097dc69ab2
mesh/check pass 9f25e5c9f6c1 on a5097dc69ab2 | carried from bb6a0e3192db | unit 116 run, 11 kept, 11 skipped | integration 118 run, 11 kept, 10 skippe…
9f25e5c9f6
Author
Member

Delivery novox/mesh-tools@9f25e5c9f6c1 — merged since 2026-10-26T13:39:26Z

Source — source.main moved to novox/mesh-tools@a5097dc69a. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

  • 2026-10-26 13:15 (new) → proposed (announced): novox/mesh-tools#44's head announced
  • 2026-10-26 13:15 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-10-26 13:39 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-tools@9f25e5c9f6c1` — **merged** since 2026-10-26T13:39:26Z **Source** — source.main moved to novox/mesh-tools@a5097dc69ab2. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-10-26 13:15 (new) → proposed (announced): novox/mesh-tools#44's head announced - 2026-10-26 13:15 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-26 13:39 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
mesh-tools merged commit a5097dc69a into main 2026-10-26 13:39:25 +00:00
mesh-tools deleted branch fix/search-ignores-filler 2026-10-26 13:39:25 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-tools#44