The bus state guard lets a provider reference under a provision named like a credential pass (L2's seed, issue 1126) #47

Merged
mesh-tools merged 3 commits from fix/1126-state-guard into main 2026-10-28 21:01:25 +00:00
Member

The cause: the seed of placement (mesh-delivery-assigner.adopt, ADR 0567) was refused at its first candidate, "candidates..ace carries a field "secret", which names a credential". The field is a placement's binding of the provision named secret to the vault (icecast's and redis's bindings: {"secret": {"node": "novox", "module": "mesh-vault"}}): a provider, never a credential's value. The guard (node-tools/internal/bus/state.go, credentialField, which also guards logs and seat states) took every key whose name ends like a credential as one.

The rule: a credential-shaped name passes only when it holds exactly a provider reference, an object of node and module and nothing else, each a name as mesh-sdk names them (lower case, digits, dashes). Every other shape under such a name is refused as before: a value, a list, an object with any other field, or a name that is no name. Rows: the binding passes; {"secret":{"value":"s"}}, a reference with an extra field, a module that is no string, a credential in module, a list, and a nested token are refused.

Issue 1126, ADR 0567.

Reviewed-by: rev-l2@shanks at 2966c1e32c (the review's name-pattern note folded in)

The cause: the seed of placement (mesh-delivery-assigner.adopt, ADR 0567) was refused at its first candidate, "candidates.<id>.ace carries a field \"secret\", which names a credential". The field is a placement's binding of the provision named `secret` to the vault (icecast's and redis's `bindings: {"secret": {"node": "novox", "module": "mesh-vault"}}`): a provider, never a credential's value. The guard (node-tools/internal/bus/state.go, credentialField, which also guards logs and seat states) took every key whose name ends like a credential as one. The rule: a credential-shaped name passes only when it holds exactly a provider reference, an object of `node` and `module` and nothing else, each a name as mesh-sdk names them (lower case, digits, dashes). Every other shape under such a name is refused as before: a value, a list, an object with any other field, or a name that is no name. Rows: the binding passes; `{"secret":{"value":"s"}}`, a reference with an extra field, a module that is no string, a credential in `module`, a list, and a nested token are refused. Issue 1126, ADR 0567. Reviewed-by: rev-l2@shanks at 2966c1e32c3dc80fc57880b6204e32fd393061fe (the review's name-pattern note folded in)
mesh-tools added 3 commits 2026-10-28 20:50:16 +00:00
Author
Member

Delivery novox/mesh-tools@2966c1e32c3d — merged since 2026-10-28T21:01:27Z

Source — source.main moved to novox/mesh-tools@95a12105cf. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

  • 2026-10-28 20:50 (new) → proposed (announced): novox/mesh-tools#47's head announced
  • 2026-10-28 20:50 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-10-28 21:01 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-tools@2966c1e32c3d` — **merged** since 2026-10-28T21:01:27Z **Source** — source.main moved to novox/mesh-tools@95a12105cf7b. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-10-28 20:50 (new) → proposed (announced): novox/mesh-tools#47's head announced - 2026-10-28 20:50 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-28 21:01 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
mesh-tools merged commit 95a12105cf into main 2026-10-28 21:01:25 +00:00
mesh-tools deleted branch fix/1126-state-guard 2026-10-28 21:01:25 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-tools#47