The tool runner reads the grants part's memberships through the mesh-sdk codec (issue 774) #49

Merged
jschoubben merged 2 commits from fix/memberships-shape into main 2026-10-30 14:42:21 +00:00
Member

Recovery of design 47's release (issue 774, L3). Group fix/memberships-shape: mesh-sdk, mesh-delivery, mesh-tools; merge mesh-sdk first.

Fault (live 2026-10-30 14:11): mesh-grants wrote its state memberships wrapped ({node,module,digest,membership:{...},published}); the new tool runner decoded it bare, so every module on novox was issued no tools and no state (0 tools served); novox's tool runner is held on c9f6c674 meanwhile.

Quick fix: the tool runner unwraps. Thorough fix (chosen): one codec in mesh-sdk (membership.EncodeGrantsMembership / DecodeGrantsMembership; the decoder takes the bare shape, or an old wrapper only when it says published or unchanged); mesh-grants writes the bare membership, only when published or unchanged; node-tools reads through the codec, a refused value leaves the stream copy in force. The fixture that hid it (written by hand in the reader's shape) now writes through the encoder, and an integration test writes the grants part's real wrapped shape, including a held-back one. Recovery mode: no check waited on; the operator merges by hand.

Reviewed-by: rev-memberships@shanks at ac645e2cae

Recovery of design 47's release (issue 774, L3). Group fix/memberships-shape: mesh-sdk, mesh-delivery, mesh-tools; merge mesh-sdk first. Fault (live 2026-10-30 14:11): mesh-grants wrote its state memberships wrapped ({node,module,digest,membership:{...},published}); the new tool runner decoded it bare, so every module on novox was issued no tools and no state (0 tools served); novox's tool runner is held on c9f6c674 meanwhile. Quick fix: the tool runner unwraps. Thorough fix (chosen): one codec in mesh-sdk (membership.EncodeGrantsMembership / DecodeGrantsMembership; the decoder takes the bare shape, or an old wrapper only when it says published or unchanged); mesh-grants writes the bare membership, only when published or unchanged; node-tools reads through the codec, a refused value leaves the stream copy in force. The fixture that hid it (written by hand in the reader's shape) now writes through the encoder, and an integration test writes the grants part's real wrapped shape, including a held-back one. Recovery mode: no check waited on; the operator merges by hand. Reviewed-by: rev-memberships@shanks at ac645e2caeddd1b1237689e0e98e00d730168058
mesh-tools added 2 commits 2026-10-30 14:41:24 +00:00
The tool runner unmarshalled the state's value straight into its membership; the grants part had written its wrapper
there, so every module decoded empty, was marked as given by the grants part, and the correct copy on the assignments
stream was passed over: novox served no tool. followGrants now reads with membership.BareGrantsMembership, which takes
the bare membership, still takes the old wrapper (what the live mesh holds until the part writes again), and refuses
a value naming no node or module, leaving the stream's copy in force.

The fixture IssueInGrants built its value by hand from this package's type and so agreed with the mistake; it now
writes through mesh-sdk's encoder, and IssueInGrantsWrapped writes the old wrapper for one integration test that
proves tools and state are served from it (it fails without this fix with the empty membership seen live).

Issue 774 (the bus login list, L3). Quick fix: unwrap here alone. Thorough, chosen: one codec in mesh-sdk the writer
and this reader share, so the two cannot drift again. Pins mesh-sdk at the head of its fix/memberships-shape.
Refuse a held-back membership's old wrapper in the tool runner, pinning mesh-sdk's review-round-1 codec
mesh/delivery merged: source.main moved to novox/mesh-tools@0edcd2501dae
mesh/delivery-group group fix/memberships-shape merged: every member is merged
mesh/check checking ac645e2caedd on 3c9068f99a43 | novox/mesh-tools#49 in group fix/memberships-shape
ac645e2cae
The old grants part wrote its wrapper for a held-back membership too; the new part leaves such a key alone, and taking
it would serve what the hold kept back with the stream's copy ignored. The integration test now proves that copy is
served instead. Review round 1 of issue 774's fix.
Author
Member

Delivery novox/mesh-tools@ac645e2caedd — merged since 2026-10-30T14:42:22Z

Source — source.main moved to novox/mesh-tools@0edcd2501d. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/memberships-shape: novox/mesh-delivery@180a3fe5db, novox/mesh-sdk@83cf97b690, novox/mesh-tools@ac645e2cae

Transitions

  • 2026-10-30 14:41 (new) → proposed (announced): novox/mesh-tools#49's head announced
  • 2026-10-30 14:41 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-10-30 14:42 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-tools@ac645e2caedd` — **merged** since 2026-10-30T14:42:22Z **Source** — source.main moved to novox/mesh-tools@0edcd2501dae. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/memberships-shape`: novox/mesh-delivery@180a3fe5db30, novox/mesh-sdk@83cf97b690f5, novox/mesh-tools@ac645e2caedd **Transitions** - 2026-10-30 14:41 (new) → proposed (announced): novox/mesh-tools#49's head announced - 2026-10-30 14:41 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-30 14:42 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
jschoubben merged commit 0edcd2501d into main 2026-10-30 14:42:21 +00:00
jschoubben deleted branch fix/memberships-shape 2026-10-30 14:42:21 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-tools#49