Playbooks 07 and 08: the five rules from the delivery-time audit #375

Merged

jschoubben merged 7 commits from playbooks/07-08-time-sinks into main 2026-10-16 12:24:08 +00:00

Conversation 6 Commits 7 Files Changed 3

+94 -12

mesh-tools commented 2026-10-16 08:12:53 +00:00

Member

Copy Link

Copy Source

From the delivery-time audit of 2026-10-16, confirmed by the operator.

1. A review asks only what makes the change wrong; a finding outside the issue's done-when is opened as its own issue, never another round (issue 704: seven rounds in 5½ hours).
2. Push the branch and run mesh-controller.try before opening the pull request (a feature branch's first check failed on 29 problems). Takes in hq #369, which this replaces.
3. The reviewer marks the pull request ready as soon as it approves; the operator's word is waited for only when a change alters what the operator sees, removes data, or needs the operator's terminal (mesh-catalog #300 waited 12 h 17 min unmarked).
4. A change to a module is proven with the module running whole, or in the lab, before it is marked ready (the mail modules failed live three times, issues 859, 865, 868).
5. A stopped issue goes back to open with a note (98 issues held in fixing).

Also: a merge into a branch other than main is not a delivery (issue 889).

Reviewed by an independent reviewer before the push; its round-1 findings are fixed in b1106a9. sh merge-check.sh passes. The same rules go to every session as the instruction section keep-a-change-moving, which waits for the operator's Approve.

From the delivery-time audit of 2026-10-16, confirmed by the operator. 1. A review asks only what makes the change wrong; a finding outside the issue's done-when is opened as its own issue, never another round (issue 704: seven rounds in 5½ hours). 2. Push the branch and run `mesh-controller.try` before opening the pull request (a feature branch's first check failed on 29 problems). Takes in hq #369, which this replaces. 3. The reviewer marks the pull request ready as soon as it approves; the operator's word is waited for only when a change alters what the operator sees, removes data, or needs the operator's terminal (mesh-catalog #300 waited 12 h 17 min unmarked). 4. A change to a module is proven with the module running whole, or in the lab, before it is marked ready (the mail modules failed live three times, issues 859, 865, 868). 5. A stopped issue goes back to `open` with a note (98 issues held in `fixing`). Also: a merge into a branch other than main is not a delivery (issue 889). Reviewed by an independent reviewer before the push; its round-1 findings are fixed in b1106a9. `sh merge-check.sh` passes. The same rules go to every session as the instruction section `keep-a-change-moving`, which waits for the operator's Approve.

mesh-tools commented 2026-10-16 08:13:05 +00:00

Author

Member

Copy Link

Copy Source

Delivery novox/hq@1efa37957db2 — delivered since 2026-10-16T12:24:08Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Transitions

• 2026-10-16 09:28 (new) → proposed (announced): novox/hq#375's head announced
• 2026-10-16 09:30 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
• 2026-10-16 09:30 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
• 2026-10-16 12:24 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
• 2026-10-16 12:24 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/hq@1efa37957db2` — **delivered** since 2026-10-16T12:24:08Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Transitions** - 2026-10-16 09:28 (new) → proposed (announced): novox/hq#375's head announced - 2026-10-16 09:30 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-16 09:30 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-16 12:24 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-16 12:24 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.

mesh-tools commented 2026-10-16 08:13:27 +00:00

Author

Member

Copy Link

Copy Source

Merge check at b1106a99: head b1106a9908 merged into trunk 08d6476e52, pass

Out of date when it landed: out of date: judged against trunk 08d6476e52, the trunk is now c22b58143b74; judged again on a recheck or when it is merged

**Merge check** at `b1106a99`: head b1106a990839 merged into trunk 08d6476e5287, pass **Out of date when it landed**: out of date: judged against trunk 08d6476e5287, the trunk is now c22b58143b74; judged again on a recheck or when it is merged

jschoubben added 5 commits 2026-10-16 08:14:44 +00:00

Try a small fix's branch before its pull request, since local runs miss the check's toolchain (playbook 08) ea359ea4e6

Playbooks 07 and 08: review asks only what makes a change wrong, try before opening, mark ready on approval, prove a module whole first, hand back stopped issues ... c5fa1de264

From the delivery-time audit of 2026-10-16: seven review rounds on issue 704, a feature branch's first
check failing on 29 problems, mesh-catalog #300 waiting 12 h unmarked, the mail modules failing live,
98 issues held in fixing.

Playbooks 07 and 08: checks for every new rule, the ready mark's bound in both, the lead marks an unreviewed edit (review round 1) 4e822c56a0

Playbooks 07 and 08: prove a module whole on a throwaway bus and store, not in the lab while its runs are too slow (the operator, 2026-10-16) cb98a08384

Playbooks 07 and 08: a module's acceptance is an integration test the forge runs, and try runs on the builder (ADR 0391) f95043e379

jschoubben force-pushed playbooks/07-08-time-sinks from 36e11f3dbd to f95043e379 2026-10-16 08:14:44 +00:00 Compare

jschoubben added 1 commit 2026-10-16 08:15:33 +00:00

Playbooks 07 and 08: integration tests only in the merge check, no try before it, no lab and no end-to-end tests yet (the operator, 2026-10-16) 47f7321c05

mesh-tools commented 2026-10-16 08:15:54 +00:00

Author

Member

Copy Link

Copy Source

Changed after the operator's word of 2026-10-16 on tests (unit tests continuously, the whole suite under a second; integration tests only in the merge check, under a minute; no end-to-end tests yet; the lab not used): rule 2 (try before opening) is removed again, which also drops what hq #369 added; rule 4 is now an integration test that starts the module whole, run by the merge check. Rebased on main after hq #374 (ADR 0391). Head 47f7321.

Changed after the operator's word of 2026-10-16 on tests (unit tests continuously, the whole suite under a second; integration tests only in the merge check, under a minute; no end-to-end tests yet; the lab not used): rule 2 (try before opening) is removed again, which also drops what hq #369 added; rule 4 is now an integration test that starts the module whole, run by the merge check. Rebased on main after hq #374 (ADR 0391). Head 47f7321.

jschoubben added 1 commit 2026-10-16 09:28:36 +00:00

Playbooks 07 and 08: is the coast clear? Hold a push while a release branch in flight shares its files; the glossary's release branch ... 1efa37957d

The operator, 2026-10-16: the file module waited for feature 57's release branch, which changes four of the
same controller files.

mesh-tools commented 2026-10-16 11:31:58 +00:00

Author

Member

Copy Link

Copy Source

ready at 1efa37957d

Approved by the independent review of 2026-10-16; the operator delegated the review.

ready at 1efa37957db2c4d2b45c5d07ea947e75c279022f Approved by the independent review of 2026-10-16; the operator delegated the review.

mesh-tools commented 2026-10-16 11:32:01 +00:00

Author

Member

Copy Link

Copy Source

mesh-delivery: the ready mark at is cleared: the head is now 1efa37957d, pushed after it. Mark the new head ready once it is reviewed.

mesh-delivery: the ready mark at is cleared: the head is now 1efa37957db2c4d2b45c5d07ea947e75c279022f, pushed after it. Mark the new head ready once it is reviewed.

mesh-tools commented 2026-10-16 12:00:14 +00:00

Author

Member

Copy Link

Copy Source

mesh-delivery: the ready mark at is cleared: the head is now 1efa37957d, pushed after it. Mark the new head ready once it is reviewed.

mesh-delivery: the ready mark at is cleared: the head is now 1efa37957db2c4d2b45c5d07ea947e75c279022f, pushed after it. Mark the new head ready once it is reviewed.

jschoubben merged commit 06998cc8d9 into main 2026-10-16 12:24:08 +00:00

jschoubben deleted branch playbooks/07-08-time-sinks 2026-10-16 12:24:08 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

mesh/ready

Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)

No labels

Milestone

No items

No Milestone

Assignees

Clear assignees

jschoubben mesh-tools miel.truyen

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/hq#375