build modules: cite A-489b on the step-ends kit case, its check and the node's need

Builds: design 47 G §24; lead answer A-489b

Claude-Session: https://claude.ai/code/session_01JG73KHUnBze48rdua8u2sy
This commit is contained in:
2026-11-19 15:38:16 +01:00
parent e1521a2ecf
commit 0a446c7572
5 changed files with 5 additions and 5 deletions
+1 -1
View File
@@ -91,7 +91,7 @@ func Judge(root string) ([]Judged, error) {
refused = append(refused, fmt.Sprintf("it claims %s, and no test of it calls conformance.LeftRunning "+
"(mesh-build-go buildstep/conformance): run the kit's left-running case with the module's own start sweep (issue 1890)", seat))
}
// Every build module is asked pipeline steps, so every one runs the case that its steps can say a step's end: without a
// A-489b: every build module is asked pipeline steps, so every one runs the case that its steps can say a step's end: without a
// SayStep every step ask is refused live ("this build module says no step's end"), as mesh-build-node's was.
ends, err := runsTheKit(dir, "conformance.StepEnds(")
if err != nil {
@@ -57,7 +57,7 @@ func TestTheStepsSayAFailedNetworkAsATransportFault(t *testing.T) {
})
}
// Design 47 G §24 (*Asked on a work queue, ended by an event*): the module's own steps can say a pipeline step's end, or
// A-489b, design 47 G §24: the module's own steps can say a pipeline step's end, or
// every step ask the runner sends it is refused ("this build module says no step's end"), as the first live pipeline met.
func TestTheStepsCanSayAStepsEnd(t *testing.T) {
conformance.StepEnds(t, (&Module{Node: "kitnode"}).askSteps(nil))
@@ -45,7 +45,7 @@ func TestTheStepsSayAFailedNetworkAsATransportFault(t *testing.T) {
})
}
// Design 47 G §24 (*Asked on a work queue, ended by an event*): the module's own steps can say a pipeline step's end, or
// A-489b, design 47 G §24: the module's own steps can say a pipeline step's end, or
// every step ask the runner sends it is refused ("this build module says no step's end"), as the first live pipeline met.
func TestTheStepsCanSayAStepsEnd(t *testing.T) {
conformance.StepEnds(t, (&Module{Node: "kitnode"}).askSteps(nil))
@@ -50,7 +50,7 @@ func TestTheStepsSayAFailedNetworkAsATransportFault(t *testing.T) {
})
}
// Design 47 G §24 (*Asked on a work queue, ended by an event*): the module's own steps can say a pipeline step's end, or
// A-489b, design 47 G §24: the module's own steps can say a pipeline step's end, or
// every step ask the runner sends it is refused ("this build module says no step's end"), as the first live pipeline met.
func TestTheStepsCanSayAStepsEnd(t *testing.T) {
conformance.StepEnds(t, (&Module{Node: "kitnode"}).askSteps(nil))
@@ -51,6 +51,6 @@ func (m *Module) lintStep(ctx context.Context, args map[string]any) (any, error)
return steprun.LintAnswer{Failed: failed, Nothing: !linted}, nil
}
// Has says whether this node has a need a package's tests name (sdkstep.AskNeeds): the need node-build-node is this module's own
// A-489b: Has says whether this node has a need a package's tests name (sdkstep.AskNeeds): the need node-build-node is this module's own
// (a TypeScript package's tests run through it); any other it lacks.
func (m *Module) Has(need string) bool { return need == sdkstep.NeedNodeBuildNode }