novox/mesh-catalog
18
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Drop the unreachable 'before its check ends' caveat (issue 1733)
mesh/delivery merged: source.main moved to novox/mesh-catalog@158348ede789
Details
mesh/delivery-group group fix/1733-no-hour merged: every member is merged
Details
mesh/check pass f37f93e812df on ff4c6c04358a | carried from mesh-delivery 1f6f4eda3208 | unit 470 run, 4760 kept, 13 skipped | integration 503 run, 48…

Browse Source
This commit is contained in:
jschoubben
2026-10-28 21:00:09 +01:00
parent cf4879eaa1
commit f37f93e812
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/mesh-delivery-gate/cmd/mesh-delivery-gate/approval.go
+3 -3
View File
@@ -157,8 +157,8 @@ func checkClause(c checkSaid, sep string) string {
return ": " + c.Words return ": " + c.Words
} }
// approveCaveat is what an Approve does beyond the merge while the check has not passed: it merges before the check ends, // approveCaveat is what an Approve does beyond the merge while the check has not passed: it merges although it failed (the check gates
// or although it failed (the check gates no merge, check-gates-merge false). Empty once it passed. // no merge, check-gates-merge false). Empty once it passed; an ask is made only with a verdict.
func approveCaveat(c checkSaid) string { func approveCaveat(c checkSaid) string {
switch c.Key { switch c.Key {
case checkSaidPass: case checkSaidPass:
@@ -166,7 +166,7 @@ func approveCaveat(c checkSaid) string {
case checkSaidFail: case checkSaidFail:
return " although its check failed" return " although its check failed"
} }
return " now, before its check ends" return ""
} }
// composeMergeAsk is the ask for a delivery, or for a group's members together. // composeMergeAsk is the ask for a delivery, or for a group's members together.