Drop the unreachable 'before its check ends' caveat (issue 1733)

2026-10-28 21:00:09 +01:00
parent cf4879eaa1
commit f37f93e812
1 changed files with 3 additions and 3 deletions
@@ -157,8 +157,8 @@ func checkClause(c checkSaid, sep string) string {
 	return ": " + c.Words
 }

-// approveCaveat is what an Approve does beyond the merge while the check has not passed: it merges before the check ends,
-// or although it failed (the check gates no merge, check-gates-merge false). Empty once it passed.
+// approveCaveat is what an Approve does beyond the merge while the check has not passed: it merges although it failed (the check gates
+// no merge, check-gates-merge false). Empty once it passed; an ask is made only with a verdict.
 func approveCaveat(c checkSaid) string {
 	switch c.Key {
 	case checkSaidPass:
@@ -166,7 +166,7 @@ func approveCaveat(c checkSaid) string {
 	case checkSaidFail:
 		return " although its check failed"
 	}
-	return " now, before its check ends"
+	return ""
 }

 // composeMergeAsk is the ask for a delivery, or for a group's members together.