xorg: list the server's windows, and cut a window's screenshot from the screen (hq issue 345) #154

Merged
mesh-admin merged 2 commits from fix/xorg-windows-and-window-screenshot into main 2026-10-09 10:51:01 +00:00
Contributor

Part of hq issue 345 (a calendar reminder shows as a transparent, empty window on the workstation). Do not merge without review.

Why. Looking at that window was not possible with the mesh's tools:

  • node-display-session.windows lists only windows i3 manages, so the reminder dialog was missing, and it says nothing a compositor decides by.
  • xorg_screenshot with window ran xwd -id, which was reported failing with X Error BadColor (invalid Colormap parameter) X_QueryColors (and answers BadWindow for a window that just closed).

What changes.

  • New tool xorg_windows: every window from xwininfo -root -tree (id, name, instance/class, size, absolute place, tree level). With class/name (regexes) or detail: depth (argb for 32-bit), visual class, map state, override-redirect, window types and states (xwininfo -all), and role and own opacity (xprop, the picom module's package; left out when absent). At most 40 windows detailed.
  • xorg_screenshot with window now cuts the window's rectangle from the whole-screen dump (xwd -root), so it shows what the compositor shows and never asks for the window's colormap. New inline flag: the PNG as base64 in the answer (at most 4 MiB), for a session that cannot read the machine's files.
  • Declares xorg-xwininfo (no other module declares it; installed on the workstation already, explicitly).

What assigning does. xorg moves on every node it is on: the new bundle, and the package xorg-xwininfo where missing. No file changes.

Checks. merge-check.sh on the merge result with origin/main 7339ce8 and a controller built from mesh-controller main 4d60628: words, paths, module check (xorg: ok, 9 tool(s)), health count 70 as kept, go vet + go test -race for modules/xorg: pass. The parsers were written against real xwininfo output from the workstation (fixtures in windows_test.go).

Part of hq issue 345 (a calendar reminder shows as a transparent, empty window on the workstation). Do not merge without review. **Why.** Looking at that window was not possible with the mesh's tools: - `node-display-session.windows` lists only windows i3 manages, so the reminder dialog was missing, and it says nothing a compositor decides by. - `xorg_screenshot` with `window` ran `xwd -id`, which was reported failing with `X Error BadColor (invalid Colormap parameter) X_QueryColors` (and answers BadWindow for a window that just closed). **What changes.** - New tool `xorg_windows`: every window from `xwininfo -root -tree` (id, name, instance/class, size, absolute place, tree level). With `class`/`name` (regexes) or `detail`: depth (`argb` for 32-bit), visual class, map state, override-redirect, window types and states (`xwininfo -all`), and role and own opacity (`xprop`, the picom module's package; left out when absent). At most 40 windows detailed. - `xorg_screenshot` with `window` now cuts the window's rectangle from the whole-screen dump (`xwd -root`), so it shows what the compositor shows and never asks for the window's colormap. New `inline` flag: the PNG as base64 in the answer (at most 4 MiB), for a session that cannot read the machine's files. - Declares `xorg-xwininfo` (no other module declares it; installed on the workstation already, explicitly). **What assigning does.** xorg moves on every node it is on: the new bundle, and the package `xorg-xwininfo` where missing. No file changes. **Checks.** `merge-check.sh` on the merge result with origin/main `7339ce8` and a controller built from mesh-controller main `4d60628`: words, paths, module check (`xorg: ok, 9 tool(s)`), health count 70 as kept, `go vet` + `go test -race` for modules/xorg: pass. The parsers were written against real `xwininfo` output from the workstation (fixtures in `windows_test.go`).
mesh-admin added 1 commit 2026-10-09 10:08:05 +00:00
xorg: list the server's windows, and cut a window's screenshot from the screen (hq issue 345)
mesh/merge-gate pass: builds xorg → g14, shanks; no bus step; every machine composes with the change as it did without (4 of 4 compose)
mesh/repo-check pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)
mesh/delivery superseded: a newer head of the same pull request
52a4827983
A reminder window that showed as transparent and empty could not be looked at: the window manager's
list leaves dialogs out and says nothing a compositor goes by, and xwd -id refused a window of a
32-bit visual with BadColor (X_QueryColors). xorg_windows answers every window with its class, and
on request its depth, type, state, role and own opacity; a window's screenshot is now cut from the
whole screen as the compositor shows it, and inline answers the image for a session that cannot
read the machine's files. Declares xorg-xwininfo, which both now use.
Author
Contributor

Delivery novox/mesh-catalog@4fe8958dda8f — delivered since 2026-10-09T10:55:16Z

Delivery plan — builds xorg → g14, shanks; no bus step

  • tier 0: xorg
  • g14: receives xorg
  • shanks: receives xorg
  • xorg provides x11-display: its consumers are sent again after it

Machines

  • picom on g14: judging — carried by plan-1791543061772804015
  • xdg on g14: judging — carried by plan-1791543061772804015
  • picom on shanks: judging — carried by release-1791543102500135951
  • xdg on shanks: judging — carried by release-1791543102500135951
  • xorg on g14: passed — healthy 3 times over 2m38s
  • xorg on the rest running it: sent

Transitions

  • 2026-10-09 10:25 (new) → proposed (announced): novox/mesh-catalog#154's head announced
  • 2026-10-09 10:27 proposed → checked (checked): the verdict names this commit
  • 2026-10-09 10:27 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-09 10:51 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-09 10:51 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path
  • 2026-10-09 10:55 delivering → delivered (done): its walk is done: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@4fe8958dda8f` — **delivered** since 2026-10-09T10:55:16Z **Delivery plan** — builds xorg → g14, shanks; no bus step - tier 0: xorg - g14: receives xorg - shanks: receives xorg - xorg provides x11-display: its consumers are sent again after it **Machines** - picom on g14: judging — carried by plan-1791543061772804015 - xdg on g14: judging — carried by plan-1791543061772804015 - picom on shanks: judging — carried by release-1791543102500135951 - xdg on shanks: judging — carried by release-1791543102500135951 - xorg on g14: passed — healthy 3 times over 2m38s - xorg on the rest running it: sent **Transitions** - 2026-10-09 10:25 (new) → proposed (announced): novox/mesh-catalog#154's head announced - 2026-10-09 10:27 proposed → checked (checked): the verdict names this commit - 2026-10-09 10:27 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-09 10:51 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-09 10:51 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path - 2026-10-09 10:55 delivering → delivered (done): its walk is done: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at 52a48279

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: xorg)
  • mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds xorg → g14, shanks; no bus step

  • tier 0: xorg
  • g14: receives xorg
  • shanks: receives xorg
  • xorg provides x11-display: its consumers are sent again after it

Run by the build seat on ace as build-1791540490642442459 (builds --log build-1791540490642442459).

--- the gate: xorg
xorg: ok, 9 tool(s)
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-09T08:07:39Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-09T08:07:39Z

modules the change moves:
  - xorg (changed)

machines:
  - a machine (f35): composes; the change adds 1 resource(s) and removes 0 (+package:xorg.package-xorg-xwininfo)
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes; the change adds 1 resource(s) and removes 0 (+package:xorg.package-xorg-xwininfo)

a merge would rebuild 1 module(s) in 1 tier(s): xorg
--- its merge-check.sh (go toolchain)
ok  	git.novox.be/novox/mesh-catalog/checks/words	0.002s
words: 12 retired words, none in the 34215 strings of 604 files
ok  	git.novox.be/novox/mesh-catalog/checks/paths	0.005s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 70, as kept
testing modules/xorg
ok  	xorg/cmd/xorg	1.049s
ok  	xorg/internal/desktop	1.030s
--- its merge-check-typescript.sh (typescript toolchain)
**Merge check** at `52a48279` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: xorg) - `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds xorg → g14, shanks; no bus step - tier 0: xorg - g14: receives xorg - shanks: receives xorg - xorg provides x11-display: its consumers are sent again after it Run by the build seat on ace as `build-1791540490642442459` (`builds --log build-1791540490642442459`). ``` --- the gate: xorg xorg: ok, 9 tool(s) long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-09T08:07:39Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-09T08:07:39Z modules the change moves: - xorg (changed) machines: - a machine (f35): composes; the change adds 1 resource(s) and removes 0 (+package:xorg.package-xorg-xwininfo) - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes; the change adds 1 resource(s) and removes 0 (+package:xorg.package-xorg-xwininfo) a merge would rebuild 1 module(s) in 1 tier(s): xorg --- its merge-check.sh (go toolchain) ok git.novox.be/novox/mesh-catalog/checks/words 0.002s words: 12 retired words, none in the 34215 strings of 604 files ok git.novox.be/novox/mesh-catalog/checks/paths 0.005s paths: no module names another's state on its machine (3 known, listed to go) long-running resources without health: 70, as kept testing modules/xorg ok xorg/cmd/xorg 1.049s ok xorg/internal/desktop 1.030s --- its merge-check-typescript.sh (typescript toolchain) ```
jschoubben added 1 commit 2026-10-09 10:25:56 +00:00
xorg: refuse a window that is not on the screen, and keep an inline screenshot within the bus (review of #154)
mesh/merge-gate pass: builds xorg → g14, shanks; no bus step; every machine composes with the change as it did without (4 of 4 compose)
mesh/repo-check pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)
mesh/delivery delivered
4fe8958dda
A window that is unmapped or on a hidden workspace was cut from the screen anyway, which shows what is
there instead of it. An inline image of up to 4 MiB could not cross the bus, whose largest message is
1 MiB; it is now held to 700 KiB and halved in size until it fits, saying so.
Author
Contributor

Merge check at 4fe8958d

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: xorg)
  • mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds xorg → g14, shanks; no bus step

  • tier 0: xorg
  • g14: receives xorg
  • shanks: receives xorg
  • xorg provides x11-display: its consumers are sent again after it

Run by the build seat on ace as build-1791541560332847654 (builds --log build-1791541560332847654).

--- the gate: xorg
xorg: ok, 9 tool(s)
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-09T08:07:39Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-09T08:07:39Z

modules the change moves:
  - xorg (changed)

machines:
  - a machine (f35): composes; the change adds 1 resource(s) and removes 0 (+package:xorg.package-xorg-xwininfo)
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes; the change adds 1 resource(s) and removes 0 (+package:xorg.package-xorg-xwininfo)

a merge would rebuild 1 module(s) in 1 tier(s): xorg
--- its merge-check.sh (go toolchain)
ok  	git.novox.be/novox/mesh-catalog/checks/words	0.002s
words: 12 retired words, none in the 34223 strings of 604 files
ok  	git.novox.be/novox/mesh-catalog/checks/paths	0.005s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 70, as kept
testing modules/xorg
ok  	xorg/cmd/xorg	2.351s
ok  	xorg/internal/desktop	1.027s
--- its merge-check-typescript.sh (typescript toolchain)
**Merge check** at `4fe8958d` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: xorg) - `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds xorg → g14, shanks; no bus step - tier 0: xorg - g14: receives xorg - shanks: receives xorg - xorg provides x11-display: its consumers are sent again after it Run by the build seat on ace as `build-1791541560332847654` (`builds --log build-1791541560332847654`). ``` --- the gate: xorg xorg: ok, 9 tool(s) long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-09T08:07:39Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-09T08:07:39Z modules the change moves: - xorg (changed) machines: - a machine (f35): composes; the change adds 1 resource(s) and removes 0 (+package:xorg.package-xorg-xwininfo) - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes; the change adds 1 resource(s) and removes 0 (+package:xorg.package-xorg-xwininfo) a merge would rebuild 1 module(s) in 1 tier(s): xorg --- its merge-check.sh (go toolchain) ok git.novox.be/novox/mesh-catalog/checks/words 0.002s words: 12 retired words, none in the 34223 strings of 604 files ok git.novox.be/novox/mesh-catalog/checks/paths 0.005s paths: no module names another's state on its machine (3 known, listed to go) long-running resources without health: 70, as kept testing modules/xorg ok xorg/cmd/xorg 2.351s ok xorg/internal/desktop 1.027s --- its merge-check-typescript.sh (typescript toolchain) ```
mesh-admin merged commit e9f5727cad into main 2026-10-09 10:51:01 +00:00
mesh-admin deleted branch fix/xorg-windows-and-window-screenshot 2026-10-09 10:51:01 +00:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#154