artifact-store-tools: an image a definition pins, under any name the store has had, is named by a definition (hq issue 323) #248

Closed
mesh-admin wants to merge 1 commits from fix/323-named-by-a-definition into main
Contributor

Replaced by #249: this branch's history held a real host name. Closed without merging; its branch is deleted.

Replaced by #249: this branch's history held a real host name. Closed without merging; its branch is deleted.
mesh-admin added 1 commit 2026-10-12 12:33:19 +00:00
artifact-store-tools: say an image a definition pins is named by a definition, under any name the store has had (issue 323)
mesh/merge-gate pass: builds artifact-store-tools → novox; no bus step; every machine composes with the change as it did without (4 of 4 compose)
mesh/repo-check pass: THE CHANGE ALTERS ITS OWN CHECK (merge-check.sh): main's version judged it; the change's judges the pull requests after it merges; it…
mesh/delivery stopped: the pull request closed unmerged
c0a24882f4
No record names an image the mesh did not make, so one a definition pins under an
older name of the store read as unrecorded, the same word as an image nothing
uses. The tool now reads every definition through the catalogue and says
named-by-a-definition with the module. The store's older names are the mesh's
setting older-store-names, since a catalogue names no installation. The
catalogue's check warns of a pin under an older name with the current one.
Author
Contributor

Delivery novox/mesh-catalog@c0a24882f44a — stopped since 2026-10-12T12:48:07Z

Delivery plan — builds artifact-store-tools → novox; no bus step

  • tier 0: artifact-store-tools
  • novox: receives artifact-store-tools

Transitions

  • 2026-10-12 12:33 (new) → proposed (announced): novox/mesh-catalog#248's head announced
  • 2026-10-12 12:36 proposed → checked (checked): the verdict names this commit
  • 2026-10-12 12:36 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-12 12:48 ready → stopped (closed): the pull request closed unmerged

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@c0a24882f44a` — **stopped** since 2026-10-12T12:48:07Z **Delivery plan** — builds artifact-store-tools → novox; no bus step - tier 0: artifact-store-tools - novox: receives artifact-store-tools **Transitions** - 2026-10-12 12:33 (new) → proposed (announced): novox/mesh-catalog#248's head announced - 2026-10-12 12:36 proposed → checked (checked): the verdict names this commit - 2026-10-12 12:36 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-12 12:48 ready → stopped (closed): the pull request closed unmerged The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at c0a24882

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: artifact-store-tools)
  • mesh/repo-check: PASS — THE CHANGE ALTERS ITS OWN CHECK (merge-check.sh): main's version judged it; the change's judges the pull requests after it merges; its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds artifact-store-tools → novox; no bus step

  • tier 0: artifact-store-tools
  • novox: receives artifact-store-tools
  • read by no module's build: checks/storenames/go.mod, checks/storenames/main.go, checks/storenames/main_test.go, checks/storenames/older-names, merge-check.sh

Run by the build seat on shanks as build-1791808414214932773 (builds --log build-1791808414214932773).

--- the gate: artifact-store-tools
artifact-store-tools: ok, 4 tool(s), invokes seat:mesh-controller.artifacts, seat:mesh-controller.collect, mesh-catalog.catalog_modules, mesh-catalog.catalog_module
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T12:29:08Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T12:29:08Z

modules the change moves:
  - artifact-store-tools (changed)

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes; the change adds 2 resource(s) and removes 0 (+directory:artifact-store-tools.state, +file:artifact-store-tools.store-names)
  - a machine (yvbpsm): composes

a merge would rebuild 1 module(s) in 1 tier(s): artifact-store-tools

notes:
  - checks/storenames/go.mod, checks/storenames/main.go, checks/storenames/main_test.go, checks/storenames/older-names and merge-check.sh read by no module's build, and rebuild nothing (issue 280)
--- THE CHANGE ALTERS ITS OWN CHECK (merge-check.sh): main's version judged it; the change's judges the pull requests after it merges
--- its merge-check.sh (go toolchain)
ok  	git.novox.be/novox/mesh-catalog/checks/words	0.002s
words: 12 retired words and 70 daemons' lines, none in the 43329 strings of 691 files
ok  	git.novox.be/novox/mesh-catalog/checks/agenthome	0.012s
agent-home: no archive and no file written into under the agent's home
ok  	git.novox.be/novox/mesh-catalog/checks/paths	0.006s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 69, as kept
ok  	git.novox.be/novox/mesh-catalog/checks/deps	0.215s
testing modules/artifact-store-tools
ok  	artifactstoretools/cmd/artifact-store-tools	1.044s
--- its merge-check-typescript.sh (typescript toolchain)
Unable to find image 'novox.internal:5100/mesh-tools/build@sha256:80574e27f7087675b9bbc18ab5676bceb9133866edb5e828ae18c4e26cb0c334' locally
novox.internal:5100/mesh-tools/build@sha256:80574e27f7087675b9bbc18ab5676bceb9133866edb5e828ae18c4e26cb0c334: Pulling from mesh-tools/build
501c3e032d32: Already exists
d456d1aa143e: Already exists
60f37e2c93ec: Already exists
e53f92c42dd6: Already exists
b571db164614: Already exists
c2fe729cfd79: Already exists
04e3f1b2fc31: Pulling fs layer
72c39a60d0db: Pulling fs layer
1f30a1e4018e: Pulling fs layer
d7012fa0974d: Pulling fs layer
17bcdd03abb6: Pulling fs layer
2af06d10bdf6: Pulling fs layer
2e14acb4849f: Pulling fs layer
92a8ecaa68e5: Pulling fs layer
17bcdd03abb6: Waiting
92a8ecaa68e5: Waiting
2e14acb4849f: Waiting
2af06d10bdf6: Waiting
d7012fa0974d: Waiting
04e3f1b2fc31: Verifying Checksum
04e3f1b2fc31: Download complete
04e3f1b2fc31: Pull complete
1f30a1e4018e: Verifying Checksum
1f30a1e4018e: Download complete
d7012fa0974d: Verifying Checksum
d7012fa0974d: Download complete
2af06d10bdf6: Verifying Checksum
2af06d10bdf6: Download complete
2e14acb4849f: Download complete
17bcdd03abb6: Verifying Checksum
17bcdd03abb6: Download complete
72c39a60d0db: Verifying Checksum
72c39a60d0db: Download complete
92a8ecaa68e5: Verifying Checksum
92a8ecaa68e5: Download complete
72c39a60d0db: Pull complete
1f30a1e4018e: Pull complete
d7012fa0974d: Pull complete
17bcdd03abb6: Pull complete
2af06d10bdf6: Pull complete
2e14acb4849f: Pull complete
92a8ecaa68e5: Pull complete
Digest: sha256:80574e27f7087675b9bbc18ab5676bceb9133866edb5e828ae18c4e26cb0c334
Status: Downloaded newer image for novox.internal:5100/mesh-tools/build@sha256:80574e27f7087675b9bbc18ab5676bceb9133866edb5e828ae18c4e26cb0c334
**Merge check** at `c0a24882` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: artifact-store-tools) - `mesh/repo-check`: **PASS** — THE CHANGE ALTERS ITS OWN CHECK (merge-check.sh): main's version judged it; the change's judges the pull requests after it merges; its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds artifact-store-tools → novox; no bus step - tier 0: artifact-store-tools - novox: receives artifact-store-tools - read by no module's build: checks/storenames/go.mod, checks/storenames/main.go, checks/storenames/main_test.go, checks/storenames/older-names, merge-check.sh Run by the build seat on shanks as `build-1791808414214932773` (`builds --log build-1791808414214932773`). ``` --- the gate: artifact-store-tools artifact-store-tools: ok, 4 tool(s), invokes seat:mesh-controller.artifacts, seat:mesh-controller.collect, mesh-catalog.catalog_modules, mesh-catalog.catalog_module long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 1 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T12:29:08Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T12:29:08Z modules the change moves: - artifact-store-tools (changed) machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes; the change adds 2 resource(s) and removes 0 (+directory:artifact-store-tools.state, +file:artifact-store-tools.store-names) - a machine (yvbpsm): composes a merge would rebuild 1 module(s) in 1 tier(s): artifact-store-tools notes: - checks/storenames/go.mod, checks/storenames/main.go, checks/storenames/main_test.go, checks/storenames/older-names and merge-check.sh read by no module's build, and rebuild nothing (issue 280) --- THE CHANGE ALTERS ITS OWN CHECK (merge-check.sh): main's version judged it; the change's judges the pull requests after it merges --- its merge-check.sh (go toolchain) ok git.novox.be/novox/mesh-catalog/checks/words 0.002s words: 12 retired words and 70 daemons' lines, none in the 43329 strings of 691 files ok git.novox.be/novox/mesh-catalog/checks/agenthome 0.012s agent-home: no archive and no file written into under the agent's home ok git.novox.be/novox/mesh-catalog/checks/paths 0.006s paths: no module names another's state on its machine (3 known, listed to go) long-running resources without health: 69, as kept ok git.novox.be/novox/mesh-catalog/checks/deps 0.215s testing modules/artifact-store-tools ok artifactstoretools/cmd/artifact-store-tools 1.044s --- its merge-check-typescript.sh (typescript toolchain) Unable to find image 'novox.internal:5100/mesh-tools/build@sha256:80574e27f7087675b9bbc18ab5676bceb9133866edb5e828ae18c4e26cb0c334' locally novox.internal:5100/mesh-tools/build@sha256:80574e27f7087675b9bbc18ab5676bceb9133866edb5e828ae18c4e26cb0c334: Pulling from mesh-tools/build 501c3e032d32: Already exists d456d1aa143e: Already exists 60f37e2c93ec: Already exists e53f92c42dd6: Already exists b571db164614: Already exists c2fe729cfd79: Already exists 04e3f1b2fc31: Pulling fs layer 72c39a60d0db: Pulling fs layer 1f30a1e4018e: Pulling fs layer d7012fa0974d: Pulling fs layer 17bcdd03abb6: Pulling fs layer 2af06d10bdf6: Pulling fs layer 2e14acb4849f: Pulling fs layer 92a8ecaa68e5: Pulling fs layer 17bcdd03abb6: Waiting 92a8ecaa68e5: Waiting 2e14acb4849f: Waiting 2af06d10bdf6: Waiting d7012fa0974d: Waiting 04e3f1b2fc31: Verifying Checksum 04e3f1b2fc31: Download complete 04e3f1b2fc31: Pull complete 1f30a1e4018e: Verifying Checksum 1f30a1e4018e: Download complete d7012fa0974d: Verifying Checksum d7012fa0974d: Download complete 2af06d10bdf6: Verifying Checksum 2af06d10bdf6: Download complete 2e14acb4849f: Download complete 17bcdd03abb6: Verifying Checksum 17bcdd03abb6: Download complete 72c39a60d0db: Verifying Checksum 72c39a60d0db: Download complete 92a8ecaa68e5: Verifying Checksum 92a8ecaa68e5: Download complete 72c39a60d0db: Pull complete 1f30a1e4018e: Pull complete d7012fa0974d: Pull complete 17bcdd03abb6: Pull complete 2af06d10bdf6: Pull complete 2e14acb4849f: Pull complete 92a8ecaa68e5: Pull complete Digest: sha256:80574e27f7087675b9bbc18ab5676bceb9133866edb5e828ae18c4e26cb0c334 Status: Downloaded newer image for novox.internal:5100/mesh-tools/build@sha256:80574e27f7087675b9bbc18ab5676bceb9133866edb5e828ae18c4e26cb0c334 ```
Author
Contributor

Verdict: request changes at c0a2488

Independent review (fresh clone, issue 323). go vet and go test -race pass in modules/artifact-store-tools and checks/storenames; mesh/merge-gate and mesh/repo-check both read success.

Blocking: checks/storenames/older-names commits a real installation domain.

The file reads:

registry-api.novox.be

That is the artifact store's actual old public host, not a placeholder. The rest of this PR is careful about exactly this: module.json keeps the name out of the manifest and instead reads it from the mesh setting older-store-names (trusted: false, written to the module's own state directory) "because the controller's module check refuses an installation's host name in a definition" — the PR body's own words. definitions_test.go and checks/storenames/main_test.go both use placeholder domains (registry-api.example.org, old.example), so the convention was followed everywhere except this one file, which now carries the real name permanently into git history. It also breaks the pattern several other modules in this same repo enforce by test (betterbird, blueman, clipmenu all assert their manifests never contain the literal string novox.be).

The offline check can't reach a running mesh ("this check runs before the mesh is asked anything"), so it can't read the setting the way the runtime module does — but that's a reason to get the name from somewhere that isn't committed (an env var merge-check.sh supplies at check time, or a local untracked override), or to drop the offline check and rely on the runtime module's own named-by-a-definition classification plus its warning when names aren't read. Please fix before merge.

Everything else checks out:

  • Classify only reclassifies as named-by-a-definition when the state is already unrecorded (classify.go:106) — a manifest the records name keeps the records' state.
  • The collect/sweep path always calls Classify(v, recs, nil) (tools.go:129), so definitions are never consulted there; the sweep is unchanged. UnrecordedMirrors only flags entries still in StateUnrecorded, so a definition-pinned manifest is never offered to the mirrors verb — TestAPlatformTakesTheStateOfAnIndexADefinitionNames asserts this directly and passes.
  • Catalogue-unreadable, older-names-unreadable and per-module-unread are all surfaced through definitionsWarning and prepended ahead of everything else in said, and none of those paths ever move a manifest's state away from unrecorded — confirmed in code and by TestOlderNamesNotReadAreSaidFirst / TestADefinitionNotReadIsSaidFirstAndLeavesWhatItPinsUnrecorded.
  • DefinitionsTimeout (20s) and 8 parallel readers match the PR's description. One gap: no test exercises the timeout path itself or concurrency beyond a couple of modules — the asked mock has no way to simulate a slow responder, so "not read within 20 s" is never hit in CI. Worth a follow-up test; not blocking on its own.
  • Confirmed by hand that the fix is load-bearing: commenting out the defs-based reclassification block in classify.go makes TestAnImageADefinitionPinsUnderAnOlderNameOfTheStoreIsNamedByADefinition, TestAPlatformTakesTheStateOfAnIndexADefinitionNames and TestReferencesReadTheDefinitionsUnderTheStoresOlderNames fail as the PR claims; restoring it, all tests pass again.

Reviewed at the commit named above; no other concerns.

Verdict: request changes at c0a2488 Independent review (fresh clone, issue 323). go vet and go test -race pass in modules/artifact-store-tools and checks/storenames; mesh/merge-gate and mesh/repo-check both read success. **Blocking: `checks/storenames/older-names` commits a real installation domain.** The file reads: ``` registry-api.novox.be ``` That is the artifact store's actual old public host, not a placeholder. The rest of this PR is careful about exactly this: `module.json` keeps the name out of the manifest and instead reads it from the mesh setting `older-store-names` (`trusted: false`, written to the module's own state directory) "because the controller's module check refuses an installation's host name in a definition" — the PR body's own words. `definitions_test.go` and `checks/storenames/main_test.go` both use placeholder domains (`registry-api.example.org`, `old.example`), so the convention was followed everywhere except this one file, which now carries the real name permanently into git history. It also breaks the pattern several other modules in this same repo enforce by test (betterbird, blueman, clipmenu all assert their manifests never contain the literal string `novox.be`). The offline check can't reach a running mesh ("this check runs before the mesh is asked anything"), so it can't read the setting the way the runtime module does — but that's a reason to get the name from somewhere that isn't committed (an env var `merge-check.sh` supplies at check time, or a local untracked override), or to drop the offline check and rely on the runtime module's own `named-by-a-definition` classification plus its warning when names aren't read. Please fix before merge. **Everything else checks out:** - `Classify` only reclassifies as `named-by-a-definition` when the state is already `unrecorded` (classify.go:106) — a manifest the records name keeps the records' state. - The collect/sweep path always calls `Classify(v, recs, nil)` (tools.go:129), so definitions are never consulted there; the sweep is unchanged. `UnrecordedMirrors` only flags entries still in `StateUnrecorded`, so a definition-pinned manifest is never offered to the mirrors verb — `TestAPlatformTakesTheStateOfAnIndexADefinitionNames` asserts this directly and passes. - Catalogue-unreadable, older-names-unreadable and per-module-unread are all surfaced through `definitionsWarning` and prepended ahead of everything else in `said`, and none of those paths ever move a manifest's state away from `unrecorded` — confirmed in code and by `TestOlderNamesNotReadAreSaidFirst` / `TestADefinitionNotReadIsSaidFirstAndLeavesWhatItPinsUnrecorded`. - `DefinitionsTimeout` (20s) and 8 parallel readers match the PR's description. One gap: no test exercises the timeout path itself or concurrency beyond a couple of modules — the `asked` mock has no way to simulate a slow responder, so "not read within 20 s" is never hit in CI. Worth a follow-up test; not blocking on its own. - Confirmed by hand that the fix is load-bearing: commenting out the `defs`-based reclassification block in classify.go makes `TestAnImageADefinitionPinsUnderAnOlderNameOfTheStoreIsNamedByADefinition`, `TestAPlatformTakesTheStateOfAnIndexADefinitionNames` and `TestReferencesReadTheDefinitionsUnderTheStoresOlderNames` fail as the PR claims; restoring it, all tests pass again. Reviewed at the commit named above; no other concerns.
mesh-admin closed this pull request 2026-10-12 12:47:39 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#248