artifact-store-tools: an image a definition pins, under any name the store has had, is named by a definition (hq issue 323) #248
Closed
mesh-admin
wants to merge 1 commits from
fix/323-named-by-a-definition into main
pull from: fix/323-named-by-a-definition
merge into: :main
:main
:fix/nats-stream-purge
:fix/47-G-start-2
:feat/47-G-join11
:fix/1966-gate-record-catalog
:pre/registry-milestone
:fix/1748-retake-and-resolver
:pin/sdk1
:fix/check-every-failure
:feat/l5-l7
:feat/l5-l7-a3
:feat/judge-once-pkgs
:fix/turn-handed-on-approve
:fix/checker-full-failure
:revert/774-l3
:fix/check-names-every-conflict
:fix/check-speed
:probe/1126-seed-10
:probe/1126-seed-9
:probe/1126-seed-8
:probe/1126-seed-7
:probe/1126-seed-6
:probe/1126-seed-5
:feat/1126-seed-4
:revert/1126-seed-2
:feat/774-vault-mints
:fix/1901-node-test-cause
:fix/1945-adopt-hashes
:fix/1945-vault-hashing
:feat/try-speed
:fix/1921-every-failure
:feat/r4g-finish-composer
:feat/r4g-finish-1935
:fix/1901
:fix/forge-requires-no-status
:feat/mail-list
:feat/modules-name-no-node
:fix/r4e-r2
:fix/r4e-k2
:fix/r4e-k1
:feat/r4e-leaf
:feat/r4e-buildmods
:feat/r4e-gate
:fix/1106-sdk-member-merges
:feat/r4c5-checker
:fix/xterm-config-defaults
:fix/1165-fill-retry
:feat/r4d-automx-go
:feat/r4d-n8n
:fix/1275-group-merges-whole-or-not
:fix/1129-no-drift-pass
:fix/270-nats-emits-bus-faults
:fix/claude-code-tips-preference
:fix/628-modules-declare-every-package-they-need
:fix/613-home-network-shares
:feat/bus-websocket-listener
:fix/340-tool-servers-only-from-the-terminal
:feat/the-store-collects-nightly-again
:feat/dbus-module
No Reviewers
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
agent-ace
agent-g14
agent-novox
agent-shanks
jschoubben
mesh-tools
miel.truyen
nox-agent
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: novox/mesh-catalog#248
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Replaced by #249: this branch's history held a real host name. Closed without merging; its branch is deleted.
Delivery
novox/mesh-catalog@c0a24882f44a— stopped since 2026-10-12T12:48:07ZDelivery plan — builds artifact-store-tools → novox; no bus step
Transitions
The commit's note under
refs/notes/mesh-plankeeps every transition:git log --notes=mesh-plan.Merge check at
c0a24882mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: artifact-store-tools)mesh/repo-check: PASS — THE CHANGE ALTERS ITS OWN CHECK (merge-check.sh): main's version judged it; the change's judges the pull requests after it merges; its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)Delivery plan — builds artifact-store-tools → novox; no bus step
Run by the build seat on shanks as
build-1791808414214932773(builds --log build-1791808414214932773).Verdict: request changes at
c0a2488Independent review (fresh clone, issue 323). go vet and go test -race pass in modules/artifact-store-tools and checks/storenames; mesh/merge-gate and mesh/repo-check both read success.
Blocking:
checks/storenames/older-namescommits a real installation domain.The file reads:
That is the artifact store's actual old public host, not a placeholder. The rest of this PR is careful about exactly this:
module.jsonkeeps the name out of the manifest and instead reads it from the mesh settingolder-store-names(trusted: false, written to the module's own state directory) "because the controller's module check refuses an installation's host name in a definition" — the PR body's own words.definitions_test.goandchecks/storenames/main_test.goboth use placeholder domains (registry-api.example.org,old.example), so the convention was followed everywhere except this one file, which now carries the real name permanently into git history. It also breaks the pattern several other modules in this same repo enforce by test (betterbird, blueman, clipmenu all assert their manifests never contain the literal stringnovox.be).The offline check can't reach a running mesh ("this check runs before the mesh is asked anything"), so it can't read the setting the way the runtime module does — but that's a reason to get the name from somewhere that isn't committed (an env var
merge-check.shsupplies at check time, or a local untracked override), or to drop the offline check and rely on the runtime module's ownnamed-by-a-definitionclassification plus its warning when names aren't read. Please fix before merge.Everything else checks out:
Classifyonly reclassifies asnamed-by-a-definitionwhen the state is alreadyunrecorded(classify.go:106) — a manifest the records name keeps the records' state.Classify(v, recs, nil)(tools.go:129), so definitions are never consulted there; the sweep is unchanged.UnrecordedMirrorsonly flags entries still inStateUnrecorded, so a definition-pinned manifest is never offered to the mirrors verb —TestAPlatformTakesTheStateOfAnIndexADefinitionNamesasserts this directly and passes.definitionsWarningand prepended ahead of everything else insaid, and none of those paths ever move a manifest's state away fromunrecorded— confirmed in code and byTestOlderNamesNotReadAreSaidFirst/TestADefinitionNotReadIsSaidFirstAndLeavesWhatItPinsUnrecorded.DefinitionsTimeout(20s) and 8 parallel readers match the PR's description. One gap: no test exercises the timeout path itself or concurrency beyond a couple of modules — theaskedmock has no way to simulate a slow responder, so "not read within 20 s" is never hit in CI. Worth a follow-up test; not blocking on its own.defs-based reclassification block in classify.go makesTestAnImageADefinitionPinsUnderAnOlderNameOfTheStoreIsNamedByADefinition,TestAPlatformTakesTheStateOfAnIndexADefinitionNamesandTestReferencesReadTheDefinitionsUnderTheStoresOlderNamesfail as the PR claims; restoring it, all tests pass again.Reviewed at the commit named above; no other concerns.
Pull request closed